You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/15 13:54:41 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #14301: [pulsar-admin] Add short name for full name in admin cli
yuruguo opened a new pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301
### Motivation
Add short name for full name in admin cli.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040381124
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1044441097
@codelipenghui @Jason918 @Technoboy- @eolivelli PTAL when you have a moment, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1041123818
> @yuruguo - I think it makes sense to add short options. I just wonder if we should stay away from `-v`. What is your perspective?
Maybe using `-ve` is also possible If in order to avoid the [problem](https://github.com/apache/pulsar/pull/14301#discussion_r807207672) you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040372523
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040371139
/pulsarbot run-failure-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040372523
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040376155
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#discussion_r807207672
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -64,9 +64,9 @@ void run() throws Exception {
@Parameters(commandDescription = "Update dynamic-serviceConfiguration of broker")
private class UpdateConfigurationCmd extends CliCommand {
- @Parameter(names = "--config", description = "service-configuration name", required = true)
+ @Parameter(names = {"-c", "--config"}, description = "service-configuration name", required = true)
private String configName;
- @Parameter(names = "--value", description = "service-configuration value", required = true)
+ @Parameter(names = {"-v", "--value"}, description = "service-configuration value", required = true)
Review comment:
I think we should reserve `-v` for verbose logging. I recognize that we don't have this feature currently, but we could add it, and I don't believe we're using `-v` yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040371139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040371139
/pulsarbot run-failure-check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall merged pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040461846
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo edited a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo edited a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1041123818
> @yuruguo - I think it makes sense to add short options. I just wonder if we should stay away from `-v`. What is your perspective?
Maybe using `-ve` or other is possible If in order to avoid the [problem](https://github.com/apache/pulsar/pull/14301#discussion_r807207672) you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#discussion_r807551121
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -64,9 +64,9 @@ void run() throws Exception {
@Parameters(commandDescription = "Update dynamic-serviceConfiguration of broker")
private class UpdateConfigurationCmd extends CliCommand {
- @Parameter(names = "--config", description = "service-configuration name", required = true)
+ @Parameter(names = {"-c", "--config"}, description = "service-configuration name", required = true)
private String configName;
- @Parameter(names = "--value", description = "service-configuration value", required = true)
+ @Parameter(names = {"-v", "--value"}, description = "service-configuration value", required = true)
Review comment:
I found that `-v` is used as a short name for `--value`
https://github.com/apache/pulsar/blob/a43fab0045a93ee864da6bc386bcc0e8bf17bf11/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java#L2383-L2384
Maybe using `-ve` is also possible If in order to avoid the problem you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040381124
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#discussion_r807551121
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -64,9 +64,9 @@ void run() throws Exception {
@Parameters(commandDescription = "Update dynamic-serviceConfiguration of broker")
private class UpdateConfigurationCmd extends CliCommand {
- @Parameter(names = "--config", description = "service-configuration name", required = true)
+ @Parameter(names = {"-c", "--config"}, description = "service-configuration name", required = true)
private String configName;
- @Parameter(names = "--value", description = "service-configuration value", required = true)
+ @Parameter(names = {"-v", "--value"}, description = "service-configuration value", required = true)
Review comment:
I found that `-v` is used as a short name for `--value`
https://github.com/apache/pulsar/blob/a43fab0045a93ee864da6bc386bcc0e8bf17bf11/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java#L2383-L2384
Maybe using `-ve` or other is possible If in order to avoid the problem you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040461846
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040371139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040376155
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1040669454
@yuruguo - I think it makes sense to add short options. I just wonder if we should stay away from `-v`. What is your perspective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#issuecomment-1044441097
@codelipenghui @Jason918 @Technoboy- @eolivelli PTAL when you have a moment, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14301: [pulsar-admin] Add short name for full name in admin cli
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14301:
URL: https://github.com/apache/pulsar/pull/14301#discussion_r810568650
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBrokers.java
##########
@@ -64,9 +64,9 @@ void run() throws Exception {
@Parameters(commandDescription = "Update dynamic-serviceConfiguration of broker")
private class UpdateConfigurationCmd extends CliCommand {
- @Parameter(names = "--config", description = "service-configuration name", required = true)
+ @Parameter(names = {"-c", "--config"}, description = "service-configuration name", required = true)
private String configName;
- @Parameter(names = "--value", description = "service-configuration value", required = true)
+ @Parameter(names = {"-v", "--value"}, description = "service-configuration value", required = true)
Review comment:
> I found that `-v` is used as a short name for `--value`
Okay, let's leave it as is. I think it's probably unlikely we'll add a -v for verbose logging, and if we do, we can deal with it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org