You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/09/07 23:41:47 UTC
[GitHub] [trafficserver] maskit opened a new pull request, #10386: Don't set port number as part of hostname
maskit opened a new pull request, #10386:
URL: https://github.com/apache/trafficserver/pull/10386
One of autest failed on https://github.com/apache/trafficserver/pull/10304 , and it discovered that there is a place mishandling Host header value.
The original code used the entire Host header value as a hostname, and it confused `url_print()` because "hostname" contains a colon. `url_print()` treated the hostname as IPv6 address and it added brackets to the hostname like `[foo.example:8888]`. If it's used in an URL (i.e. `http://[foo.example:8888]/`), it means/will be read as an (invalid) IPv6 address `foo.exmample:8080` and port `80`.
This PR fix the issue. The behavior is described in the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #10386: Don't set port number as part of hostname
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #10386:
URL: https://github.com/apache/trafficserver/pull/10386#issuecomment-1710893057
@treak Basically what we discussed yesterday. I added IPv6 support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #10386: Don't set port number as part of hostname
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #10386:
URL: https://github.com/apache/trafficserver/pull/10386#issuecomment-1718398707
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #10386: Don't set port number as part of hostname
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #10386:
URL: https://github.com/apache/trafficserver/pull/10386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org