You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/10 17:59:45 UTC

svn commit: r1695121 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java

Author: sebb
Date: Mon Aug 10 15:59:45 2015
New Revision: 1695121

URL: http://svn.apache.org/r1695121
Log:
Don't call overrideable methods from a constructor

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java?rev=1695121&r1=1695120&r2=1695121&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ConstantPool.java Mon Aug 10 15:59:45 2015
@@ -47,7 +47,7 @@ public class ConstantPool implements Clo
      * @param constant_pool Array of constants
      */
     public ConstantPool(Constant[] constant_pool) {
-        setConstantPool(constant_pool);
+        this.constant_pool = constant_pool;
     }
 
 
@@ -335,7 +335,7 @@ public class ConstantPool implements Clo
     /**
      * @param constant_pool
      */
-    public void setConstantPool( Constant[] constant_pool ) {
+    public void setConstantPool( Constant[] constant_pool ) { // TODO unused
         this.constant_pool = constant_pool;
     }