[jira] Commented: (GERONIMO-3934) geronimo/start-server --timeout option does not work as expected

["Jarek Gawor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580821#action_12580821 ] 

Jarek Gawor commented on GERONIMO-3934:
---------------------------------------

The important bit of code is the following:

                    if (timeout > 0) {
                        log.info("Timeout after: ${timeout} seconds")
                        node.setAttribute('timeout', "${timeout * 1000}")
                    }

That sets the timeout on the Ant Java task which explains why the --timeout option behavior.

We can remove the piece of code but we still need a way to shutdown the server in case it didn't start in time. And I'm not sure how to shutdown the server process started via Ant.

Another way to make timeout option work right is to rewrite the StartServerCommand to use ProcessBuilder API directly to start the server process instead of Ant. But that's a bigger job.


> geronimo/start-server --timeout option does not work as expected
> ----------------------------------------------------------------
>
>                 Key: GERONIMO-3934
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3934
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown
>    Affects Versions: 2.1, 2.1.1, 2.2
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>
> The --timeout option specifies the time in which the server must start up in. However, it looks like the timeout causes the server to shutdown after the given number of seconds even if the server started up successfully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.