You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Jonathan-Wei <gi...@git.apache.org> on 2018/11/22 12:20:41 UTC
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]apache-carbondata-1.5.1-rc1....
GitHub user Jonathan-Wei opened a pull request:
https://github.com/apache/carbondata/pull/2943
[CARBONDATA-3120]apache-carbondata-1.5.1-rc1.tar.gz Datamap's core and plan project, pom.xml, is version 1.5.0, which results in an inability to compile properly
fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.1
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jonathan-Wei/carbondata local-1.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2943
----
commit 2fe4e0d0beebafd778e70d3b8780e27c22cd07b9
Author: Jonathan.Wei <25...@...>
Date: 2018-11-22T12:18:50Z
fix CARBONDATA-3120
fix carbondata 1.5.1 Datamap's core and plan project, pom.xml version mismatch problem.
Update version 1.5.0 to 1.5.1
----
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2943
This PR uses the version 1.5.2-snapshot, but the main pom uses 1.6.0-snapshot.
Is it intended?
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed mv pom.xml version mismatch p...
Posted by Jonathan-Wei <gi...@git.apache.org>.
Github user Jonathan-Wei commented on the issue:
https://github.com/apache/carbondata/pull/2943
I download the apache-carbondata-1.5.1-rc1.tar.gz package.
After decompression, the datamap mv/core mv/plan project was added to the main pom for compilation。
I check the pom file, parent.version is 1.5.0-snapshot. But apache-carbondata-1.5.1-rc1.tar.gz is 1.5.1.
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2943
retest this please
---
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]Fixed the parent version err...
Posted by Jonathan-Wei <gi...@git.apache.org>.
Github user Jonathan-Wei commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2943#discussion_r235768878
--- Diff: datamap/mv/core/pom.xml ---
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
- <version>1.5.0-SNAPSHOT</version>
+ <version>1.5.1</version>
--- End diff --
The package version I downloaded was 1.5.1.
apache-carbondata-1.5.1-rc1.tar.gz
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2943
LGTM
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1724/
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9772/
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1522/
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9780/
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1514/
---
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]Fixed the parent version err...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2943#discussion_r235835392
--- Diff: datamap/mv/core/pom.xml ---
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
- <version>1.5.0-SNAPSHOT</version>
+ <version>1.5.1</version>
--- End diff --
@ravipesala @sraghunandan Have you tested MV module before/when we release 1.5.1-rc1? Why didn't change it?
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/2943
retest this please
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1732/
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2943
this PR is pushed to branch1.5.not master
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2943
LGTM
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2943
please change the content：Update version 1.5.0 to 1.5.1
=》Update version 1.5.0 to 1.5.2-SNAPSHOT
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2943
retest this please
---
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]Fixed the parent version err...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2943#discussion_r235773522
--- Diff: datamap/mv/core/pom.xml ---
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
- <version>1.5.0-SNAPSHOT</version>
+ <version>1.5.1</version>
--- End diff --
The package version you downloaded is from a tag, not from branch-1.5.
the version of all modules on branch-1.5 is 1.5.2-SNAPSHOT, when to be released, version manager will change version to 1.5.1 to tag a version package.
---
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]Fixed the parent version err...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2943#discussion_r235763576
--- Diff: datamap/mv/core/pom.xml ---
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
- <version>1.5.0-SNAPSHOT</version>
+ <version>1.5.1</version>
--- End diff --
please use 1.5.2-SNAPSHOT, not 1.5.1, the same as other module.
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2943
retest this please
---
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]Fixed the parent version err...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2943#discussion_r235763601
--- Diff: datamap/mv/plan/pom.xml ---
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.carbondata</groupId>
<artifactId>carbondata-parent</artifactId>
- <version>1.5.0-SNAPSHOT</version>
+ <version>1.5.1</version>
--- End diff --
please use 1.5.2-SNAPSHOT, not 1.5.1, the same as other module.
---
[GitHub] carbondata pull request #2943: [CARBONDATA-3120]Fixed the parent version err...
Posted by Jonathan-Wei <gi...@git.apache.org>.
Github user Jonathan-Wei closed the pull request at:
https://github.com/apache/carbondata/pull/2943
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2943
retest this please
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]apache-carbondata-1.5.1-rc1.tar.gz ...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2943
Can you optimize the title? simplify . and describe details in content. What's more, please finish the checklist.
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by Jonathan-Wei <gi...@git.apache.org>.
Github user Jonathan-Wei commented on the issue:
https://github.com/apache/carbondata/pull/2943
Fixed.
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]apache-carbondata-1.5.1-rc1.tar.gz ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2943
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #2943: [CARBONDATA-3120]Fixed the parent version error in M...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2943
add to whitelist
---