You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mi...@apache.org on 2026/03/04 18:09:51 UTC

(impala) branch master updated: IMPALA-14776 (part 1 followup): Fix TestParquetMaxPageHeader

This is an automated email from the ASF dual-hosted git repository.

michaelsmith pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new ffec3e622 IMPALA-14776 (part 1 followup): Fix TestParquetMaxPageHeader
ffec3e622 is described below

commit ffec3e622d33a5b64732e2e4de25377ac40e01ad
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Tue Mar 3 17:25:40 2026 -0800

    IMPALA-14776 (part 1 followup): Fix TestParquetMaxPageHeader
    
    Part 1 of IMPALA-14776 added a call to super.teardown_method() for
    TestParquetMaxPageHeader. However, it got the order wrong. The
    super().teardown_method() needs to come after TestParquetMaxPageHeader's
    own teardown steps, as those steps need the built-in clients.
    This moves the super().teardown_method() call to be after those
    steps.
    
    Testing:
     - Ran TestParquetMaxPageHeader
    
    Change-Id: If66b82d7386cdf748674a5a146d6b2b31471331d
    Reviewed-on: http://gerrit.cloudera.org:8080/24065
    Reviewed-by: Michael Smith <mi...@cloudera.com>
    Tested-by: Michael Smith <mi...@cloudera.com>
---
 tests/custom_cluster/test_parquet_max_page_header.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/custom_cluster/test_parquet_max_page_header.py b/tests/custom_cluster/test_parquet_max_page_header.py
index 4b97cdfae..bde700d2d 100644
--- a/tests/custom_cluster/test_parquet_max_page_header.py
+++ b/tests/custom_cluster/test_parquet_max_page_header.py
@@ -60,9 +60,9 @@ class TestParquetMaxPageHeader(CustomClusterTestSuite):
     self.__create_test_tbls()
 
   def teardown_method(self, method):
-    super(TestParquetMaxPageHeader, self).teardown_method(method)
     self.__drop_test_tbls()
     self.close_impala_clients()
+    super(TestParquetMaxPageHeader, self).teardown_method(method)
 
   def __drop_test_tbls(self):
     self.client.execute("DROP TABLE IF EXISTS %s PURGE" % self.TEXT_TABLE_NAME)