[GitHub] [iceberg] rdblue commented on a change in pull request #1185: Flink: Add the iceberg files committer to collect data files and commit to iceberg table.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1185:
URL: https://github.com/apache/iceberg/pull/1185#discussion_r478767253



##########
File path: core/src/main/java/org/apache/iceberg/io/FileAppenderFactory.java
##########
@@ -19,14 +19,15 @@
 
 package org.apache.iceberg.io;
 
+import java.io.Serializable;
 import org.apache.iceberg.FileFormat;
 
 /**
  * Factory to create a new {@link FileAppender} to write records.
  *
  * @param <T> data type of the rows to append.
  */
-public interface FileAppenderFactory<T> {
+public interface FileAppenderFactory<T> extends Serializable {

Review comment:
       This isn't required for Spark. Could we add this to the `FlinkFileAppenderFactory` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org