You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by tm...@apache.org on 2006/04/15 17:45:01 UTC
svn commit: r394308 - in /incubator/webwork2/action/src/test:
java/org/apache/struts/action2/views/jsp/ui/
resources/org/apache/struts/action2/views/jsp/ui/
Author: tmjee
Date: Sat Apr 15 08:45:00 2006
New Revision: 394308
URL: http://svn.apache.org/viewcvs?rev=394308&view=rev
Log:
- fix failing test case
Modified:
incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
Modified: incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java (original)
+++ incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java Sat Apr 15 08:45:00 2006
@@ -23,7 +23,9 @@
import org.apache.struts.action2.config.Configuration;
import org.apache.struts.action2.views.jsp.AbstractUITagTest;
import org.apache.struts.action2.views.jsp.ActionTag;
+
import com.opensymphony.xwork.ActionContext;
+import com.opensymphony.xwork.ObjectFactory;
import com.opensymphony.xwork.config.ConfigurationManager;
@@ -31,13 +33,15 @@
* FormTagTest
*
* @author Jason Carreira
- * Created Apr 3, 2003 10:28:58 AM
+ * @author tm_jee
*
* @version $Date$ $Id$
*/
public class FormTagTest extends AbstractUITagTest {
public void testForm() throws Exception {
+ ObjectFactory.setObjectFactory(new MyObjectFactory());
+
request.setupGetServletPath("/testAction");
TestAction testAction = (TestAction) action;
@@ -363,4 +367,8 @@
ConfigurationManager.addConfigurationProvider(new TestConfigurationProvider());
ActionContext.getContext().setValueStack(stack);
}
+
+ static class MyObjectFactory extends ObjectFactory {
+
+ }
}
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt Sat Apr 15 08:45:00 2006
@@ -6,3 +6,6 @@
<script>
function customOnsubmit() {}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt Sat Apr 15 08:45:00 2006
@@ -28,6 +28,10 @@
selectUnselectMatchingOptions(updownselectObj, null, "unselect", false, "key");
}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
<script>
function validateForm_myAction() {
form = document.getElementById("myAction");
@@ -36,3 +40,4 @@
var errors = false;
return !errors; }
</script>
+
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt Sat Apr 15 08:45:00 2006
@@ -6,3 +6,7 @@
<script>
function customOnsubmit() {}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt Sat Apr 15 08:45:00 2006
@@ -6,3 +6,7 @@
<script>
function customOnsubmit() {}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt Sat Apr 15 08:45:00 2006
@@ -6,3 +6,7 @@
<script>
function customOnsubmit() {}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt Sat Apr 15 08:45:00 2006
@@ -28,3 +28,6 @@
}
</script>
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt Sat Apr 15 08:45:00 2006
@@ -6,3 +6,7 @@
<script>
function customOnsubmit() {}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt?rev=394308&r1=394307&r2=394308&view=diff
==============================================================================
--- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt (original)
+++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt Sat Apr 15 08:45:00 2006
@@ -6,3 +6,7 @@
<script>
function customOnsubmit() {}
</script>
+
+<!-- javascript that is needed for tooltips -->
+<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
+
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [action2] @author tags -- is removal policy or preference? [was Re: svn commit: r394308...]
Posted by tm jee <tm...@yahoo.co.uk>.
> It's been the policy of the Apache Struts project that we don't use
> author tags
I see. I'll remove all of them when i got the time, which should be soon. :-)
----- Original Message ----
From: Ted Husted <te...@gmail.com>
To: Struts Developers List <de...@struts.apache.org>
Sent: Sunday, 16 April, 2006 8:35:17 AM
Subject: Re: [action2] @author tags -- is removal policy or preference? [was Re: svn commit: r394308...]
On 4/15/06, James Mitchell <jm...@apache.org> wrote:
> Not sure if this has been discussed yet, but who wants to talk about
> @author tags?
>
> I remember that I wasn't too happy when we removed them years ago,
> but I didn't say anything. Over time though, I totally get the
> legality of why it has to be done.
>
> Your thoughts?
The topic of author tags has been discussed in literally hundreds of
ASF posts on various mailing lists. In the end, the ASF board
determined that removing the tags is a "best practice", but it is not
a requirement.
As to why, Greg Stein sums it up well here:
* http://tinyurl.com/mw7t6
It's been the policy of the Apache Struts project that we don't use
author tags, for the reasons that Greg outines, and when people have
included author tags in patches, we've asked that the tags be removed
before accepting the patch.
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [action2] @author tags -- is removal policy or preference? [was Re: svn commit: r394308...]
Posted by Ted Husted <te...@gmail.com>.
On 4/15/06, James Mitchell <jm...@apache.org> wrote:
> Not sure if this has been discussed yet, but who wants to talk about
> @author tags?
>
> I remember that I wasn't too happy when we removed them years ago,
> but I didn't say anything. Over time though, I totally get the
> legality of why it has to be done.
>
> Your thoughts?
The topic of author tags has been discussed in literally hundreds of
ASF posts on various mailing lists. In the end, the ASF board
determined that removing the tags is a "best practice", but it is not
a requirement.
As to why, Greg Stein sums it up well here:
* http://tinyurl.com/mw7t6
It's been the policy of the Apache Struts project that we don't use
author tags, for the reasons that Greg outines, and when people have
included author tags in patches, we've asked that the tags be removed
before accepting the patch.
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[action2] @author tags -- is removal policy or preference? [was Re: svn commit: r394308...]
Posted by James Mitchell <jm...@apache.org>.
Not sure if this has been discussed yet, but who wants to talk about
@author tags?
I remember that I wasn't too happy when we removed them years ago,
but I didn't say anything. Over time though, I totally get the
legality of why it has to be done.
Your thoughts?
--
James Mitchell
On Apr 15, 2006, at 12:51 PM, Don Brown wrote:
> Thanks Toby for fixing these tests. I keep forgetting WebWork,
> even its tags, are so well unit tested :)
>
> Don
>
> tmjee@apache.org wrote:
>> Author: tmjee
>> Date: Sat Apr 15 08:45:00 2006
>> New Revision: 394308
>> URL: http://svn.apache.org/viewcvs?rev=394308&view=rev
>> Log:
>> - fix failing test case
>> Modified:
>> incubator/webwork2/action/src/test/java/org/apache/struts/
>> action2/views/jsp/ui/FormTagTest.java
<snip/>
>> *
>> * @author Jason Carreira
>> - * Created Apr 3, 2003 10:28:58 AM
>> + * @author tm_jee
>> * * @version $Date$ $Id$
>> */
<snip/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r394308 - in /incubator/webwork2/action/src/test: java/org/apache/struts/action2/views/jsp/ui/ resources/org/apache/struts/action2/views/jsp/ui/
Posted by tm jee <tm...@yahoo.co.uk>.
No problem. :-) Don actually did all the hard work of dojo component migration.
----- Original Message ----
From: Don Brown <mr...@twdata.org>
To: Struts Developers List <de...@struts.apache.org>
Sent: Sunday, 16 April, 2006 12:51:17 AM
Subject: Re: svn commit: r394308 - in /incubator/webwork2/action/src/test: java/org/apache/struts/action2/views/jsp/ui/ resources/org/apache/struts/action2/views/jsp/ui/
Thanks Toby for fixing these tests. I keep forgetting WebWork, even its
tags, are so well unit tested :)
Don
tmjee@apache.org wrote:
> Author: tmjee
> Date: Sat Apr 15 08:45:00 2006
> New Revision: 394308
>
> URL: http://svn.apache.org/viewcvs?rev=394308&view=rev
> Log:
> - fix failing test case
>
>
> Modified:
> incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
>
> Modified: incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java (original)
> +++ incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java Sat Apr 15 08:45:00 2006
> @@ -23,7 +23,9 @@
> import org.apache.struts.action2.config.Configuration;
> import org.apache.struts.action2.views.jsp.AbstractUITagTest;
> import org.apache.struts.action2.views.jsp.ActionTag;
> +
> import com.opensymphony.xwork.ActionContext;
> +import com.opensymphony.xwork.ObjectFactory;
> import com.opensymphony.xwork.config.ConfigurationManager;
>
>
> @@ -31,13 +33,15 @@
> * FormTagTest
> *
> * @author Jason Carreira
> - * Created Apr 3, 2003 10:28:58 AM
> + * @author tm_jee
> *
> * @version $Date$ $Id$
> */
> public class FormTagTest extends AbstractUITagTest {
>
> public void testForm() throws Exception {
> + ObjectFactory.setObjectFactory(new MyObjectFactory());
> +
> request.setupGetServletPath("/testAction");
>
> TestAction testAction = (TestAction) action;
> @@ -363,4 +367,8 @@
> ConfigurationManager.addConfigurationProvider(new TestConfigurationProvider());
> ActionContext.getContext().setValueStack(stack);
> }
> +
> + static class MyObjectFactory extends ObjectFactory {
> +
> + }
> }
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,6 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt Sat Apr 15 08:45:00 2006
> @@ -28,6 +28,10 @@
> selectUnselectMatchingOptions(updownselectObj, null, "unselect", false, "key");
> }
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
> <script>
> function validateForm_myAction() {
> form = document.getElementById("myAction");
> @@ -36,3 +40,4 @@
> var errors = false;
> return !errors; }
> </script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt Sat Apr 15 08:45:00 2006
> @@ -28,3 +28,6 @@
> }
> </script>
>
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: svn commit: r394308 - in /incubator/webwork2/action/src/test:
java/org/apache/struts/action2/views/jsp/ui/ resources/org/apache/struts/action2/views/jsp/ui/
Posted by Don Brown <mr...@twdata.org>.
Thanks Toby for fixing these tests. I keep forgetting WebWork, even its
tags, are so well unit tested :)
Don
tmjee@apache.org wrote:
> Author: tmjee
> Date: Sat Apr 15 08:45:00 2006
> New Revision: 394308
>
> URL: http://svn.apache.org/viewcvs?rev=394308&view=rev
> Log:
> - fix failing test case
>
>
> Modified:
> incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
> incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
>
> Modified: incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java (original)
> +++ incubator/webwork2/action/src/test/java/org/apache/struts/action2/views/jsp/ui/FormTagTest.java Sat Apr 15 08:45:00 2006
> @@ -23,7 +23,9 @@
> import org.apache.struts.action2.config.Configuration;
> import org.apache.struts.action2.views.jsp.AbstractUITagTest;
> import org.apache.struts.action2.views.jsp.ActionTag;
> +
> import com.opensymphony.xwork.ActionContext;
> +import com.opensymphony.xwork.ObjectFactory;
> import com.opensymphony.xwork.config.ConfigurationManager;
>
>
> @@ -31,13 +33,15 @@
> * FormTagTest
> *
> * @author Jason Carreira
> - * Created Apr 3, 2003 10:28:58 AM
> + * @author tm_jee
> *
> * @version $Date$ $Id$
> */
> public class FormTagTest extends AbstractUITagTest {
>
> public void testForm() throws Exception {
> + ObjectFactory.setObjectFactory(new MyObjectFactory());
> +
> request.setupGetServletPath("/testAction");
>
> TestAction testAction = (TestAction) action;
> @@ -363,4 +367,8 @@
> ConfigurationManager.addConfigurationProvider(new TestConfigurationProvider());
> ActionContext.getContext().setValueStack(stack);
> }
> +
> + static class MyObjectFactory extends ObjectFactory {
> +
> + }
> }
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-1.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,6 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-2.txt Sat Apr 15 08:45:00 2006
> @@ -28,6 +28,10 @@
> selectUnselectMatchingOptions(updownselectObj, null, "unselect", false, "key");
> }
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
> <script>
> function validateForm_myAction() {
> form = document.getElementById("myAction");
> @@ -36,3 +40,4 @@
> var errors = false;
> return !errors; }
> </script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-3.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-4.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-5.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-6.txt Sat Apr 15 08:45:00 2006
> @@ -28,3 +28,6 @@
> }
> </script>
>
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-7.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
> Modified: incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt
> URL: http://svn.apache.org/viewcvs/incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt?rev=394308&r1=394307&r2=394308&view=diff
> ==============================================================================
> --- incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt (original)
> +++ incubator/webwork2/action/src/test/resources/org/apache/struts/action2/views/jsp/ui/Formtag-8.txt Sat Apr 15 08:45:00 2006
> @@ -6,3 +6,7 @@
> <script>
> function customOnsubmit() {}
> </script>
> +
> +<!-- javascript that is needed for tooltips -->
> +<script language="JavaScript" type="text/javascript">dojo.require("dojo.widget.html.Tooltip");dojo.require("dojo.fx.html");</script>
> +
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org