You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2022/08/01 16:24:41 UTC
[GitHub] [httpcomponents-core] HeartPattern opened a new pull request, #358: Fix unrepeatable producers to return isRepeatable false
HeartPattern opened a new pull request, #358:
URL: https://github.com/apache/httpcomponents-core/pull/358
These classes are returning true for `isRepeatable` but actually not repeatable.
They does not reset bytebuf pointer after producing, and some of them clear bytebuf on `releaseResources`, which make producer produce empty data on repeat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #358: Fix unrepeatable producers to return isRepeatable false
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #358:
URL: https://github.com/apache/httpcomponents-core/pull/358#issuecomment-1201490628
@HeartPattern Would not fixing the resource management logic in those producers be a better approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c closed pull request #358: Fix unrepeatable producers to return isRepeatable false
Posted by GitBox <gi...@apache.org>.
ok2c closed pull request #358: Fix unrepeatable producers to return isRepeatable false
URL: https://github.com/apache/httpcomponents-core/pull/358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #358: Fix unrepeatable producers to return isRepeatable false
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #358:
URL: https://github.com/apache/httpcomponents-core/pull/358#issuecomment-1205599524
Your assertion about `BasicAsyncEntityProducer` and `StringAsyncEntityProducer` producers being unrepeatable is wrong. They are. There are even test cases that verify that particular functionality.
As far as `Buffer#clear` is concerned see Buffer Javadocs:
```
This method does not actually erase the data in the buffer, but it is named as if it did because it will most often be used in situations in which that might as well be the case.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org