You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/03 03:17:16 UTC

[GitHub] [flink] CrazyTomatoOo opened a new pull request #10753: [FLINK-15081][docs]Translation work has been finished.

CrazyTomatoOo opened a new pull request #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753
 
 
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Just translate the doc flink/docs/dev/table/common.zh.md
   
   
   ## Brief change log
   
   Retranslation according to specifications. 
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers:  no 
     - The runtime per-record code paths (performance sensitive): no 
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:  no 
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
     - If yes, how is the feature documented? not applicable 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese

Posted by GitBox <gi...@apache.org>.
CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese
URL: https://github.com/apache/flink/pull/10753#issuecomment-570497639
 
 
   Do I need to resubmit PR after modification?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] CrazyTomatoOo closed pull request #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese

Posted by GitBox <gi...@apache.org>.
CrazyTomatoOo closed pull request #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese
URL: https://github.com/apache/flink/pull/10753
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753#issuecomment-570446916
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 53c8234b8768305885c959cf1d40b376874d2038 (Fri Jan 03 03:19:19 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese

Posted by GitBox <gi...@apache.org>.
CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese
URL: https://github.com/apache/flink/pull/10753#issuecomment-570491681
 
 
   OK, thanks for reminding me! I will check it now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.

Posted by GitBox <gi...@apache.org>.
CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753#issuecomment-570469010
 
 
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese
URL: https://github.com/apache/flink/pull/10753#issuecomment-570499750
 
 
   > Do I need to resubmit PR after modification?
   
   No, you don't need. Please just push your changes to your branch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10753: [FLINK-15081][docs]Translation work has been finished.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753#issuecomment-570448567
 
 
   <!--
   Meta data
   Hash:53c8234b8768305885c959cf1d40b376874d2038 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4054 TriggerType:PUSH TriggerID:53c8234b8768305885c959cf1d40b376874d2038
   Hash:53c8234b8768305885c959cf1d40b376874d2038 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142953557 TriggerType:PUSH TriggerID:53c8234b8768305885c959cf1d40b376874d2038
   -->
   ## CI report:
   
   * 53c8234b8768305885c959cf1d40b376874d2038 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142953557) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4054) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10753: [FLINK-15081][docs]Translation work has been finished.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753#issuecomment-570448567
 
 
   <!--
   Meta data
   Hash:53c8234b8768305885c959cf1d40b376874d2038 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4054 TriggerType:PUSH TriggerID:53c8234b8768305885c959cf1d40b376874d2038
   Hash:53c8234b8768305885c959cf1d40b376874d2038 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142953557 TriggerType:PUSH TriggerID:53c8234b8768305885c959cf1d40b376874d2038
   -->
   ## CI report:
   
   * 53c8234b8768305885c959cf1d40b376874d2038 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142953557) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4054) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese

Posted by GitBox <gi...@apache.org>.
CrazyTomatoOo commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese
URL: https://github.com/apache/flink/pull/10753#issuecomment-570502942
 
 
   > > Do I need to resubmit PR after modification?
   > 
   > No, you don't need. Please just push your changes to your branch.
   
   Sorry, I think I made a mistake. The document I translated is version 1.9.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #10753: [FLINK-15081][docs-zh] Translate "Concepts & Common API" page of Table API into Chinese
URL: https://github.com/apache/flink/pull/10753#issuecomment-570483651
 
 
   Hi @CrazyTomatoOo , thanks for the contribution. Usually, a PR title is the same to JIRA title with additional issue ID and component name. You can refer to the guideline before contribution: https://flink.apache.org/zh/contributing/contribute-documentation.html.
   
   Btw, I noticed that the code part is inconsistent before and after translation, please check that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753#issuecomment-570448567
 
 
   <!--
   Meta data
   Hash:53c8234b8768305885c959cf1d40b376874d2038 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:53c8234b8768305885c959cf1d40b376874d2038
   -->
   ## CI report:
   
   * 53c8234b8768305885c959cf1d40b376874d2038 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.

Posted by GitBox <gi...@apache.org>.
klion26 commented on issue #10753: [FLINK-15081][docs]Translation work has been finished.
URL: https://github.com/apache/flink/pull/10753#issuecomment-570458550
 
 
   @CrazyTomatoOo thanks for your contribution, could you please update the pr title to respect the issue title? so that others can know what this pr do from the title.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services