You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/13 14:15:35 UTC
[GitHub] [dubbo-go] CherishCai opened a new pull request, #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
CherishCai opened a new pull request, #1888:
URL: https://github.com/apache/dubbo-go/pull/1888
Rename procider_filter_test.go -> provider_filter_test.go
https://github.com/apache/dubbo-go/blob/4a62aa28e4f942db4c02c0725ad2a77cbbbd9db7/filter/graceful_shutdown/procider_filter_test.go#L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #1888:
URL: https://github.com/apache/dubbo-go/pull/1888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on pull request #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
Posted by GitBox <gi...@apache.org>.
justxuewei commented on PR #1888:
URL: https://github.com/apache/dubbo-go/pull/1888#issuecomment-1126654934
> How can I fix this CI failure? I saw other PRs with the same problem.
Hi Cherish, thanks for your contribution. To address this problem, you should do following things:
1. Rebase your repo with the latest 3.0 branch.
2. Download & install a format tool, named "imports-formatter", from [dubbogo/tools](https://github.com/dubbogo/tools).
3. Run `imports-formatter` on the directory of dubbo-go project.
4. Push your codes again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] CherishCai commented on pull request #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
Posted by GitBox <gi...@apache.org>.
CherishCai commented on PR #1888:
URL: https://github.com/apache/dubbo-go/pull/1888#issuecomment-1126140598
How can I fix this CI failure? I saw other PRs with the same problem.
<img width="1044" alt="image" src="https://user-images.githubusercontent.com/16837364/168309064-6dffc080-e11a-4b51-9b05-9e37bf9a8f57.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1888:
URL: https://github.com/apache/dubbo-go/pull/1888#issuecomment-1126838806
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1888?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1888](https://codecov.io/gh/apache/dubbo-go/pull/1888?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dba1d8e) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/dba1d8e51cf37baebfebdc44561873d2768bbbfc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dba1d8e) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head dba1d8e differs from pull request most recent head 91466b9. Consider uploading reports for the commit 91466b9 to get more accurate results
```diff
@@ Coverage Diff @@
## 3.0 #1888 +/- ##
=======================================
Coverage 44.85% 44.85%
=======================================
Files 284 284
Lines 16947 16947
=======================================
Hits 7602 7602
Misses 8539 8539
Partials 806 806
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1888?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1888?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dba1d8e...91466b9](https://codecov.io/gh/apache/dubbo-go/pull/1888?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] CherishCai commented on pull request #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
Posted by GitBox <gi...@apache.org>.
CherishCai commented on PR #1888:
URL: https://github.com/apache/dubbo-go/pull/1888#issuecomment-1126709261
It looks like the test case is not very stable.
<img width="1026" alt="image" src="https://user-images.githubusercontent.com/16837364/168426046-30c8cac0-1ed7-4979-a527-2dd7354e6a27.png">
<img width="1384" alt="image" src="https://user-images.githubusercontent.com/16837364/168426065-660fc314-7bb5-48dc-b0eb-ecd236d06171.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] CherishCai commented on pull request #1888: Fix: typo, rename procider_filter_test.go to provider_filter_test.go (#1887)
Posted by GitBox <gi...@apache.org>.
CherishCai commented on PR #1888:
URL: https://github.com/apache/dubbo-go/pull/1888#issuecomment-1126699664
> > How can I fix this CI failure? I saw other PRs with the same problem.
>
> Hi Cherish, thanks for your contribution. To address this problem, you should do following things:
>
> 1. Rebase your repo with the latest 3.0 branch.
> 2. Download & install a format tool, named "imports-formatter", from [dubbogo/tools](https://github.com/dubbogo/tools).
> 3. Run `imports-formatter` on the directory of dubbo-go project.
> 4. Push your code again.
>
> If you have any questions, please feel free to reply this comment directly :)
Thanks, I haven't developed a project with Golang, thanks for your guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org