You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/08/20 20:22:39 UTC
Review Request 13686: SQOOP-1120 Sqoop2: Support for PostgreSQL database for
hosting the metadata repository
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13686/
-----------------------------------------------------------
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-1120
https://issues.apache.org/jira/browse/SQOOP-1120
Repository: sqoop-sqoop2
Description
-------
commit 1eef61e815dfaf49b031fdf6ade55d1bcc523b01
Author: Mengwei Ding <me...@cloudera.com>
Date: Tue Jul 9 13:41:58 2013 -0700
SQOOP-1120 Sqoop2: Support for PostgreSQL database for hosting the metadata repository
:100755 100755 bb01016... 56f114c... M dist/src/main/server/conf/sqoop.properties
:100644 100644 e3345c4... 67dc3fa... M repository/pom.xml
:000000 100644 0000000... 4ba807a... A repository/repository-postgres/pom.xml
:000000 100644 0000000... 20ea7a5... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java
:000000 100644 0000000... a01aa73... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java
:000000 100644 0000000... a05aa5f... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java
:000000 100644 0000000... 833bdb6... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java
:000000 100644 0000000... fdce884... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java
:000000 100644 0000000... 12b4c2b... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java
:000000 100644 0000000... 8ca5b69... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java
:000000 100644 0000000... 963bb42... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java
:000000 100644 0000000... 2e3c49b... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java
:000000 100644 0000000... 16ad023... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java
:000000 100644 0000000... c59c83a... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java
:000000 100644 0000000... 03cf6b2... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java
:000000 100644 0000000... 91e7551... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java
:000000 100644 0000000... 44ffced... A repository/repository-postgres/src/test/resources/log4j.properties
:100644 100644 a07ecf4... df8cc2f... M server/pom.xml
Diffs
-----
dist/src/main/server/conf/sqoop.properties bb01016
repository/pom.xml e3345c4
repository/repository-postgres/pom.xml PRE-CREATION
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java PRE-CREATION
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java PRE-CREATION
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java PRE-CREATION
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java PRE-CREATION
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java PRE-CREATION
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java PRE-CREATION
repository/repository-postgres/src/test/resources/log4j.properties PRE-CREATION
server/pom.xml a07ecf4
Diff: https://reviews.apache.org/r/13686/diff/
Testing
-------
Pass the integration test for postgreSQL on my local machine. Here in the code, I exclude the postgres integration test.
Thanks,
Mengwei Ding
Re: Review Request 13686: SQOOP-1120 Sqoop2: Support for PostgreSQL database
for hosting the metadata repository
Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13686/#review25353
-----------------------------------------------------------
dist/src/main/server/conf/sqoop.properties
<https://reviews.apache.org/r/13686/#comment49734>
I will comment the postgres one later. Please ignore this one first.
- Mengwei Ding
On Aug. 20, 2013, 6:22 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13686/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2013, 6:22 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1120
> https://issues.apache.org/jira/browse/SQOOP-1120
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 1eef61e815dfaf49b031fdf6ade55d1bcc523b01
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Tue Jul 9 13:41:58 2013 -0700
>
> SQOOP-1120 Sqoop2: Support for PostgreSQL database for hosting the metadata repository
>
> :100755 100755 bb01016... 56f114c... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 e3345c4... 67dc3fa... M repository/pom.xml
> :000000 100644 0000000... 4ba807a... A repository/repository-postgres/pom.xml
> :000000 100644 0000000... 20ea7a5... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java
> :000000 100644 0000000... a01aa73... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java
> :000000 100644 0000000... a05aa5f... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java
> :000000 100644 0000000... 833bdb6... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java
> :000000 100644 0000000... fdce884... A repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java
> :000000 100644 0000000... 12b4c2b... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java
> :000000 100644 0000000... 8ca5b69... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java
> :000000 100644 0000000... 963bb42... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java
> :000000 100644 0000000... 2e3c49b... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java
> :000000 100644 0000000... 16ad023... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java
> :000000 100644 0000000... c59c83a... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java
> :000000 100644 0000000... 03cf6b2... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java
> :000000 100644 0000000... 91e7551... A repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java
> :000000 100644 0000000... 44ffced... A repository/repository-postgres/src/test/resources/log4j.properties
> :100644 100644 a07ecf4... df8cc2f... M server/pom.xml
>
>
> Diffs
> -----
>
> dist/src/main/server/conf/sqoop.properties bb01016
> repository/pom.xml e3345c4
> repository/repository-postgres/pom.xml PRE-CREATION
> repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java PRE-CREATION
> repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java PRE-CREATION
> repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java PRE-CREATION
> repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java PRE-CREATION
> repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java PRE-CREATION
> repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java PRE-CREATION
> repository/repository-postgres/src/test/resources/log4j.properties PRE-CREATION
> server/pom.xml a07ecf4
>
> Diff: https://reviews.apache.org/r/13686/diff/
>
>
> Testing
> -------
>
> Pass the integration test for postgreSQL on my local machine. Here in the code, I exclude the postgres integration test.
>
>
> Thanks,
>
> Mengwei Ding
>
>