[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #6576: [AIRFLOW-5922] Add option to specify the mysql client library used in MySqlHook
URL: https://github.com/apache/airflow/pull/6576#discussion_r362732374
 
 

 ##########
 File path: airflow/hooks/mysql_hook.py
 ##########
 @@ -91,8 +89,7 @@ def get_conn(self):
 
         if conn.extra_dejson.get('charset', False):
             conn_config["charset"] = conn.extra_dejson["charset"]
-            if (conn_config["charset"]).lower() == 'utf8' or\
-                    (conn_config["charset"]).lower() == 'utf-8':
+            if (conn_config["charset"]).lower() == 'utf8' or (conn_config["charset"]).lower() == 'utf-8':
 
 Review comment:
   ```suggestion
               if conn_config["charset"].lower() in ('utf8', 'utf-8'):
   ```
   Can we simplify it like that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services