You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by iture123 <gi...@git.apache.org> on 2019/01/01 07:40:50 UTC
[GitHub] carbondata pull request #3043: Carbondata 3213
GitHub user iture123 opened a pull request:
https://github.com/apache/carbondata/pull/3043
Carbondata 3213
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [N] Any interfaces changed?
- [N] Any backward compatibility impacted?
- [N] Document update required?
- [N] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ N] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
for 3 md files and 2 java files add license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iture123/carbondata CARBONDATA-3213
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3043.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3043
----
commit 136e2316e248011b066aec6502484669afc23086
Author: iture <10...@...>
Date: 2019-01-01T07:08:41Z
[CARBONDATA-3213]add license for java
commit d25818f6a91aeb56d5d6e0778e750146bc299198
Author: iture <10...@...>
Date: 2019-01-01T07:16:12Z
Merge branch 'master' of https://github.com/apache/carbondata into CARBONDATA-3213
commit a629a7414b17405f89448b109f7f2d22c2c33ba5
Author: iture <10...@...>
Date: 2019-01-01T07:31:15Z
[CARBONDATA-3213]add license for md
----
---
[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3043
@iture123 Thank you for working on it.
---
[GitHub] carbondata issue #3043: Carbondata 3213
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3043
@iture123 Please optimize the title, like: [CARBONDATA-3182] Fixed SDV Testcase failures
---
[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3043
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2306/
---
[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3043
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10355/
---
[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/3043
LGTM
---
[GitHub] carbondata issue #3043: Carbondata 3213
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3043
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2101/
---
[GitHub] carbondata issue #3043: [Carbondata 3213] Fix no license files
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3043
LGTM
---
[GitHub] carbondata pull request #3043: [Carbondata 3213] Fix no license files
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3043
---
[GitHub] carbondata issue #3043: Carbondata 3213
Posted by iture123 <gi...@git.apache.org>.
Github user iture123 commented on the issue:
https://github.com/apache/carbondata/pull/3043
find /data/carbondata -name "*.java" | xargs grep -Lr "Licensed to the Apache Software Foundation" | xargs sed -e '1 r license.java' -e '1N' -i
By this command,I add the license.
---
[GitHub] carbondata issue #3043: Carbondata 3213
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3043
add to whitelist
---
[GitHub] carbondata issue #3043: Carbondata 3213
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3043
Can one of the admins verify this patch?
---