You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2008/01/22 12:32:34 UTC
[jira] Created: (JCR-1336) Bug in duplicate mapping check
Bug in duplicate mapping check
------------------------------
Key: JCR-1336
URL: https://issues.apache.org/jira/browse/JCR-1336
Project: Jackrabbit
Issue Type: Bug
Components: jackrabbit-ocm
Affects Versions: 1.4
Reporter: Carsten Ziegeler
There is a bug in the MappingDescriptor for checking if a mapping for a node type is already available. The following patch solves this problem:
Index: /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java
===================================================================
--- /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (revision 614136)
+++ /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (working copy)
@@ -75,7 +75,7 @@
if (null != classDescriptor.getJcrType() && ! "".equals(classDescriptor.getJcrType()) &&
! ManagerConstant.NT_UNSTRUCTURED.equals(classDescriptor.getJcrType()))
{
- if ((classDescriptorsByNodeType.get(classDescriptor.getClassName()) != null) &&
+ if ((classDescriptorsByNodeType.get(classDescriptor.getJcrType()) != null) &&
classDescriptor.usesNodeTypePerConcreteClassStrategy() )
{
log.warn("Duplicate classdescriptor for node type : " + classDescriptor.getJcrType());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1336) Bug in duplicate mapping check
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Lombart resolved JCR-1336.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5
Patch applied. Thanks
Sorry for the delay. Can you check if it is ok for you ?
> Bug in duplicate mapping check
> ------------------------------
>
> Key: JCR-1336
> URL: https://issues.apache.org/jira/browse/JCR-1336
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-ocm
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Christophe Lombart
> Fix For: 1.5
>
>
> There is a bug in the MappingDescriptor for checking if a mapping for a node type is already available. The following patch solves this problem:
> Index: /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java
> ===================================================================
> --- /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (revision 614136)
> +++ /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (working copy)
> @@ -75,7 +75,7 @@
> if (null != classDescriptor.getJcrType() && ! "".equals(classDescriptor.getJcrType()) &&
> ! ManagerConstant.NT_UNSTRUCTURED.equals(classDescriptor.getJcrType()))
> {
> - if ((classDescriptorsByNodeType.get(classDescriptor.getClassName()) != null) &&
> + if ((classDescriptorsByNodeType.get(classDescriptor.getJcrType()) != null) &&
> classDescriptor.usesNodeTypePerConcreteClassStrategy() )
> {
> log.warn("Duplicate classdescriptor for node type : " + classDescriptor.getJcrType());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JCR-1336) Bug in duplicate mapping check
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed JCR-1336.
---------------------------------
Looks good to me. Thanks!
> Bug in duplicate mapping check
> ------------------------------
>
> Key: JCR-1336
> URL: https://issues.apache.org/jira/browse/JCR-1336
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-ocm
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Christophe Lombart
> Fix For: 1.5
>
>
> There is a bug in the MappingDescriptor for checking if a mapping for a node type is already available. The following patch solves this problem:
> Index: /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java
> ===================================================================
> --- /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (revision 614136)
> +++ /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (working copy)
> @@ -75,7 +75,7 @@
> if (null != classDescriptor.getJcrType() && ! "".equals(classDescriptor.getJcrType()) &&
> ! ManagerConstant.NT_UNSTRUCTURED.equals(classDescriptor.getJcrType()))
> {
> - if ((classDescriptorsByNodeType.get(classDescriptor.getClassName()) != null) &&
> + if ((classDescriptorsByNodeType.get(classDescriptor.getJcrType()) != null) &&
> classDescriptor.usesNodeTypePerConcreteClassStrategy() )
> {
> log.warn("Duplicate classdescriptor for node type : " + classDescriptor.getJcrType());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1336) Bug in duplicate mapping check
Posted by "Christophe Lombart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Lombart reassigned JCR-1336:
---------------------------------------
Assignee: Christophe Lombart
> Bug in duplicate mapping check
> ------------------------------
>
> Key: JCR-1336
> URL: https://issues.apache.org/jira/browse/JCR-1336
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-ocm
> Affects Versions: 1.4
> Reporter: Carsten Ziegeler
> Assignee: Christophe Lombart
>
> There is a bug in the MappingDescriptor for checking if a mapping for a node type is already available. The following patch solves this problem:
> Index: /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java
> ===================================================================
> --- /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (revision 614136)
> +++ /Users/cziegeler/Developer/workspaces/default/jackrabbit/jackrabbit-ocm/src/main/java/org/apache/jackrabbit/ocm/mapper/model/MappingDescriptor.java (working copy)
> @@ -75,7 +75,7 @@
> if (null != classDescriptor.getJcrType() && ! "".equals(classDescriptor.getJcrType()) &&
> ! ManagerConstant.NT_UNSTRUCTURED.equals(classDescriptor.getJcrType()))
> {
> - if ((classDescriptorsByNodeType.get(classDescriptor.getClassName()) != null) &&
> + if ((classDescriptorsByNodeType.get(classDescriptor.getJcrType()) != null) &&
> classDescriptor.usesNodeTypePerConcreteClassStrategy() )
> {
> log.warn("Duplicate classdescriptor for node type : " + classDescriptor.getJcrType());
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.