[jira] [Commented] (SOLR-10024) If you use ExternalPaths#determineSourceHome with a custom tests.workDir, tests may not find the path.

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833924#comment-15833924 ] 

Mark Miller commented on SOLR-10024:
------------------------------------

This tries to use the current working directory to find the src, but when using ant that can be moved around (one use is for parallel tests). In this case, tests.workDir may not fall under the src tree, and null will be returned.

This patch improves on this by passing a new system property with the ant current working directory and determineSourceHome will first look for that system property, else do what is has been doing.

> If you use ExternalPaths#determineSourceHome with a custom tests.workDir, tests may not find the path.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10024
>                 URL: https://issues.apache.org/jira/browse/SOLR-10024
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>
> As the comments say, this is already kind of an ugly hack, and if you change the test working dir it won't be able to find the source tree and a slew of tests won't work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org