[GitHub] [incubator-pegasus] levy5307 commented on a diff in pull request #1237: feat(new_metrics): support filters for selected metric fields in response

[GitBox <gi...@apache.org>]

levy5307 commented on code in PR #1237:
URL: https://github.com/apache/incubator-pegasus/pull/1237#discussion_r1024698497


##########
src/utils/metrics.cpp:
##########
@@ -267,4 +258,13 @@ void percentile_timer::on_timer(const boost::system::error_code &ec)
 #undef TRY_PROCESS_TIMER_CLOSING
 }
 
+std::set<kth_percentile_type> get_all_kth_percentile_types()
+{
+    std::set<kth_percentile_type> all_types;
+    for (size_t i = 0; i < static_cast<size_t>(kth_percentile_type::COUNT); ++i) {

Review Comment:
    ```   for (size_t i = static_cast<size_t>(kth_percentile_type::COUNT - 1); i >= 0; --i) {```
   reduce some cast operation
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org