You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/11/13 13:36:07 UTC

Review Request 40289: DataNode Data Directories Which Contain Meta Information Tags Trigger Alerts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40289/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.


Bugs: AMBARI-13880
    https://issues.apache.org/jira/browse/AMBARI-13880


Repository: ambari


Description
-------

HDFS allows the ability to tag DataNode data directories with meta information:
https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html
Which results in paths that look like:
[DISK]/hadoop/hdfs/data,[SSD]/hadoop/hdfs/ssd
Many of our scripts assume that directories specified in hdfs-site/dfs.datanode.data.dir are actual paths and perform operations like os.path.isdir which will fail with meta data.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py f95daac 

Diff: https://reviews.apache.org/r/40289/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 40289: DataNode Data Directories Which Contain Meta Information Tags Trigger Alerts

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.

> On Лис. 13, 2015, 6:37 після полудня, Alejandro Fernandez wrote:
> > We also need a similar check in dfs_datanode_helper.py

ok, will create jira for this.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40289/#review106475
-----------------------------------------------------------


On Лис. 13, 2015, 12:36 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40289/
> -----------------------------------------------------------
> 
> (Updated Лис. 13, 2015, 12:36 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13880
>     https://issues.apache.org/jira/browse/AMBARI-13880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS allows the ability to tag DataNode data directories with meta information:
> https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html
> Which results in paths that look like:
> [DISK]/hadoop/hdfs/data,[SSD]/hadoop/hdfs/ssd
> Many of our scripts assume that directories specified in hdfs-site/dfs.datanode.data.dir are actual paths and perform operations like os.path.isdir which will fail with meta data.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py f95daac 
> 
> Diff: https://reviews.apache.org/r/40289/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 40289: DataNode Data Directories Which Contain Meta Information Tags Trigger Alerts

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40289/#review106475
-----------------------------------------------------------


We also need a similar check in dfs_datanode_helper.py

- Alejandro Fernandez


On Nov. 13, 2015, 12:36 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40289/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 12:36 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13880
>     https://issues.apache.org/jira/browse/AMBARI-13880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS allows the ability to tag DataNode data directories with meta information:
> https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html
> Which results in paths that look like:
> [DISK]/hadoop/hdfs/data,[SSD]/hadoop/hdfs/ssd
> Many of our scripts assume that directories specified in hdfs-site/dfs.datanode.data.dir are actual paths and perform operations like os.path.isdir which will fail with meta data.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py f95daac 
> 
> Diff: https://reviews.apache.org/r/40289/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 40289: DataNode Data Directories Which Contain Meta Information Tags Trigger Alerts

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40289/#review106408
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Nov. 13, 2015, 12:36 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40289/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 12:36 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13880
>     https://issues.apache.org/jira/browse/AMBARI-13880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS allows the ability to tag DataNode data directories with meta information:
> https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html
> Which results in paths that look like:
> [DISK]/hadoop/hdfs/data,[SSD]/hadoop/hdfs/ssd
> Many of our scripts assume that directories specified in hdfs-site/dfs.datanode.data.dir are actual paths and perform operations like os.path.isdir which will fail with meta data.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py f95daac 
> 
> Diff: https://reviews.apache.org/r/40289/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 40289: DataNode Data Directories Which Contain Meta Information Tags Trigger Alerts

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40289/#review106414
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 13, 2015, 2:36 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40289/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 2:36 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13880
>     https://issues.apache.org/jira/browse/AMBARI-13880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS allows the ability to tag DataNode data directories with meta information:
> https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html
> Which results in paths that look like:
> [DISK]/hadoop/hdfs/data,[SSD]/hadoop/hdfs/ssd
> Many of our scripts assume that directories specified in hdfs-site/dfs.datanode.data.dir are actual paths and perform operations like os.path.isdir which will fail with meta data.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py f95daac 
> 
> Diff: https://reviews.apache.org/r/40289/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 40289: DataNode Data Directories Which Contain Meta Information Tags Trigger Alerts

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40289/#review106412
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Nov. 13, 2015, 7:36 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40289/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 7:36 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-13880
>     https://issues.apache.org/jira/browse/AMBARI-13880
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HDFS allows the ability to tag DataNode data directories with meta information:
> https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html
> Which results in paths that look like:
> [DISK]/hadoop/hdfs/data,[SSD]/hadoop/hdfs/ssd
> Many of our scripts assume that directories specified in hdfs-site/dfs.datanode.data.dir are actual paths and perform operations like os.path.isdir which will fail with meta data.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py f95daac 
> 
> Diff: https://reviews.apache.org/r/40289/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>