You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2012/06/12 01:40:13 UTC
[Bug 53400] New: [PATCH] new ODT render
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Priority: P2
Bug ID: 53400
Assignee: fop-dev@xmlgraphics.apache.org
Summary: [PATCH] new ODT render
Severity: enhancement
Classification: Unclassified
OS: Linux
Reporter: marek.jagielski@gmail.com
Hardware: PC
Status: NEW
Version: 1.1dev
Component: general
Product: Fop
Created attachment 28913
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28913&action=edit
PATCH for ODT render
Hi,
I integrated the new render into my local checkout of FOP's trunk.
>From the list gave by Glenn:
(+) I provided some tests that basic implemented functionalties.
(+/-) org.apache.fop.cli.CommandLineOptions were extended to execute odt
rendering incuding info. I didn't need to change fop.sh to make it run. I don't
know if there is something to do (as well in js)
To try, please do:
fop foo.fo -odt foo.odt
(+) I added the documentation in:
* src/documentation/content/xdocs/trunk/output.xml
* src/documentation/content/xdocs/trunk/running.xml
(+) run 'ant checkstyle', and fix all warnings found in
build/report_checkstyle.htm
(+/-) run 'ant findbugs', and fix all warnings found in
build/report_findbugs.html (due to odt render) Still left one:
rg.apache.fop.render.odf.ODTFOEventHandlerMaker.getSupportedMimeTypes() may
expose internal representation by returning ODTFOEventHandlerMaker.MIMES but I
don't undestand its porpuse.
(+) run 'ant javadocs', and fix any warnings that I have introduced
(+) I have sent the ICLA to secretary@apache.org
(+) I created the patch.
Regards,
Marek
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #7 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #3)
> For the simple-odf I am not glad. I started to develop from this, as I was
> beginner in fop and odt. However, during development I was constantly
> removing dependencies of its api as I found that odfdom is sufficient.
> Simply-odf is still used for Paragraph abstraction but I hope to refactor
> this to have everything on xml tags abstraction. So simply-odf is for me a
> temporary dependence.
I will wait until you finish eliminating the simple-odf dependency before
further considering this patch. Please submit a new patch when you have done
that.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #4 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 28942
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28942&action=edit
Image for tests
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #19 from Marek Jagielski <ma...@gmail.com> ---
The wiki page available at:
http://wiki.apache.org/xmlgraphics-fop/ODT_render
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #1 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #0)
> Created attachment 28913 [details]
> PATCH for ODT render
I'm not sure which tool you used to create the patch file, but I am having
difficulty applying it due to the presence of binary data (*.odt files) in the
diff. Could you separate out any binary files to be added into a separate TGZ
file separately attached?
Also, I see that you patch adds a number of ODF libraries to the runtime libs
required to run FOP. Although these are coming from an ASF incubator project
[1], a vote will have to be taken on creating this new dependency in FOP. You
should also supply the required versions of the JAR files containing these new
libraries in the TGZ attachment described above.
[1] http://incubator.apache.org/projects/odftoolkit.html
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29448|0 |1
is obsolete| |
--- Comment #22 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29451
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29451&action=edit
PATCH for ODT render
Bord and padding
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #9 from Marek Jagielski <ma...@gmail.com> ---
I removed all references to simply-odf.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #17 from Marek Jagielski <ma...@gmail.com> ---
Good source of samples :
http://www.xmlmind.com/foconverter/samples.html
Marek
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #6 from Marek Jagielski <ma...@gmail.com> ---
ODT liraries please find here:
https://docs.google.com/open?id=0Bxy7yhoOWhbidXdPeGRiMGxaUUk
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29044|0 |1
is obsolete| |
--- Comment #13 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29338
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29338&action=edit
PATCH for ODT render
Huge refactoring of "Styles". The reference implementation is BlockTag with
"fonts" properties. The other code should follow this pattern.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29346|0 |1
is obsolete| |
--- Comment #20 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29413
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29413&action=edit
Documentation : Class Diagram
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29338|0 |1
is obsolete| |
--- Comment #15 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29347
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29347&action=edit
PATCH for ODT render
A little bit of comments and cleaning as well as implementation of
text-decoration, baseline-shift.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #12 from Marek Jagielski <ma...@gmail.com> ---
Hi,
After looking into spec, I realized that I have implemented Font Properties
for fo:basic-link (by the fop api) that isn't the part of specification.
Why we can retrvie these informations from object model?
Marek
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #11 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29279
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29279&action=edit
Documentation : Implementation State of patch
According to spec http://www.w3.org/TR/xsl11/ I summarize the implementation
state of attached patch.
Gray : attribute not aplicable;
Gray Light : conffusion in spec, probably applicable
X : attribute applicable;
Green : functionality implemented;
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29451|0 |1
is obsolete| |
--- Comment #23 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29452
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29452&action=edit
PATCH for ODT render
Refactoring, TagFactory Enhancement, PageSequence correction (Exception).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #3 from Marek Jagielski <ma...@gmail.com> ---
I used eclipse envirement with its plugins.The odt files aren't realy necesairy
as they are only the outputs of test fo-files. I am putting now diff files
without odt-files included made with command line svn.
For odt generation I have used :
+ odfdom-java-0.8.7.jar
+ simply-odf-0.6.6.jar
Odfdom, it was what I have found the simplest and that is licence compatible to
fop. Odfdom is really low level api but it was advantage for me that odt render
is a transformation of one xml (fo) to another (.odt).
For the simple-odf I am not glad. I started to develop from this, as I was
beginner in fop and odt. However, during development I was constantly removing
dependencies of its api as I found that odfdom is sufficient. Simply-odf is
still used for Paragraph abstraction but I hope to refactor this to have
everything on xml tags abstraction. So simply-odf is for me a temporary
dependence.
To this comment I attache :
+ odt_render_without_bin.path : contains only *.java, *.fo
+ img.jpg : file to test should be in
./fop/test/odf/odt/fo_external_grphic/img.jpg (but it is find by google, so I
don't know about the rights to use it, this file can be change by any)
+ odt_outputs.tgz : contains *.odt (names are appropriate to *.fo input files)
+ odt_libraries.tgz : contains odfdom-java-0.8.7.jar, simply-odf-0.6.6.jar
Marek(In reply to comment #1)
> (In reply to comment #0)
> > Created attachment 28913 [details]
> > PATCH for ODT render
>
> I'm not sure which tool you used to create the patch file, but I am having
> difficulty applying it due to the presence of binary data (*.odt files) in
> the diff. Could you separate out any binary files to be added into a
> separate TGZ file separately attached?
>
> Also, I see that you patch adds a number of ODF libraries to the runtime
> libs required to run FOP. Although these are coming from an ASF incubator
> project [1], a vote will have to be taken on creating this new dependency in
> FOP. You should also supply the required versions of the JAR files
> containing these new libraries in the TGZ attachment described above.
>
> [1] http://incubator.apache.org/projects/odftoolkit.html
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29279|0 |1
is obsolete| |
--- Comment #16 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29348
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29348&action=edit
Documentation : Implementation State of patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #14 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29346
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29346&action=edit
Documentation : Class Diagramm
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28941|0 |1
is obsolete| |
--- Comment #8 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 28972
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28972&action=edit
PATCH for ODT render
I removed all references to simply-odf.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28913|0 |1
is obsolete| |
--- Comment #2 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 28941
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28941&action=edit
PATCH for ODT render
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #5 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 28943
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28943&action=edit
Output of the tests - *.odt
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28972|0 |1
is obsolete| |
--- Comment #10 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29044
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29044&action=edit
PATCH for ODT render
Some corrections and synchronization with trunk.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
--- Comment #18 from Glenn Adams <ga...@apache.org> ---
(In reply to comment #17)
> Good source of samples :
>
> http://www.xmlmind.com/foconverter/samples.html
While it is useful to include documentation in a bug report, it doesn't help
the community so much. I would suggest you create a wiki page at [1].
[1] http://wiki.apache.org/xmlgraphics-fop/DeveloperPages
Eventually, if ODT is to be supported, you will also need to add documentation
in [2] and possibly create a new file at [3].
[2] src/documentation/content/xdocs/trunk/output.xml
[3] src/documentation/content/xdocs/trunk/odt.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
patches@portaildulibre.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |patches@portaildulibre.fr
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53400] [PATCH] new ODT render
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53400
Marek Jagielski <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #29347|0 |1
is obsolete| |
--- Comment #21 from Marek Jagielski <ma...@gmail.com> ---
Created attachment 29448
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29448&action=edit
PATCH for ODT render
Small refactoring. BackgroundColor property shows how to create different
implementations of property for different tags.
--
You are receiving this mail because:
You are the assignee for the bug.