You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/21 00:16:37 UTC

[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1841: Implement bitmap_distinct function using croaring-rs bitmap

houqp commented on a change in pull request #1841:
URL: https://github.com/apache/arrow-datafusion/pull/1841#discussion_r810708597



##########
File path: datafusion/Cargo.toml
##########
@@ -81,6 +81,7 @@ num-traits = { version = "0.2", optional = true }
 pyo3 = { version = "0.15", optional = true }
 tempfile = "3"
 parking_lot = "0.12"
+croaring = "0.5.1"

Review comment:
       I agree with @alamb , would be good if we can either make this dependency optional or change to a pure rust implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org