[GitHub] JaredTan95 commented on issue #1962: add system env in docker configuration

[GitBox <gi...@apache.org>]

JaredTan95 commented on issue #1962: add system env in docker configuration
URL: https://github.com/apache/incubator-skywalking/pull/1962#issuecomment-441539053
 
 
   > @JaredTan95 Could you check this PR at your local env? and give us the feedback?
   
   /lgtm, I checked it in my local env with docker.
   1、`mvn clean package`
   2、`cd docker && make build`
   3、`docker-compose up -d`
   looks great.
   then,i modified the `docker-compose.yml` with overriding `environment`:
   ```
   version: '3.3'
   services:
     elasticsearch:
       image: docker.elastic.co/elasticsearch/elasticsearch:6.3.2
       container_name: elasticsearch
       restart: always
       ports:
         - 9200:9200
         - 9300:9300
       environment:
         discovery.type: single-node
     oap:
       image: skywalking/oap
       container_name: oap
       depends_on:
         - elasticsearch
       links:
         - elasticsearch
       restart: always
       environment:
         SW_CORE_REST_PORT: 13800 # 12800->13800
       ports:
         - 11800:11800
         - 12800:12800
       volumes:
         - ./config:/apache-skywalking-apm-incubating/config:ro
     ui:
       image: skywalking/ui
       container_name: ui
       depends_on:
         - oap
       links:
         - oap
       restart: always
       ports:
         - 8080:8080
       environment:
         collector.ribbon.listOfServers: oap:13800 # 12800->13800
   ```
   and the UI looks well. :D FYI @adriancole @wu-sheng @hanahmily 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services