You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by bu...@apache.org on 2004/08/27 00:04:29 UTC

DO NOT REPLY [Bug 30874] - SQLTransformer throws exception with stored procs on Sybase

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=30874>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30874

SQLTransformer throws exception with stored procs on Sybase





------- Additional Comments From ats37@hotmail.com  2004-08-26 22:04 -------
The obvious (and trivial) fix, of course, is to replace

                if ( pst != null )
                    pst.close();
                pst = null;        // Prevent using pst again.
                if ( cst != null )
                    cst.close();
                cst = null;        // Prevent using cst again.

with

                if ( pst != null && pst != cst )
                    pst.close();
                pst = null;        // Prevent using pst again.
                if ( cst != null )
                    cst.close();
                cst = null;        // Prevent using cst again.

without any risk of breaking anything, if for some reason both of them are ever
(legitimately) used and different (which I doubt).

I'd offer to upload a patch, but for 14 characters it hardly seems worth it ;-)