[GitHub] [cordova-plugin-inappbrowser] nicolashenry commented on a change in pull request #293: GH-292 android: SSL errors handling in Android

[GitBox <gi...@apache.org>]

nicolashenry commented on a change in pull request #293:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/293#discussion_r422096818



##########
File path: src/android/InAppBrowser.java
##########
@@ -1446,6 +1448,46 @@ public void onReceivedError(WebView view, int errorCode, String description, Str
             }
         }
 
+        @Override
+        public void onReceivedSslError(WebView view, SslErrorHandler handler, SslError error) {
+            super.onReceivedSslError(view, handler, error);
+            try {
+                JSONObject obj = new JSONObject();
+                obj.put("type", LOAD_ERROR_EVENT);
+                obj.put("url", error.getUrl());
+                obj.put("code", 0);

Review comment:
       I think "code" is supposed to be http code like 404/500 etc so I defined 0 as the code because it can't be determined here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org