[GitHub] [james-project] Arsnael commented on a diff in pull request #1707: JAMES-3925 Recompute current values of JMAP upload

["Arsnael (via GitHub)" <gi...@apache.org>]

Arsnael commented on code in PR #1707:
URL: https://github.com/apache/james-project/pull/1707#discussion_r1316715281


##########
server/protocols/webadmin/webadmin-mailbox/src/main/java/org/apache/james/webadmin/routes/UserQuotaRoutes.java:
##########
@@ -99,17 +101,22 @@ private static Optional<Integer> intQueryParameter(Request request) {
             }
         }
 
-        private static Optional<QuotaComponent> getQuotaComponent(Request request) {
-            String quotaComponentString = request.queryParams(USERS_PER_SECOND);
-            if (Objects.isNull(quotaComponentString)) {
-                return Optional.empty();
+        private static List<QuotaComponent> getQuotaComponent(Request request) {
+            List<QuotaComponent> quotaComponents = new ArrayList<>();
+            String[] quotaComponentStrings = request.queryParamsValues(QUOTA_COMPONENT);

Review Comment:
   Shouldn't you be able to work on a stream directly from `request.queryParamsValues(QUOTA_COMPONENT)`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org