You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apiri <gi...@git.apache.org> on 2018/06/10 14:50:21 UTC
[GitHub] nifi pull request #2779: NIFI-5006 Updating NOTICEs to 2018
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/2779
NIFI-5006 Updating NOTICEs to 2018
This was performed, mostly, via:
`find . -type f -name 'NOTICE' -exec sed -i -e "2s/2017/2018/" {} \;`
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi NIFI-5006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2779.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2779
----
commit 6eae999089155000caf8b924fd0d243881eb5099
Author: Aldrin Piri <al...@...>
Date: 2018-06-10T14:38:18Z
NIFI-5006 Updating NOTICEs to 2018
----
---
[GitHub] nifi pull request #2779: NIFI-5006 Updating NOTICEs to 2018
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2779#discussion_r194268754
--- Diff: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-nar/src/main/resources/META-INF/NOTICE ---
@@ -1,5 +1,5 @@
nifi-influxdb-nar
-Copyright 2017 The Apache Software Foundation
+Copyright 2018 The Apache Software Foundation
--- End diff --
Changed this to *Copyright 2017-2018 The Apache Software Foundation*.
---
[GitHub] nifi issue #2779: NIFI-5006 Updating NOTICEs to 2018
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2779
Reviewing...
---
[GitHub] nifi pull request #2779: NIFI-5006 Updating NOTICEs to 2018
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2779
---
[GitHub] nifi issue #2779: NIFI-5006 Updating NOTICEs to 2018
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2779
Made one minor adjustment. Other than that, great. Thanks. +1, merging.
---