You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2015/11/25 02:09:13 UTC
Review Request 40687: GEODE-584: Removes Assert class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40687/
-----------------------------------------------------------
Review request for geode and Jens Deppe.
Repository: geode
Description
-------
Changes uses of .../cli/util/spring/Assert to spring-core library.
GEODE-584: Removes ObjectUtils class
Replaces use of .../cli/util/spring/ObjectUtils to spring-core library.
GEODE-584: Removes ReflectionUtils class
Replaces uses of .../cli/util/spring/ReflectionUtils to spring-core library.
GEODE-584: Removes StringUtils class
Replaces use of .../cli/util/spring/StringUtils with commons-lang library.
GEODE-584: Fix StringUtils calls
Merge branch 'develop' into feature/GEODE-584
GEODE-584: Fix classpath
Diffs
-----
gemfire-assembly/build.gradle 1f1b7988a2ca7855dbc7b3fec59c8e03f403ae6a
gemfire-core/build.gradle 8e45a979f52f20702eb3955a6e5f6cfec6aff59f
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/GfshParser.java e28ded03a8a2c6ca3e59d2f713eed2bb3edd2d52
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/converters/DirConverter.java 17a613008b45afd99b323012a19d5a1568e26274
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java f1a2eded5bb5bf42df24ef274ea4193565d91183
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/GfshMethodTarget.java 8675085e7caf7eac8779690a795c424cc6923c30
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java 29ebb023e5502afaae28bc0b66667a1f8ece9a1f
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/preprocessor/PreprocessorUtils.java 137d211eabb4600d3e3fec39127eea0ec6d1691c
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/RemoteExecutionStrategy.java 375a387e6ac23e01d1b83a1623ca5ad22dcfe2b2
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java f259ca1556517bb90bb1e5d7e335fe2a07a963b7
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/CommentSkipHelper.java d1b056823408713ec3dbca4d9e8fbf8eb67a9d7b
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/Assert.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ObjectUtils.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ReflectionUtils.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/StringUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/40687/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 40687: GEODE-584: Removes spring utils classes
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40687/#review108048
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On Nov. 25, 2015, 1:09 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40687/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 1:09 a.m.)
>
>
> Review request for geode and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Changes uses of .../cli/util/spring/Assert to spring-core library.
>
> GEODE-584: Removes ObjectUtils class
>
> Replaces use of .../cli/util/spring/ObjectUtils to spring-core library.
>
> GEODE-584: Removes ReflectionUtils class
>
> Replaces uses of .../cli/util/spring/ReflectionUtils to spring-core library.
>
> GEODE-584: Removes StringUtils class
>
> Replaces use of .../cli/util/spring/StringUtils with commons-lang library.
>
> GEODE-584: Fix StringUtils calls
>
>
> Merge branch 'develop' into feature/GEODE-584
>
>
> GEODE-584: Fix classpath
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 1f1b7988a2ca7855dbc7b3fec59c8e03f403ae6a
> gemfire-core/build.gradle 8e45a979f52f20702eb3955a6e5f6cfec6aff59f
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/GfshParser.java e28ded03a8a2c6ca3e59d2f713eed2bb3edd2d52
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/converters/DirConverter.java 17a613008b45afd99b323012a19d5a1568e26274
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java f1a2eded5bb5bf42df24ef274ea4193565d91183
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/GfshMethodTarget.java 8675085e7caf7eac8779690a795c424cc6923c30
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java 29ebb023e5502afaae28bc0b66667a1f8ece9a1f
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/preprocessor/PreprocessorUtils.java 137d211eabb4600d3e3fec39127eea0ec6d1691c
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/RemoteExecutionStrategy.java 375a387e6ac23e01d1b83a1623ca5ad22dcfe2b2
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java f259ca1556517bb90bb1e5d7e335fe2a07a963b7
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/CommentSkipHelper.java d1b056823408713ec3dbca4d9e8fbf8eb67a9d7b
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/Assert.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ObjectUtils.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ReflectionUtils.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/StringUtils.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40687/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 40687: GEODE-584: Removes spring utils classes
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40687/#review108047
-----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java (line 46)
<https://reviews.apache.org/r/40687/#comment167423>
Can you correct this doc link while you're here :)
- Jens Deppe
On Nov. 25, 2015, 1:09 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40687/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 1:09 a.m.)
>
>
> Review request for geode and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Changes uses of .../cli/util/spring/Assert to spring-core library.
>
> GEODE-584: Removes ObjectUtils class
>
> Replaces use of .../cli/util/spring/ObjectUtils to spring-core library.
>
> GEODE-584: Removes ReflectionUtils class
>
> Replaces uses of .../cli/util/spring/ReflectionUtils to spring-core library.
>
> GEODE-584: Removes StringUtils class
>
> Replaces use of .../cli/util/spring/StringUtils with commons-lang library.
>
> GEODE-584: Fix StringUtils calls
>
>
> Merge branch 'develop' into feature/GEODE-584
>
>
> GEODE-584: Fix classpath
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 1f1b7988a2ca7855dbc7b3fec59c8e03f403ae6a
> gemfire-core/build.gradle 8e45a979f52f20702eb3955a6e5f6cfec6aff59f
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/GfshParser.java e28ded03a8a2c6ca3e59d2f713eed2bb3edd2d52
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/converters/DirConverter.java 17a613008b45afd99b323012a19d5a1568e26274
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java f1a2eded5bb5bf42df24ef274ea4193565d91183
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/GfshMethodTarget.java 8675085e7caf7eac8779690a795c424cc6923c30
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java 29ebb023e5502afaae28bc0b66667a1f8ece9a1f
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/preprocessor/PreprocessorUtils.java 137d211eabb4600d3e3fec39127eea0ec6d1691c
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/RemoteExecutionStrategy.java 375a387e6ac23e01d1b83a1623ca5ad22dcfe2b2
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java f259ca1556517bb90bb1e5d7e335fe2a07a963b7
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/CommentSkipHelper.java d1b056823408713ec3dbca4d9e8fbf8eb67a9d7b
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/Assert.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ObjectUtils.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ReflectionUtils.java PRE-CREATION
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/StringUtils.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40687/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 40687: GEODE-584: Removes spring utils classes
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40687/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 1:09 a.m.)
Review request for geode and Jens Deppe.
Summary (updated)
-----------------
GEODE-584: Removes spring utils classes
Repository: geode
Description
-------
Changes uses of .../cli/util/spring/Assert to spring-core library.
GEODE-584: Removes ObjectUtils class
Replaces use of .../cli/util/spring/ObjectUtils to spring-core library.
GEODE-584: Removes ReflectionUtils class
Replaces uses of .../cli/util/spring/ReflectionUtils to spring-core library.
GEODE-584: Removes StringUtils class
Replaces use of .../cli/util/spring/StringUtils with commons-lang library.
GEODE-584: Fix StringUtils calls
Merge branch 'develop' into feature/GEODE-584
GEODE-584: Fix classpath
Diffs
-----
gemfire-assembly/build.gradle 1f1b7988a2ca7855dbc7b3fec59c8e03f403ae6a
gemfire-core/build.gradle 8e45a979f52f20702eb3955a6e5f6cfec6aff59f
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/GfshParser.java e28ded03a8a2c6ca3e59d2f713eed2bb3edd2d52
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/converters/DirConverter.java 17a613008b45afd99b323012a19d5a1568e26274
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/multistep/CLIMultiStepHelper.java f1a2eded5bb5bf42df24ef274ea4193565d91183
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/GfshMethodTarget.java 8675085e7caf7eac8779690a795c424cc6923c30
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/jopt/JoptOptionParser.java 29ebb023e5502afaae28bc0b66667a1f8ece9a1f
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/parser/preprocessor/PreprocessorUtils.java 137d211eabb4600d3e3fec39127eea0ec6d1691c
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/remote/RemoteExecutionStrategy.java 375a387e6ac23e01d1b83a1623ca5ad22dcfe2b2
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshExecutionStrategy.java f259ca1556517bb90bb1e5d7e335fe2a07a963b7
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/CommentSkipHelper.java d1b056823408713ec3dbca4d9e8fbf8eb67a9d7b
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/Assert.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ObjectUtils.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/ReflectionUtils.java PRE-CREATION
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/util/spring/StringUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/40687/diff/
Testing
-------
Thanks,
Anthony Baker