You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/02 11:56:32 UTC
[GitHub] [airflow] baolsen opened a new pull request #6999: [AIRFLOW-XXX]
Clarify wait_for_downstream and execution_date
baolsen opened a new pull request #6999: [AIRFLOW-XXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999
- [X] Description above provides context of the change
- [X] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mattbowden-ookla commented on issue #6999: [AIRFLOW-XXXX]
Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
mattbowden-ookla commented on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570241215
This is extremely helpful, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6999: [AIRFLOW-XXXX] Clarify
wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570208870
Looks good to me but maybe someone who can verify better the details of those parameters ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362927848
##########
File path: docs/tutorial.rst
##########
@@ -313,8 +315,16 @@ to track the progress. ``airflow webserver`` will start a web server if you
are interested in tracking the progress visually as your backfill progresses.
Note that if you use ``depends_on_past=True``, individual task instances
-will depend on the success of the preceding task instance, except for the
-start_date specified itself, for which this dependency is disregarded.
+will depend on the success of their previous task instance (that is, previous
Review comment:
Yeah, it makes sense. I saw your new definition on the `previous` and `upstream`. They look pretty nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 85.01% 84.72% -0.29%
==========================================
Files 680 680
Lines 38748 38748
==========================================
- Hits 32942 32830 -112
- Misses 5806 5918 +112
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `85.33% <0%> (-2.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [f4c7d17...ee9ba23](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362745923
##########
File path: docs/concepts.rst
##########
@@ -341,62 +471,21 @@ is equivalent to:
[op4, op5] >> op6
-Tasks
-=====
-
-Once an operator is instantiated, it is referred to as a "task". The
-instantiation defines specific values when calling the abstract operator, and
-the parameterized task becomes a node in a DAG.
-
-Task Instances
-==============
-
-A task instance represents a specific run of a task and is characterized as the
-combination of a DAG, a task, and a point in time. Task instances also have an
-indicative state, which could be "running", "success", "failed", "skipped", "up
-for retry", etc.
-
-Task Lifecycle
-==============
-
-A task goes through various stages from start to completion. In the Airflow UI
-(graph and tree views), these stages are displayed by a color representing each
-stage:
-
-.. image:: img/task_stages.png
-
-The complete lifecycle of the task looks like this:
-
-.. image:: img/task_lifecycle_diagram.png
-
-The happy flow consists of the following stages:
-
-1. No status (scheduler created empty task instance)
-2. Scheduled (scheduler determined task instance needs to run)
-3. Queued (scheduler sent task to executor to run on the queue)
-4. Running (worker picked up a task and is now running it)
-5. Success (task completed)
-
-There is also visual difference between scheduled and manually triggered
-DAGs/tasks:
-
-.. image:: img/task_manual_vs_scheduled.png
-
-The DAGs/tasks with a black border are scheduled runs, whereas the non-bordered
-DAGs/tasks are manually triggered, i.e. by ``airflow dags trigger``.
-
Workflows
=========
You're now familiar with the core building blocks of Airflow.
Some of the concepts may sound very similar, but the vocabulary can
be conceptualized like this:
-- DAG: a description of the order in which work should take place
Review comment:
Changed wording for some of these and added others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr&el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.85% 84.48% -0.37%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32698 32558 -140
- Misses 5838 5978 +140
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `94.91% <0%> (-1.7%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.08% <0%> (-1.66%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [be812bd...4c3da95](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 85.01% 84.72% -0.29%
==========================================
Files 680 680
Lines 38748 38748
==========================================
- Hits 32942 32830 -112
- Misses 5806 5918 +112
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `85.33% <0%> (-2.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [f4c7d17...ee9ba23](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362538389
##########
File path: docs/tutorial.rst
##########
@@ -313,8 +315,16 @@ to track the progress. ``airflow webserver`` will start a web server if you
are interested in tracking the progress visually as your backfill progresses.
Note that if you use ``depends_on_past=True``, individual task instances
-will depend on the success of the preceding task instance, except for the
-start_date specified itself, for which this dependency is disregarded.
+will depend on the success of their previous task instance (that is, previous
Review comment:
Just small NIT.. I feel like the original word `preceding` is clearer to me than `previous`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.48% -0.33%
==========================================
Files 679 679
Lines 38495 38536 +41
==========================================
- Hits 32649 32558 -91
- Misses 5846 5978 +132
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `94.91% <0%> (-1.7%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.08% <0%> (-1.66%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...4c3da95](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr&el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.85% 84.48% -0.37%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32698 32558 -140
- Misses 5838 5978 +140
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `94.91% <0%> (-1.7%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.08% <0%> (-1.66%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [be812bd...4c3da95](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r363110368
##########
File path: docs/concepts.rst
##########
@@ -113,13 +116,138 @@ DAGs can be used as context managers to automatically assign new operators to th
op.dag is dag # True
-.. _concepts-operators:
+.. _concepts:dagruns:
+
+DAG Runs
+========
+
+A DAG run is a physical instance of a DAG, containing task instances that run for a specific ``execution_date``.
+
+A DAG run is usually created by the Airflow scheduler, but can also be created by an external trigger.
+Multiple DAG runs may be running at once for a particular DAG, each of them having a different ``execution_date``.
+For example, we might currently have two DAG runs that are in progress for 2016-01-01 and 2016-01-02 respectively.
+
+.. _concepts:execution_date:
+
+execution_date
+--------------
+
+The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
+
+This allows task instances to process data for the desired *logical* date & time.
+While a task_instance or DAG run might have a *physical* start date of now,
+their *logical* date might be 3 months ago because we are busy reloading something.
+
+In the prior example the ``execution_date`` was 2016-01-01 for the first DAG Run and 2016-01-02 for the second.
+
+A DAG run and all task instances created within it are instanced with the same ``execution_date``, so
+that logically you can think of a DAG run as simulating the DAG running all of its tasks at some
+previous date & time specified by the ``execution_date``.
+
+.. _concepts:tasks:
+
+Tasks
Review comment:
❤️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362745478
##########
File path: docs/concepts.rst
##########
@@ -113,13 +116,138 @@ DAGs can be used as context managers to automatically assign new operators to th
op.dag is dag # True
-.. _concepts-operators:
+.. _concepts:dagruns:
+
+DAG Runs
+========
+
+A DAG run is a physical instance of a DAG, containing task instances that run for a specific ``execution_date``.
+
+A DAG run is usually created by the Airflow scheduler, but can also be created by an external trigger.
+Multiple DAG runs may be running at once for a particular DAG, each of them having a different ``execution_date``.
+For example, we might currently have two DAG runs that are in progress for 2016-01-01 and 2016-01-02 respectively.
+
+.. _concepts:execution_date:
+
+execution_date
+--------------
+
+The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
+
+This allows task instances to process data for the desired *logical* date & time.
+While a task_instance or DAG run might have a *physical* start date of now,
+their *logical* date might be 3 months ago because we are busy reloading something.
+
+In the prior example the ``execution_date`` was 2016-01-01 for the first DAG Run and 2016-01-02 for the second.
+
+A DAG run and all task instances created within it are instanced with the same ``execution_date``, so
+that logically you can think of a DAG run as simulating the DAG running all of its tasks at some
+previous date & time specified by the ``execution_date``.
+
+.. _concepts:tasks:
+
+Tasks
Review comment:
Moved Task and Task Instance up (before Operator) as they are kind of more high level concepts. We start off talking about workflow / dependencies / orchestration, so rather continue with that and then dive lower into operator details.
I feel this more clearly shows what a dependency looks like and what is upstream/downstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362746240
##########
File path: docs/tutorial.rst
##########
@@ -335,11 +345,14 @@ running against it should get it to get triggered and run every day.
Here's a few things you might want to do next:
Review comment:
Added some convenient links (especially the Concepts page!) and tidied up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362745111
##########
File path: docs/concepts.rst
##########
@@ -113,13 +116,138 @@ DAGs can be used as context managers to automatically assign new operators to th
op.dag is dag # True
-.. _concepts-operators:
+.. _concepts:dagruns:
+
+DAG Runs
Review comment:
Added section for DAG Runs and execution_date, as I feel they are important concepts and give a lot of context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on issue #6999: [AIRFLOW-XXXX] Clarify
wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570514239
Hey @potiuk, @mattbowden-ookla, @xinbinhuang
I've added some changes to Tutorial and Concepts, don't want to add more or this PR will get too big to review. Please take a look and let me know what you think :)
I was trying to remember some of the concepts I struggled with as a new user, and added docs to help clarify them. Also made some subtle clarifications here and there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r363110509
##########
File path: docs/concepts.rst
##########
@@ -155,7 +283,9 @@ operators: :class:`~airflow.operators.docker_operator.DockerOperator`,
Operators are only loaded by Airflow if they are assigned to a DAG.
-See :doc:`howto/operator/index` for how to use Airflow operators.
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362704684
##########
File path: docs/tutorial.rst
##########
@@ -313,8 +315,16 @@ to track the progress. ``airflow webserver`` will start a web server if you
are interested in tracking the progress visually as your backfill progresses.
Note that if you use ``depends_on_past=True``, individual task instances
-will depend on the success of the preceding task instance, except for the
-start_date specified itself, for which this dependency is disregarded.
+will depend on the success of their previous task instance (that is, previous
Review comment:
Thanks for the feedback.
So I wasn't 100% decided between "preceding" vs "previous", but decided to change it to previous because "previous" is the word used elsewhere in the documentation and code to refer to "past instances".
I learned yesterday that the two words have very similar definition and can be used interchangeably :).
It can be confusing to a developer. "previous + next" usually go together as concepts and refer to objects that are linked somehow, yet in this context the tasks that are linked are actually called "upstream/downstream".
However, across the code we have used "previous" to refer to "past instances" of tasks and dag runs, meaning perhaps it is more natural to refer to "previous" things rather than "past"/"preceding"/"prior" things.
I've just found the Concepts section and I think it would be good to add some definitions here. As a new user is can be really confusing to understand upstream/downstream vs previous/next execution. Execution_date isn't even mentioned in Concepts at all - I'll see if I can add something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362744996
##########
File path: docs/concepts.rst
##########
@@ -33,6 +33,9 @@ In Airflow, a ``DAG`` -- or a Directed Acyclic Graph -- is a collection of all
the tasks you want to run, organized in a way that reflects their relationships
and dependencies.
+A DAG is defined in a Python script, which represents the DAGs structure (tasks
+and their dependencies) as code.
Review comment:
While this is mentioned later on, it is a concept that is often misunderstood (even the tutorial had to emphasise this). I still have colleagues who don't realize a DAG is actually code...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r363017645
##########
File path: docs/tutorial.rst
##########
@@ -313,8 +315,16 @@ to track the progress. ``airflow webserver`` will start a web server if you
are interested in tracking the progress visually as your backfill progresses.
Note that if you use ``depends_on_past=True``, individual task instances
-will depend on the success of the preceding task instance, except for the
-start_date specified itself, for which this dependency is disregarded.
+will depend on the success of their previous task instance (that is, previous
Review comment:
Thanks for the feedback :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr&el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.85% 84.48% -0.37%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32698 32558 -140
- Misses 5838 5978 +140
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `94.91% <0%> (-1.7%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.08% <0%> (-1.66%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [be812bd...4c3da95](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362745765
##########
File path: docs/concepts.rst
##########
@@ -341,62 +471,21 @@ is equivalent to:
[op4, op5] >> op6
-Tasks
Review comment:
Moved up and changed wording slightly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6999: [AIRFLOW-XXXX]
Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr&el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.85% 84.48% -0.37%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32698 32558 -140
- Misses 5838 5978 +140
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `94.91% <0%> (-1.7%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.08% <0%> (-1.66%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [be812bd...4c3da95](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e79d8d223808f9f75ba0e6cfce210b2c65390fd0?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.73% 84.67% -0.07%
==========================================
Files 679 679
Lines 38593 38593
==========================================
- Hits 32702 32677 -25
- Misses 5891 5916 +25
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+0.82%)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (+0.97%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [e79d8d2...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r363110427
##########
File path: docs/concepts.rst
##########
@@ -113,13 +116,138 @@ DAGs can be used as context managers to automatically assign new operators to th
op.dag is dag # True
-.. _concepts-operators:
+.. _concepts:dagruns:
+
+DAG Runs
+========
+
+A DAG run is a physical instance of a DAG, containing task instances that run for a specific ``execution_date``.
+
+A DAG run is usually created by the Airflow scheduler, but can also be created by an external trigger.
+Multiple DAG runs may be running at once for a particular DAG, each of them having a different ``execution_date``.
+For example, we might currently have two DAG runs that are in progress for 2016-01-01 and 2016-01-02 respectively.
+
+.. _concepts:execution_date:
+
+execution_date
+--------------
+
+The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
+
+This allows task instances to process data for the desired *logical* date & time.
+While a task_instance or DAG run might have a *physical* start date of now,
+their *logical* date might be 3 months ago because we are busy reloading something.
+
+In the prior example the ``execution_date`` was 2016-01-01 for the first DAG Run and 2016-01-02 for the second.
+
+A DAG run and all task instances created within it are instanced with the same ``execution_date``, so
+that logically you can think of a DAG run as simulating the DAG running all of its tasks at some
+previous date & time specified by the ``execution_date``.
+
+.. _concepts:tasks:
+
+Tasks
+=====
+
+A Task defines a unit of work within a DAG; it is represented as a node in the DAG graph, and it is written in Python.
+
+Each task is an implementation of an Operator, for example a ``PythonOperator`` to execute some Python code,
+or a ``BashOperator`` to run a Bash command.
+
+The task implements an operator by defining specific values for that operator,
+such as a Python callable in the case of ``PythonOperator`` or a Bash command in the case of ``BashOperator``.
+
+Relations between Tasks
+-----------------------
+
+Consider the following DAG with two tasks.
+Each task is a node in our DAG, and there is a dependency from task_1 to task_2:
+
+.. code:: python
+
+ with DAG('my_dag', start_date=datetime(2016, 1, 1)) as dag:
+ task_1 = DummyOperator('task_1')
+ task_2 = DummyOperator('task_2')
+ task_1 >> task_2 # Define dependencies
+
+We can say that task_1 is *upstream* of task_2, and conversely task_2 is *downstream* of task_1.
+When a DAG Run is created, task_1 will start running and task_2 waits for task_1 to complete successfully before it may start.
+
+Task Instances
+==============
+
+A task instance represents a specific run of a task and is characterized as the
+combination of a DAG, a task, and a point in time (``execution_date``). Task instances
+also have an indicative state, which could be "running", "success", "failed", "skipped", "up
+for retry", etc.
+
+Tasks are defined in DAGs, and both are written in Python code to define what you want to do.
+Task Instances belong to DAG Runs, have an associated ``execution_date``, and are physicalised, runnable entities.
+
+Relations between Task Instances
+--------------------------------
+
+Again consider the following tasks, defined for some DAG:
+
+.. code:: python
+
+ with DAG('my_dag', start_date=datetime(2016, 1, 1)) as dag:
+ task_1 = DummyOperator('task_1')
+ task_2 = DummyOperator('task_2')
+ task_1 >> task_2 # Define dependencies
+
+When we enable this DAG, the scheduler creates several DAG Runs - one with ``execution_date`` of 2016-01-01,
+one with ``execution_date`` of 2016-01-02, and so on up to the current date.
+
+Each DAG Run will contain a task_1 Task Instance and a task_2 Task instance. Both Task Instances will
+have ``execution_date`` equal to the DAG Run's ``execution_date``, and each task_2 will be *upstream* of
+(depends on) its task_1.
+
+We can also say that task_1 for 2016-01-01 is the *previous* task instance of the task_1 for 2016-01-02.
+Or that the DAG Run for 2016-01-01 is the *previous* DAG Run to the DAG Run of 2016-01-02.
+Here, *previous* refers to the logical past/prior ``execution_date``, that runs independently of other runs,
+and *upstream* refers to a dependency within the same run and having the same ``execution_date``.
+
Review comment:
❤️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362745652
##########
File path: docs/concepts.rst
##########
@@ -155,7 +283,9 @@ operators: :class:`~airflow.operators.docker_operator.DockerOperator`,
Operators are only loaded by Airflow if they are assigned to a DAG.
-See :doc:`howto/operator/index` for how to use Airflow operators.
Review comment:
This link only shows a subset of operators, making the documentation difficult to navigate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 85.01% 84.72% -0.29%
==========================================
Files 680 680
Lines 38748 38748
==========================================
- Hits 32942 32830 -112
- Misses 5806 5918 +112
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `85.33% <0%> (-2.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [f4c7d17...ee9ba23](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r363110597
##########
File path: docs/tutorial.rst
##########
@@ -313,8 +315,16 @@ to track the progress. ``airflow webserver`` will start a web server if you
are interested in tracking the progress visually as your backfill progresses.
Note that if you use ``depends_on_past=True``, individual task instances
-will depend on the success of the preceding task instance, except for the
-start_date specified itself, for which this dependency is disregarded.
+will depend on the success of their previous task instance (that is, previous
Review comment:
Like it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] baolsen commented on a change in pull request #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
baolsen commented on a change in pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#discussion_r362747213
##########
File path: docs/concepts.rst
##########
@@ -113,13 +116,138 @@ DAGs can be used as context managers to automatically assign new operators to th
op.dag is dag # True
-.. _concepts-operators:
+.. _concepts:dagruns:
+
+DAG Runs
+========
+
+A DAG run is a physical instance of a DAG, containing task instances that run for a specific ``execution_date``.
+
+A DAG run is usually created by the Airflow scheduler, but can also be created by an external trigger.
+Multiple DAG runs may be running at once for a particular DAG, each of them having a different ``execution_date``.
+For example, we might currently have two DAG runs that are in progress for 2016-01-01 and 2016-01-02 respectively.
+
+.. _concepts:execution_date:
+
+execution_date
+--------------
+
+The ``execution_date`` is the *logical* date and time which the DAG Run, and its task instances, are running for.
+
+This allows task instances to process data for the desired *logical* date & time.
+While a task_instance or DAG run might have a *physical* start date of now,
+their *logical* date might be 3 months ago because we are busy reloading something.
+
+In the prior example the ``execution_date`` was 2016-01-01 for the first DAG Run and 2016-01-02 for the second.
+
+A DAG run and all task instances created within it are instanced with the same ``execution_date``, so
+that logically you can think of a DAG run as simulating the DAG running all of its tasks at some
+previous date & time specified by the ``execution_date``.
+
+.. _concepts:tasks:
+
+Tasks
+=====
+
+A Task defines a unit of work within a DAG; it is represented as a node in the DAG graph, and it is written in Python.
+
+Each task is an implementation of an Operator, for example a ``PythonOperator`` to execute some Python code,
+or a ``BashOperator`` to run a Bash command.
+
+The task implements an operator by defining specific values for that operator,
+such as a Python callable in the case of ``PythonOperator`` or a Bash command in the case of ``BashOperator``.
+
+Relations between Tasks
+-----------------------
+
+Consider the following DAG with two tasks.
+Each task is a node in our DAG, and there is a dependency from task_1 to task_2:
+
+.. code:: python
+
+ with DAG('my_dag', start_date=datetime(2016, 1, 1)) as dag:
+ task_1 = DummyOperator('task_1')
+ task_2 = DummyOperator('task_2')
+ task_1 >> task_2 # Define dependencies
+
+We can say that task_1 is *upstream* of task_2, and conversely task_2 is *downstream* of task_1.
+When a DAG Run is created, task_1 will start running and task_2 waits for task_1 to complete successfully before it may start.
+
+Task Instances
+==============
+
+A task instance represents a specific run of a task and is characterized as the
+combination of a DAG, a task, and a point in time (``execution_date``). Task instances
+also have an indicative state, which could be "running", "success", "failed", "skipped", "up
+for retry", etc.
+
+Tasks are defined in DAGs, and both are written in Python code to define what you want to do.
+Task Instances belong to DAG Runs, have an associated ``execution_date``, and are physicalised, runnable entities.
+
+Relations between Task Instances
+--------------------------------
+
+Again consider the following tasks, defined for some DAG:
+
+.. code:: python
+
+ with DAG('my_dag', start_date=datetime(2016, 1, 1)) as dag:
+ task_1 = DummyOperator('task_1')
+ task_2 = DummyOperator('task_2')
+ task_1 >> task_2 # Define dependencies
+
+When we enable this DAG, the scheduler creates several DAG Runs - one with ``execution_date`` of 2016-01-01,
+one with ``execution_date`` of 2016-01-02, and so on up to the current date.
+
+Each DAG Run will contain a task_1 Task Instance and a task_2 Task instance. Both Task Instances will
+have ``execution_date`` equal to the DAG Run's ``execution_date``, and each task_2 will be *upstream* of
+(depends on) its task_1.
+
+We can also say that task_1 for 2016-01-01 is the *previous* task instance of the task_1 for 2016-01-02.
+Or that the DAG Run for 2016-01-01 is the *previous* DAG Run to the DAG Run of 2016-01-02.
+Here, *previous* refers to the logical past/prior ``execution_date``, that runs independently of other runs,
+and *upstream* refers to a dependency within the same run and having the same ``execution_date``.
+
Review comment:
Not sure how you feel about this note - but I think differentiating between previous and upstream is important for a new user especially. The concepts of upstream / downstream task didn't sink in for me at first and explicitly calling them out from previous would have helped me immediately understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4bfde026d14441a9fcb26e5e7f465def3f13eaa5?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.81% 84.67% -0.15%
==========================================
Files 679 679
Lines 38495 38593 +98
==========================================
+ Hits 32649 32677 +28
- Misses 5846 5916 +70
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (+0.17%)` | :arrow_up: |
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `81.69% <0%> (-1.06%)` | :arrow_down: |
| [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.39% <0%> (-0.78%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [4bfde02...696035a](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6999: [AIRFLOW-XXXX] Clarify
wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570937634
You just need to solve conflicts @baolsen and it's good to go I think!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6999: [AIRFLOW-XXXX] Clarify
wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6999:
[AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6999: [AIRFLOW-XXXX] Clarify wait_for_downstream and execution_date
URL: https://github.com/apache/airflow/pull/6999#issuecomment-570196566
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=h1) Report
> Merging [#6999](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/be812bd660fac4621a25f3269fded8d4e03b0023?src=pr&el=desc) will **decrease** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6999 +/- ##
==========================================
- Coverage 84.85% 84.48% -0.37%
==========================================
Files 679 679
Lines 38536 38536
==========================================
- Hits 32698 32558 -140
- Misses 5838 5978 +140
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/ti\_deps/deps/prev\_dagrun\_dep.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy90aV9kZXBzL2RlcHMvcHJldl9kYWdydW5fZGVwLnB5) | `80.55% <ø> (ø)` | :arrow_up: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <ø> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `94.91% <0%> (-1.7%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.08% <0%> (-1.66%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6999/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=footer). Last update [be812bd...4c3da95](https://codecov.io/gh/apache/airflow/pull/6999?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services