You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2019/09/06 09:01:31 UTC

[lucenenet] 21/21: Lucene.Net.TestFramework: Changed exception handling on BeforeClass and AfterClass to throw the current stack trace in the error message

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit 0407907a3721f83d521d45c4750213e365d5f169
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Fri Sep 6 01:42:40 2019 +0700

    Lucene.Net.TestFramework: Changed exception handling on BeforeClass and AfterClass to throw the current stack trace in the error message
---
 .../Index/BaseTermVectorsFormatTestCase.cs                   |  2 +-
 src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs          | 12 ++++--------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/Lucene.Net.TestFramework/Index/BaseTermVectorsFormatTestCase.cs b/src/Lucene.Net.TestFramework/Index/BaseTermVectorsFormatTestCase.cs
index fd08443..13048b9 100644
--- a/src/Lucene.Net.TestFramework/Index/BaseTermVectorsFormatTestCase.cs
+++ b/src/Lucene.Net.TestFramework/Index/BaseTermVectorsFormatTestCase.cs
@@ -428,7 +428,7 @@ namespace Lucene.Net.Index
                     this.fieldNames[i] = RandomPicks.RandomFrom(Random, fieldNames.Except(usedFileNames).ToArray());
                     //do
                     //{
-                    //    this.FieldNames[i] = RandomInts.RandomFrom(Random(), fieldNames);
+                    //    this.FieldNames[i] = RandomPicks.RandomFrom(Random(), fieldNames);
                     //} while (usedFileNames.Contains(this.FieldNames[i]));
 
                     usedFileNames.Add(this.fieldNames[i]);
diff --git a/src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs b/src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs
index 78da957..0b5c579 100644
--- a/src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs
+++ b/src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs
@@ -733,10 +733,8 @@ namespace Lucene.Net.Util
             }
             catch (Exception ex)
             {
-                // Print the stack trace so we have something to go on if an error occurs here.
-                Console.Write("An exception occurred during BeforeClass: ");
-                Console.WriteLine(ex.ToString());
-                throw;
+                // Write the stack trace so we have something to go on if an error occurs here.
+                throw new Exception($"An exception occurred during BeforeClass:\n{ex.ToString()}", ex);
             }
         }
 
@@ -757,10 +755,8 @@ namespace Lucene.Net.Util
             }
             catch (Exception ex)
             {
-                // Print the stack trace so we have something to go on if an error occurs here.
-                Console.Write("An exception occurred during AfterClass: ");
-                Console.WriteLine(ex.ToString());
-                throw;
+                // Write the stack trace so we have something to go on if an error occurs here.
+                throw new Exception($"An exception occurred during AfterClass:\n{ex.ToString()}", ex);
             }
         }