You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 22:11:27 UTC

[jira] [Created] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a "specialNode"

HierarchicalLedgerManager doesn't consider idgen as a "specialNode"
-------------------------------------------------------------------

                 Key: BOOKKEEPER-195
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-195
             Project: Bookkeeper
          Issue Type: Bug
            Reporter: Ivan Kelly
            Assignee: Ivan Kelly
             Fix For: 4.1.0


>From IRC: 

21:58 <johnnagro> 2012-03-28 05:15:19,669 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
21:58 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000106522
21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
21:58 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
21:58 <johnnagro> i will look for the gc one
21:59 <ivank> thats quite strange
22:00 <ivank> this occurred in the server?
22:02 <johnnagro> ah they may be related, this one has some GC stuff
22:02 <johnnagro> 012-03-24 09:17:34,419 - WARN  [GarbageCollectorThread:HierarchicalLedgerManager@376] - Exception during garbage collecting ledgers for idgen of /ledgers
22:02 <johnnagro> 2012-03-24 09:56:31,080 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
22:02 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000037474
22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
22:02 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
22:02 <johnnagro> this happened on the server, yes.


Looking into the code, it seems that HierarchicalLedgerManager doesn't consider idgen to be special. This is a race, between the idgen node being created and the znodes underneath being listed. The znodes underneath should never be listed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a "specialNode"

Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-195:
----------------------------------

    Attachment: BOOKKEEPER-195.diff

Fix is simple
                
> HierarchicalLedgerManager doesn't consider idgen as a "specialNode"
> -------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-195
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-195
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-195.diff
>
>
> From IRC: 
> 21:58 <johnnagro> 2012-03-28 05:15:19,669 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 21:58 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000106522
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 21:58 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 21:58 <johnnagro> i will look for the gc one
> 21:59 <ivank> thats quite strange
> 22:00 <ivank> this occurred in the server?
> 22:02 <johnnagro> ah they may be related, this one has some GC stuff
> 22:02 <johnnagro> 012-03-24 09:17:34,419 - WARN  [GarbageCollectorThread:HierarchicalLedgerManager@376] - Exception during garbage collecting ledgers for idgen of /ledgers
> 22:02 <johnnagro> 2012-03-24 09:56:31,080 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 22:02 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000037474
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 22:02 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 22:02 <johnnagro> this happened on the server, yes.
> Looking into the code, it seems that HierarchicalLedgerManager doesn't consider idgen to be special. This is a race, between the idgen node being created and the znodes underneath being listed. The znodes underneath should never be listed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a "specialNode"

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240793#comment-13240793 ] 

Hudson commented on BOOKKEEPER-195:
-----------------------------------

Integrated in bookkeeper-trunk #430 (See [https://builds.apache.org/job/bookkeeper-trunk/430/])
    BOOKKEEPER-195: HierarchicalLedgerManager doesn't consider idgen as a "specialNode" (ivank) (Revision 1306616)

     Result = ABORTED
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java

                
> HierarchicalLedgerManager doesn't consider idgen as a "specialNode"
> -------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-195
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-195
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-195.diff, BOOKKEEPER-195.diff
>
>
> From IRC: 
> 21:58 <johnnagro> 2012-03-28 05:15:19,669 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 21:58 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000106522
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 21:58 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 21:58 <johnnagro> i will look for the gc one
> 21:59 <ivank> thats quite strange
> 22:00 <ivank> this occurred in the server?
> 22:02 <johnnagro> ah they may be related, this one has some GC stuff
> 22:02 <johnnagro> 012-03-24 09:17:34,419 - WARN  [GarbageCollectorThread:HierarchicalLedgerManager@376] - Exception during garbage collecting ledgers for idgen of /ledgers
> 22:02 <johnnagro> 2012-03-24 09:56:31,080 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 22:02 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000037474
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 22:02 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 22:02 <johnnagro> this happened on the server, yes.
> Looking into the code, it seems that HierarchicalLedgerManager doesn't consider idgen to be special. This is a race, between the idgen node being created and the znodes underneath being listed. The znodes underneath should never be listed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a "specialNode"

Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-195:
----------------------------------

    Attachment: BOOKKEEPER-195.diff
    
> HierarchicalLedgerManager doesn't consider idgen as a "specialNode"
> -------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-195
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-195
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-195.diff, BOOKKEEPER-195.diff
>
>
> From IRC: 
> 21:58 <johnnagro> 2012-03-28 05:15:19,669 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 21:58 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000106522
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 21:58 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 21:58 <johnnagro> i will look for the gc one
> 21:59 <ivank> thats quite strange
> 22:00 <ivank> this occurred in the server?
> 22:02 <johnnagro> ah they may be related, this one has some GC stuff
> 22:02 <johnnagro> 012-03-24 09:17:34,419 - WARN  [GarbageCollectorThread:HierarchicalLedgerManager@376] - Exception during garbage collecting ledgers for idgen of /ledgers
> 22:02 <johnnagro> 2012-03-24 09:56:31,080 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 22:02 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000037474
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 22:02 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 22:02 <johnnagro> this happened on the server, yes.
> Looking into the code, it seems that HierarchicalLedgerManager doesn't consider idgen to be special. This is a race, between the idgen node being created and the znodes underneath being listed. The znodes underneath should never be listed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-195) HierarchicalLedgerManager doesn't consider idgen as a "specialNode"

Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240750#comment-13240750 ] 

Flavio Junqueira commented on BOOKKEEPER-195:
---------------------------------------------

+1, looks good to me.
                
> HierarchicalLedgerManager doesn't consider idgen as a "specialNode"
> -------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-195
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-195
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-195.diff, BOOKKEEPER-195.diff
>
>
> From IRC: 
> 21:58 <johnnagro> 2012-03-28 05:15:19,669 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 21:58 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000106522
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 21:58 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 21:58 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 21:58 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 21:58 <johnnagro> i will look for the gc one
> 21:59 <ivank> thats quite strange
> 22:00 <ivank> this occurred in the server?
> 22:02 <johnnagro> ah they may be related, this one has some GC stuff
> 22:02 <johnnagro> 012-03-24 09:17:34,419 - WARN  [GarbageCollectorThread:HierarchicalLedgerManager@376] - Exception during garbage collecting ledgers for idgen of /ledgers
> 22:02 <johnnagro> 2012-03-24 09:56:31,080 - ERROR [main-EventThread:AbstractZkLedgerManager$2@105] - Error polling ZK for the available ledger nodes: 
> 22:02 <johnnagro> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /ledgers/idgen/ID-0000037474
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> 22:02 <johnnagro>         at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> 22:02 <johnnagro>         at org.apache.bookkeeper.meta.AbstractZkLedgerManager$2.processResult(AbstractZkLedgerManager.java:105)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:594)
> 22:02 <johnnagro>         at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:497)
> 22:02 <johnnagro> this happened on the server, yes.
> Looking into the code, it seems that HierarchicalLedgerManager doesn't consider idgen to be special. This is a race, between the idgen node being created and the znodes underneath being listed. The znodes underneath should never be listed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira