You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/05/07 22:40:03 UTC

Re: Review Request 33718: Extended documentation on Mesos hooks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/
-----------------------------------------------------------

(Updated May 7, 2015, 8:40 p.m.)


Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.


Changes
-------

+mesos


Bugs: MESOS-2680
    https://issues.apache.org/jira/browse/MESOS-2680


Repository: mesos


Description
-------

Mentions necessary flags and adds a usage example.


Diffs
-----

  docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 

Diff: https://reviews.apache.org/r/33718/diff/


Testing
-------

none: docs update.

@Adam: as a native speaker, do you mind checking the language?


Thanks,

Alexander Rukletsov

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote:
> > Have you rendered this in a markdown viewer? As far as I know, the code block won't render if you don't have a preceeding newline

I have and it was OK, but you're right and it's not consistent with the rest of the doc, I'll change that.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review82908
-----------------------------------------------------------


On May 8, 2015, 11:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Till Toenshoff <to...@me.com>.

> On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote:
> > docs/modules.md, line 149
> > <https://reviews.apache.org/r/33718/diff/2/?file=952571#file952571line149>
> >
> >     s/config/configuration file/?

It does not have to be a file, hence I would suggest "configuration".


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review82908
-----------------------------------------------------------


On May 7, 2015, 8:40 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review82908
-----------------------------------------------------------

Ship it!


Have you rendered this in a markdown viewer? As far as I know, the code block won't render if you don't have a preceeding newline


docs/modules.md
<https://reviews.apache.org/r/33718/#comment133741>

    --hooks :) not --hook



docs/modules.md
<https://reviews.apache.org/r/33718/#comment133742>

    s/config/configuration file/?


- Niklas Nielsen


On May 7, 2015, 1:40 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 1:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review83074
-----------------------------------------------------------



docs/modules.md
<https://reviews.apache.org/r/33718/#comment133941>

    I would like to propose using two terms for making clear the specific roles of those flags.
    
    `--modules` is there for __introducing__ any module (name, location and parameters) to mesos.
    
    `--hooks` is there for __selecting__ a specific module as a hooks module.
    
    Hence my clumpsy attempt to reword:
    
    For introducing any module to mesos, you need to specify its name via the `--modules` flag configuration. For selecting that module as a hook module, you will have to additionally specify it via the `--hooks` flag.



docs/modules.md
<https://reviews.apache.org/r/33718/#comment133942>

    s/5050/<PORT>/
    
    s/--work_dir=s\/work//


- Till Toenshoff


On May 7, 2015, 8:40 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review82913
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33718]

All tests passed.

- Mesos ReviewBot


On May 7, 2015, 8:40 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review83364
-----------------------------------------------------------

Ship it!


Looks great! Sorry I was so slow. Didn't realize it would be so short.


docs/modules.md
<https://reviews.apache.org/r/33718/#comment134341>

    Does it get loaded too by --modules, even if it's not selected by --hooks? If so, I would say "load it" instead of "introduce it". If not, "introduce" seems like a perfect term.


- Adam B


On May 8, 2015, 4:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review83117
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33718]

All tests passed.

- Mesos ReviewBot


On May 8, 2015, 11:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33718/
> -----------------------------------------------------------
> 
> (Updated May 8, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2680
>     https://issues.apache.org/jira/browse/MESOS-2680
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentions necessary flags and adds a usage example.
> 
> 
> Diffs
> -----
> 
>   docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 
> 
> Diff: https://reviews.apache.org/r/33718/diff/
> 
> 
> Testing
> -------
> 
> none: docs update.
> 
> @Adam: as a native speaker, do you mind checking the language?
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 33718: Extended documentation on Mesos hooks.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/
-----------------------------------------------------------

(Updated May 8, 2015, 11:19 p.m.)


Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Till Toenshoff.


Changes
-------

Addressed comments.


Bugs: MESOS-2680
    https://issues.apache.org/jira/browse/MESOS-2680


Repository: mesos


Description
-------

Mentions necessary flags and adds a usage example.


Diffs (updated)
-----

  docs/modules.md a8b471541cdfa584eeb89fbe96643f93c712cfd4 

Diff: https://reviews.apache.org/r/33718/diff/


Testing
-------

none: docs update.

@Adam: as a native speaker, do you mind checking the language?


Thanks,

Alexander Rukletsov