You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2020/06/29 21:33:00 UTC

[jira] [Closed] (MSHADE-321) Always respect 'createDependencyReducedPom' flag

     [ https://issues.apache.org/jira/browse/MSHADE-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov closed MSHADE-321.
---------------------------------
    Resolution: Fixed

Fixed with [6ea8543b8b380bd4ebc0e876970957426bb46808|https://gitbox.apache.org/repos/asf?p=maven-shade-plugin.git;a=commit;h=6ea8543b8b380bd4ebc0e876970957426bb46808].

> Always respect 'createDependencyReducedPom' flag
> ------------------------------------------------
>
>                 Key: MSHADE-321
>                 URL: https://issues.apache.org/jira/browse/MSHADE-321
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.1
>            Reporter: Ilya Cherkasov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.3.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> h3.  
> Dependency reduced pom (DRP) is generated only if resulting shaded artifact was 'renamed'
> https://github.com/apache/maven-shade-plugin/blob/dbd2a5c04619da76559c61c58755e7062fb8fab9/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java#L536
> However, the documentation regarding DRP states:
> {code:java}
> Flag whether to generate a simplified POM for the shaded artifact. If set to true, dependencies that have been included into the uber JAR will be removed from the <dependencies> section of the generated POM. The reduced POM will be named dependency-reduced-pom.xml and is stored into the same directory as the shaded artifact. Unless you also specify dependencyReducedPomLocation, the plugin will create a temporary file named dependency-reduced-pom.xml in the project basedir.
> Default value is: true.{code}
> It's not stating any changes in this flag behavior, by this hiding the conditions upon which DRP would be generated.
> This should be fixed, and DRP should be generated whenever the flag is being set to 'true'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)