You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/07/18 02:58:48 UTC

[GitHub] [activemq-artemis] jbertram opened a new pull request, #4152: ARTEMIS-1964 fix and deprecate getNumberOfMessages() on AddressControl

jbertram opened a new pull request, #4152:
URL: https://github.com/apache/activemq-artemis/pull/4152

   AddressControl has 2 methods to get same metric. Both
   getNumberOfMessages() and getMessageCount() return the same metric
   albeit in different ways.
   
   Also, getNumberOfMessages() inspects both "local" and "remote" queue
   bindings which is wrong.
   
   This commit fixes these issues via the following changes:
   
    - Deprecate getNumberOfMessages().
    - Change getNumberOfMessages() to invoke getMessageCount().
    - Add a test to ensure getNumberOfMessages() does not count remote
   queue bindings.
    - Simplify getMessageCount(DurabilityType).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #4152: ARTEMIS-1964 fix and deprecate getNumberOfMessages() on AddressControl

Posted by GitBox <gi...@apache.org>.

clebertsuconic merged PR #4152:
URL: https://github.com/apache/activemq-artemis/pull/4152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org