You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/05 10:15:57 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
tillrohrmann opened a new pull request #11994:
URL: https://github.com/apache/flink/pull/11994
## What is the purpose of the change
This PR hardens the `TaskCancelerWatchDog` to properly fail the task fatally.
## Brief change log
* 59fee01 *Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause*: In order to avoid NPE we have to call TaskManagerActions.notifyFatalError with non-null arguments. This commit changes the behaviour accordingly.
*2ae3c56 *Fail fatally if the TaskCancelerWatchDog encounters exception in run method*: If the TaskCancelerWatchDog encounters an exception in the run method, then we can no longer guarantee that it will do its job. Hence, it is best to fail fatally by letting the exception bubble up so that it is handled by the uncaught exception handler.
* 9b71bd6 *Harden ExceptionUtils.tryEnrichTaskManagerError, .isMetaspaceOutOfMemoryError and .isDirectOutOfMemoryError to handle null values*: Error handling code should not fail. Hence, this commit changes the methods ExceptionUtils.tryEnrichTaskManagerError, ExceptionUtils.isMetaspaceOutOfMemoryError and ExceptionUtils.isDirectOutOfMemoryError to properly handle a null argument.
## Verifying this change
Modified `TaskTest#testFatalErrorAfterUnInterruptibleInvoke` and `TaskTest#testFatalErrorOnCanceling` to test that fatal error cause is non-null.
Added tests to `ExceptionUtils` which verify that the `#tryEnrichTaskManagerError`, `#isMetaspaceOutOfMemoryError` and `#isDirectOutOfMemoryError` can handle null values.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420180469
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -855,7 +862,8 @@ public void testFatalErrorOnCanceling() throws Exception {
task.cancelExecution();
// wait for the notification of notifyFatalError
- taskManagerActions.latch.await();
+ final Throwable fatalError = fatalErrorFuture.join();
+ assertThat(fatalError, instanceOf(fatalErrorType));
} catch (Throwable t) {
fail("No exception is expected to be thrown by fatal error handling");
Review comment:
True. I will refactor the test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420139082
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -855,7 +862,8 @@ public void testFatalErrorOnCanceling() throws Exception {
task.cancelExecution();
// wait for the notification of notifyFatalError
- taskManagerActions.latch.await();
+ final Throwable fatalError = fatalErrorFuture.join();
+ assertThat(fatalError, instanceOf(fatalErrorType));
} catch (Throwable t) {
fail("No exception is expected to be thrown by fatal error handling");
Review comment:
Explicitly failing the test seems unnecessarily verbose.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1552,8 +1553,7 @@ public void run() {
if (executerThread.isAlive()) {
String msg = "Task did not exit gracefully within " + (timeoutMillis / 1000) + " + seconds.";
- log.error(msg);
Review comment:
`log` is now unused.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1557,8 +1557,7 @@ public void run() {
}
}
catch (Throwable t) {
Review comment:
Is it even necessary to catch `Throwable` and rethrow it as a `FlinkRuntimeException`? We are already handling all checked exceptions. Therefore the code would compile without the `try-catch` block and even do something similar.
##########
File path: flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java
##########
@@ -132,31 +132,39 @@ public static boolean isJvmFatalOrOutOfMemoryError(Throwable t) {
}
/**
- * Generates new {@link OutOfMemoryError} with more detailed message.
+ * Tries to enrich the passed exception with additional information.
*
* <p>This method improves error message for direct and metaspace {@link OutOfMemoryError}.
* It adds description of possible causes and ways of resolution.
*
* @param exception The exception to enrich.
* @return either enriched exception if needed or the original one.
*/
- public static Throwable enrichTaskManagerOutOfMemoryError(Throwable exception) {
- if (isMetaspaceOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_METASPACE_OOM_ERROR_MESSAGE);
- } else if (isDirectOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_DIRECT_OOM_ERROR_MESSAGE);
+ public static Throwable tryEnrichTaskManagerError(Throwable exception) {
Review comment:
Maybe add `@Nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623985849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b71bd65ecb716856504f2b0748f098934e2203f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623985849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618",
"triggerID" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"triggerType" : "PUSH"
}, {
"hash" : "fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=636",
"triggerID" : "fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b71bd65ecb716856504f2b0748f098934e2203f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618)
* fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=636)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623985849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618",
"triggerID" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"triggerType" : "PUSH"
}, {
"hash" : "fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=636",
"triggerID" : "fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=636)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623985849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618",
"triggerID" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"triggerType" : "PUSH"
}, {
"hash" : "fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b71bd65ecb716856504f2b0748f098934e2203f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618)
* fc4c65780dec4eff4b3d98ff04e7e14c15d8a8b1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623985849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618",
"triggerID" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b71bd65ecb716856504f2b0748f098934e2203f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420185255
##########
File path: flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java
##########
@@ -132,31 +132,39 @@ public static boolean isJvmFatalOrOutOfMemoryError(Throwable t) {
}
/**
- * Generates new {@link OutOfMemoryError} with more detailed message.
+ * Tries to enrich the passed exception with additional information.
*
* <p>This method improves error message for direct and metaspace {@link OutOfMemoryError}.
* It adds description of possible causes and ways of resolution.
*
* @param exception The exception to enrich.
* @return either enriched exception if needed or the original one.
*/
- public static Throwable enrichTaskManagerOutOfMemoryError(Throwable exception) {
- if (isMetaspaceOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_METASPACE_OOM_ERROR_MESSAGE);
- } else if (isDirectOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_DIRECT_OOM_ERROR_MESSAGE);
+ public static Throwable tryEnrichTaskManagerError(Throwable exception) {
Review comment:
Good point. I will add it. First I thought I would like to avoid encouraging the usage of this method with `null` values but actually it is not a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-624116893
Thanks for the review @GJL. I've addressed your comments. Merging once AZP gives green light.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL commented on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
GJL commented on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623986488
@TisonKun misclicked your username.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420184653
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1557,8 +1557,7 @@ public void run() {
}
}
catch (Throwable t) {
Review comment:
You are right. The motivation for catching the throwable and wrapping it in a `FlinkRuntimeException` was to add the exception message `Error in Task Cancellation Watch Dog`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420179178
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1552,8 +1553,7 @@ public void run() {
if (executerThread.isAlive()) {
String msg = "Task did not exit gracefully within " + (timeoutMillis / 1000) + " + seconds.";
- log.error(msg);
Review comment:
Good point. I will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420156565
##########
File path: flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java
##########
@@ -132,31 +132,39 @@ public static boolean isJvmFatalOrOutOfMemoryError(Throwable t) {
}
/**
- * Generates new {@link OutOfMemoryError} with more detailed message.
+ * Tries to enrich the passed exception with additional information.
*
* <p>This method improves error message for direct and metaspace {@link OutOfMemoryError}.
* It adds description of possible causes and ways of resolution.
*
* @param exception The exception to enrich.
* @return either enriched exception if needed or the original one.
*/
- public static Throwable enrichTaskManagerOutOfMemoryError(Throwable exception) {
- if (isMetaspaceOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_METASPACE_OOM_ERROR_MESSAGE);
- } else if (isDirectOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_DIRECT_OOM_ERROR_MESSAGE);
+ public static Throwable tryEnrichTaskManagerError(Throwable exception) {
Review comment:
Maybe add `@Nullable` to the parameter and method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623972166
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9b71bd65ecb716856504f2b0748f098934e2203f (Tue May 05 10:19:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL edited a comment on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
GJL edited a comment on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623986488
@TisonKun, I misclicked your username.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] GJL commented on a change in pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11994:
URL: https://github.com/apache/flink/pull/11994#discussion_r420156565
##########
File path: flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java
##########
@@ -132,31 +132,39 @@ public static boolean isJvmFatalOrOutOfMemoryError(Throwable t) {
}
/**
- * Generates new {@link OutOfMemoryError} with more detailed message.
+ * Tries to enrich the passed exception with additional information.
*
* <p>This method improves error message for direct and metaspace {@link OutOfMemoryError}.
* It adds description of possible causes and ways of resolution.
*
* @param exception The exception to enrich.
* @return either enriched exception if needed or the original one.
*/
- public static Throwable enrichTaskManagerOutOfMemoryError(Throwable exception) {
- if (isMetaspaceOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_METASPACE_OOM_ERROR_MESSAGE);
- } else if (isDirectOutOfMemoryError(exception)) {
- return changeOutOfMemoryErrorMessage(exception, TM_DIRECT_OOM_ERROR_MESSAGE);
+ public static Throwable tryEnrichTaskManagerError(Throwable exception) {
Review comment:
Maybe add `@Nullable` to the parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11994: [FLINK-17514] Let TaskCancelerWatchDog call TaskManagerActions.notifyFatalError with non-null cause
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11994:
URL: https://github.com/apache/flink/pull/11994#issuecomment-623985849
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618",
"triggerID" : "9b71bd65ecb716856504f2b0748f098934e2203f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b71bd65ecb716856504f2b0748f098934e2203f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=618)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org