You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/24 15:32:40 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold
dongjoon-hyun commented on a change in pull request #28328:
URL: https://github.com/apache/spark/pull/28328#discussion_r414667691
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
##########
@@ -869,4 +869,15 @@ class ColumnExpressionSuite extends QueryTest with SharedSparkSession {
df.select(typedLit(("a", 2, 1.0))),
Row(Row("a", 2, 1.0)) :: Nil)
}
+
+ test("SPARK-31553: isInCollection for collection sizes above a threshold") {
Review comment:
Thank you, @MaxGekk .
cc @aokolnychyi and @dbtsai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org