You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/11 17:24:06 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23649: fix: Zero values on Dual Line axis bounds
michael-s-molina opened a new pull request, #23649:
URL: https://github.com/apache/superset/pull/23649
### SUMMARY
Fix a bug that prevented a user from using zero values on Dual Line chart axis bounds.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/231240813-94355447-2575-4bfa-ad08-68d7a21fffce.mov
https://user-images.githubusercontent.com/70410625/231240873-948ec412-cb38-4edd-ae8f-32221ae515e6.mov
### TESTING INSTRUCTIONS
Check the videos for instructions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23649: fix: Zero values on Dual Line axis bounds
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23649:
URL: https://github.com/apache/superset/pull/23649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23649: fix: Zero values on Dual Line axis bounds
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23649:
URL: https://github.com/apache/superset/pull/23649#issuecomment-1503880343
## [Codecov](https://codecov.io/gh/apache/superset/pull/23649?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23649](https://codecov.io/gh/apache/superset/pull/23649?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ab3d04) into [master](https://codecov.io/gh/apache/superset/commit/825006d90656f4955e71062803fbcb7ef7fb5659?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (825006d) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2ab3d04 differs from pull request most recent head 51ea60b. Consider uploading reports for the commit 51ea60b to get more accurate results
```diff
@@ Coverage Diff @@
## master #23649 +/- ##
=======================================
Coverage 67.93% 67.93%
=======================================
Files 1918 1918
Lines 73891 73891
Branches 8058 8058
=======================================
Hits 50199 50199
Misses 21633 21633
Partials 2059 2059
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.89% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js](https://codecov.io/gh/apache/superset/pull/23649?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNWaXMuanM=) | `0.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #23649: fix: Zero values on Dual Line axis bounds
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #23649:
URL: https://github.com/apache/superset/pull/23649#discussion_r1164648680
##########
superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js:
##########
@@ -844,12 +844,14 @@ function nvd3Vis(element, props) {
}
chart.yDomain1([
- yAxisBounds[0] || ticks1[0],
- yAxisBounds[1] || ticks1[ticks1.length - 1],
+ isDefined(yAxisBounds[0]) ? yAxisBounds[0] : ticks1[0],
Review Comment:
nit: how about using [nullish coalescing operator](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing)?
```suggestion
yAxisBounds[0] ?? ticks1[0],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org