You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/05 00:06:49 UTC
[GitHub] [incubator-yunikorn-k8shim] ronazhan opened a new pull request #214: Add port-forward loop and remove unnecessary test output
ronazhan opened a new pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ayubpathan commented on pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
ayubpathan commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214#issuecomment-755779120
LGTM.
@yangwwei Could you please help merge this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214#issuecomment-755658859
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=desc) (68e2e44) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/2432d4dd9604107dec57e48e704f5f61ade77143?el=desc) (2432d4d) will **decrease** coverage by `0.34%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 57.78% 57.43% -0.35%
==========================================
Files 32 32
Lines 2859 2859
==========================================
- Hits 1652 1642 -10
- Misses 1138 1147 +9
- Partials 69 70 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `66.97% <0.00%> (-4.66%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=footer). Last update [2432d4d...68e2e44](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214#issuecomment-755093875
hi @ronazhan , https://issues.apache.org/jira/browse/YUNIKORN-499 now has been fixed, could you please update the dependency by using
```
go get github.com/apache/incubator-yunikorn-core@master
```
and update this PR? The UT failure should be gone in the next run. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214#issuecomment-754973037
> @yangwwei The build seems to be failing. Is this due to an existing issue?
Correct. There is a data race tracked in https://issues.apache.org/jira/browse/YUNIKORN-499. I am working on a fix for this. We can retrigger the build once that is fixed. In the meantime, can you help to review the changes in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214#issuecomment-754922741
The UT failure is not from this PR, created https://issues.apache.org/jira/browse/YUNIKORN-499 to check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] ayubpathan commented on pull request #214: [YUNIKORN-496] Add port-forward loop and remove unnecessary test output
Posted by GitBox <gi...@apache.org>.
ayubpathan commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/214#issuecomment-754970901
@yangwwei The build seems to be failing. Is this due to an existing issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org