You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/05/22 15:11:58 UTC

[Bug 119400] New: Undo in the BASIC editor in the IDE garbles code (regression)

https://issues.apache.org/ooo/show_bug.cgi?id=119400

          Priority: P3
            Bug ID: 119400
          Assignee: ooo-issues@incubator.apache.org
           Summary: Undo in the BASIC editor in the IDE garbles code
                    (regression)
          Severity: normal
        Issue Type: DEFECT
    Classification: Code
                OS: All
          Reporter: donjaime@freenet.de
          Hardware: PC
            Status: CONFIRMED
           Version: OOo 3.4 Beta
         Component: code
           Product: scripting

In OO 3.4.0 undoing edits in the IDE leaves a horrible mix of recent additions
and deletions.

For example if you do the following:

1. create a new Macro in a new module in a new file
2. type "fruitbat"
3. select "fruitbat"
4. type "aardvark"
5. hit ctrl-Z

you will see "fruitbataardvark".

While fixing this, it would be useful to have ctrl-Y bound to 'Redo' as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

binguo <bi...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |binbjguo@gmail.com

--- Comment #11 from binguo <bi...@gmail.com> ---
This bug can repros on AOO3.4.O Rev. 1327774,
and I change the status from Unconfirmed to confirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

T. J. Frazier <tj...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tj@apache.org

--- Comment #4 from T. J. Frazier <tj...@apache.org> ---
Confirmed under 3.4 Beta on WV. That should narrow the search.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

--- Comment #7 from hanya <ha...@gmail.com> ---
I forgot to mention about the patch above, comment 6.

When I push key to input a charactor in focused text field (multi-lined), 
TextEngine::ImpInsertText method in main/svtools/source/edit/texteng.cxx is
called. 
In the method, bTryMerge is true for InsertUndo( pNewUndo, bTryMerge ) call for 
first key input. 
pMergeWithAction is NULL for first input in
SfxUndoManager::ImplAddUndoAction_NoNotify method. So, the action is abandoned
at the if statement and not tracked.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

hanya <ha...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hanya.runo@gmail.com

--- Comment #2 from hanya <ha...@gmail.com> ---
I could confirm on AOO 3.4.0, Linux (Xubuntu 12.01) 32bit and Xfce 4.8. 
It works on OOo 3.3.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

--- Comment #8 from hanya <ha...@gmail.com> ---
Created attachment 77735
  --> https://issues.apache.org/ooo/attachment.cgi?id=77735&action=edit
Proposed patch to fix this problem

I met the same problem in these edit context: 
- Input line of Calc
- Multi line text field of dialogs
- Text editing in drawing object

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orw@apache.org

--- Comment #12 from Oliver-Rainer Wittmann <or...@apache.org> ---
I am volunteering to review the proposed patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

bmarcelly <ma...@club-internet.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcelly@club-internet.fr

--- Comment #1 from bmarcelly <ma...@club-internet.fr> ---
Ctrl-Z works for me.
OpenOffice.org 3.3.0  OOO330m20 on Windows XP

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Undo in the BASIC editor in |Undo broken in several
                   |the IDE garbles code        |contexts (Basic Editor,
                   |(regression)                |Math Editor, Calc Input
                   |                            |Line, MultiLine controls,
                   |                            |etc)

--- Comment #10 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #8)
> Created attachment 77735 [details]
> Proposed patch to fix this problem
> 
> I met the same problem in these edit context: 
> - Input line of Calc
> - Multi line text field of dialogs
> - Text editing in drawing object

It also happens on Math.
Adjusting the subject to reflect this "brokenness" everywhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

--- Comment #3 from bmarcelly <ma...@club-internet.fr> ---
Sorry for my previous comment. I mixed up versions! Confirmed with 3.4.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

--- Comment #5 from hanya <ha...@gmail.com> ---
This undo problem is not only on Basic IDE. I met the same problem on 
HTML source window and multi-line text field on basic dialog. 
It seems edit engine has such problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

hanya <ha...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |3.4.1_release_blocker?

--- Comment #9 from hanya <ha...@gmail.com> ---
Could it be a release blocker for 3.4.1 and included in 3.4.1?

-- 
You are receiving this mail because:
You are the assignee for the bug.

3.4.1_release_blocker requested: [Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
hanya <ha...@gmail.com> has asked	for 3.4.1_release_blocker:
Bug 119400: Undo in the BASIC editor in the IDE garbles code (regression)
https://issues.apache.org/ooo/show_bug.cgi?id=119400


------- Additional Comments from hanya <ha...@gmail.com>
Could it be a release blocker for 3.4.1 and included in 3.4.1?

[Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ooo-issues@incubator.apache |orw@apache.org
                   |.org                        |

--- Comment #13 from Oliver-Rainer Wittmann <or...@apache.org> ---
Patch looks good.
Taking over this issue for integration of the patch.

I also agree to solve this issue for AOO 3.4.1 -> I will send a corresponding
request to ooo-dev

-- 
You are receiving this mail because:
You are the assignee for the bug.

3.4.1_release_blocker requested: [Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has asked  for 3.4.1_release_blocker:
Bug 119400: Undo broken in several contexts (Basic Editor, Math Editor, Calc
Input Line, MultiLine controls, etc)
https://issues.apache.org/ooo/show_bug.cgi?id=119400


------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
commited patch on branch AOO34 - change file:
svl/source/undo/undo.cxx, revision 1350569

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

--- Comment #6 from hanya <ha...@gmail.com> ---
Hm, input line of Calc has the same problem.

I thought the problem is there in undo action of overwrite selection but I
noticed 
input events through keyboard are not tracked as undo action.

The following patch is influenced to svl, so it is widely used in the code, it
should be well tested.

Index: svl/source/undo/undo.cxx
===================================================================
--- svl/source/undo/undo.cxx    (revision 1342285)
+++ svl/source/undo/undo.cxx    (working copy)
@@ -627,7 +627,7 @@
     // merge, if required
     SfxUndoAction* pMergeWithAction = m_pData->pActUndoArray->nCurUndoAction ?
        
m_pData->pActUndoArray->aUndoActions[m_pData->pActUndoArray->nCurUndoAction-1].pAction
: NULL;
-    if ( bTryMerge && ( !pMergeWithAction || !pMergeWithAction->Merge( pAction
) ) )
+    if ( bTryMerge && ( pMergeWithAction && pMergeWithAction->Merge( pAction )
) )
     {
         i_guard.markForDeletion( pAction );
         return false;

-- 
You are receiving this mail because:
You are the assignee for the bug.

3.4.1_release_blocker granted: [Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
jsc@apache.org has granted hanya <ha...@gmail.com>'s request for
3.4.1_release_blocker:
Bug 119400: Undo broken in several contexts (Basic Editor, Math Editor, Calc
Input Line, MultiLine controls, etc)
https://issues.apache.org/ooo/show_bug.cgi?id=119400


------- Additional Comments from jsc@apache.org
set release blocker flag

3.4.1_release_blocker granted: [Bug 119400] Undo broken in several contexts (Basic Editor, Math Editor, Calc Input Line, MultiLine controls, etc)

Posted by bu...@apache.org.
jsc@apache.org has granted Oliver-Rainer Wittmann <or...@apache.org>'s request
for 3.4.1_release_blocker:
Bug 119400: Undo broken in several contexts (Basic Editor, Math Editor, Calc
Input Line, MultiLine controls, etc)
https://issues.apache.org/ooo/show_bug.cgi?id=119400


------- Additional Comments from jsc@apache.org
set release blocker flag for 3.4.1

[Bug 119400] Undo in the BASIC editor in the IDE garbles code (regression)

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119400

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arielch@apache.org
         Issue Type|DEFECT                      |PATCH

-- 
You are receiving this mail because:
You are the assignee for the bug.