You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/12/02 11:22:02 UTC
[GitHub] [dubbo-go] PhilYue commented on a change in pull request #1631: Fix: attachments maybe nil or empty string
PhilYue commented on a change in pull request #1631:
URL: https://github.com/apache/dubbo-go/pull/1631#discussion_r760998845
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -254,7 +254,7 @@ func unmarshalRequestBody(body []byte, p *DubboPackage) error {
return perrors.WithStack(err)
}
- if attachments == nil {
+ if attachments == nil || attachments == "" {
Review comment:
len 不支持， attachments 类型是 interface{}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org