[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #21: Add support for building log4cxx as a statically linked library on Windows

[GitBox <gi...@apache.org>]

ams-tschoening commented on a change in pull request #21: Add support for building log4cxx as a statically linked library on Windows
URL: https://github.com/apache/logging-log4cxx/pull/21#discussion_r390155388
 
 

 ##########
 File path: src/site/apt/building/cmake.apt
 ##########
 @@ -50,6 +50,12 @@ $ sudo make install
 *------------------------+---------------------------------------------------------------------------------------------+
 | -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.|
 |                        | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC.             |
+*------------------------+---------------------------------------------------------------------------------------------+
+| -DAPU_STATIC           | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the|
 
 Review comment:
   Any reason why `-DAPU_STATIC` and `-DAPR_STATIC` are not documented with something like `=off|on` , like `-DBUILD_SHARED_LIBS` is? Does this work differently or ...?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services