[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #15568: [PIP-150][improve][broker] Support read the message of startMessageId position on the broker side

[GitBox <gi...@apache.org>]

BewareMyPower commented on code in PR #15568:
URL: https://github.com/apache/pulsar/pull/15568#discussion_r908116593


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java:
##########
@@ -242,11 +242,13 @@ ManagedCursor openCursor(String name, InitialPosition initialPosition) throws In
      *             operation will trigger the creation of the cursor.
      * @param cursorProperties
      *            the properties for the Cursor
+     * @param inclusive
+     *            whether to read from the specified position
      * @return the ManagedCursor
      * @throws ManagedLedgerException
      */
     ManagedCursor openCursor(String name, InitialPosition initialPosition, Map<String, Long> properties,

Review Comment:
   Could you add default override methods for compatibility? Because they are common APIs that can be used by other components like protocol handler.
   
   e.g.
   
   ```java
       default void asyncOpenCursor(String name, InitialPosition initialPosition, Map<String, Long> properties,
                            Map<String, String> cursorProperties, OpenCursorCallback callback, Object ctx) {
           asyncOpenCursor(name, initialPosition, properties, cursorProperties, false, callback, ctx);
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org