[GitHub] [httpcomponents-core] garydgregory commented on a change in pull request #177: HTTPCORE-617: removed references to specific RFC documents

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#discussion_r361850936
 
 

 ##########
 File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
 ##########
 @@ -49,35 +47,35 @@
 public interface HttpStatus {
 
 Review comment:
   We should NOT be using an interface to define constants, this should be a class. That's a class Effective Java item ;-) If this PR gets merged without that change. I can provide a separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org