You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/28 10:42:31 UTC
[GitHub] [airflow] potiuk opened a new pull request #12684: Setup.cfg change triggers full build
potiuk opened a new pull request #12684:
URL: https://github.com/apache/airflow/pull/12684
Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12684: Setup.cfg change triggers full build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12684:
URL: https://github.com/apache/airflow/pull/12684#issuecomment-735219731
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12684: Setup.cfg change triggers full build
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12684:
URL: https://github.com/apache/airflow/pull/12684#issuecomment-735220479
> Whops, thought I did this.
>
> Clearly not
Probably only in Breeze. This one is a selective check in CI - and those are different criteria. For Breeze change in the file triggers the need for image build. For selective checks, it triggers "all tests"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12684: Setup.cfg change triggers full build
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12684:
URL: https://github.com/apache/airflow/pull/12684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12684: Setup.cfg change triggers full build
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12684:
URL: https://github.com/apache/airflow/pull/12684#issuecomment-735216749
@ashb - after the dependencies were moved to `setup.cfg` the setup.cfg should be added to "important" files triggering whole build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org