You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/07/27 03:04:59 UTC

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #311: modify antlr3 to support timeseries path in the number format

jt2594838 commented on a change in pull request #311: modify antlr3 to support timeseries path in the number format
URL: https://github.com/apache/incubator-iotdb/pull/311#discussion_r307950401
 
 

 ##########
 File path: server/src/main/antlr3/org/apache/iotdb/db/sql/parse/TSLexer.g
 ##########
 @@ -146,25 +146,51 @@ StringLiteral
     )
     ;
 
-//2016-11-16T16:22:33+0800
-DATETIME
-    : Digit+ (MINUS | DIVIDE | DOT) Digit+ (MINUS | DIVIDE | DOT) Digit+ ('T' | WS) Digit+ COLON Digit+ COLON Digit+ (DOT Digit+)? ((PLUS | MINUS) Digit+ COLON Digit+)?
-    ;
-
 NegativeInteger
     :
     '-' Digit+
     ;
 
-NonNegativeInteger
+PositiveInteger
+    :
+    '+' Digit+
+    ;
+
+NegativeFloat
+    :
+    '-' Digit+ DOT Digit+ (('e' | 'E') ('+'|'-')? Digit+)?
 
 Review comment:
   If one of the integer part and the decimal part is zero, it may be omitted, like ".5" or "3.". Should we support that too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services