You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2018/02/17 09:07:52 UTC

[incubator-plc4x] branch master updated: remove toString rendering from ByteValue as this might lead to non-printable chars in some output. Rather just print the length of array in this case.

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new e8b0b48  remove toString rendering from ByteValue as this might lead to non-printable chars in some output. Rather just print the length of array in this case.
e8b0b48 is described below

commit e8b0b482a9d883349341b8953e06b66e84718ba1
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Sat Feb 17 10:07:48 2018 +0100

    remove toString rendering from ByteValue as this might lead to
    non-printable chars in some output. Rather just print the length of array
    in this case.
---
 .../src/main/java/org/apache/plc4x/java/ads/api/util/ByteValue.java  | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/util/ByteValue.java b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/util/ByteValue.java
index 8e359c7..dd81cb5 100644
--- a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/util/ByteValue.java
+++ b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/util/ByteValue.java
@@ -81,8 +81,7 @@ public class ByteValue implements ByteReadable {
 
     @Override
     public String toString() {
-        return getClass().getSimpleName() + "{" +
-            "value=" + Arrays.toString(value) +
-            '}';
+        // TODO: maybe we could find a way to implement this to string
+        return getClass().getSimpleName() + "{value=" + value.length + "bytes}";
     }
 }

-- 
To stop receiving notification emails like this one, please contact
sruehl@apache.org.