[jira] [Commented] (FLINK-6780) ExternalTableSource should add time attributes in the row type

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030844#comment-16030844 ] 

ASF GitHub Bot commented on FLINK-6780:
---------------------------------------

GitHub user haohui opened a pull request:

    https://github.com/apache/flink/pull/4023

    [FLINK-6780] [table] ExternalTableSource should add time attributes in the row type

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/haohui/flink FLINK-6780

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4023
    
----
commit b06cf4f897dc37f1beb47f4bac38339fb22751ba
Author: Haohui Mai <wh...@apache.org>
Date:   2017-05-31T08:40:53Z

    [FLINK-6780] [table] ExternalTableSource should add time attributes in the row type.

----


> ExternalTableSource should add time attributes in the row type
> --------------------------------------------------------------
>
>                 Key: FLINK-6780
>                 URL: https://issues.apache.org/jira/browse/FLINK-6780
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>            Priority: Critical
>
> We observed that all streaming queries that refer to external tables fail when the Volcano planner converting {{LogicalTableScan}} to {{FlinkLogicalTableSourceScan}}:
> {noformat}
> Type mismatch:
> rowtype of new rel:
> RecordType(<table schema>, TIMESTAMP(3) NOT NULL proctime) NOT NULL
> rowtype of set:
> RecordType(<table schema>, ...) NOT NULL
> {noformat}
> Tables that are registered through {{StreamTableEnvironment#registerTableSource()}} do not suffer from this problem as {{StreamTableSourceTable}} adds the processing time / event time attribute automatically.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)