You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/06 01:04:59 UTC

[GitHub] [beam] kw2542 commented on a change in pull request #15280: [BEAM-12403][BEAM-12348] Add User State Support for Portable SamzaRunner

kw2542 commented on a change in pull request #15280:
URL: https://github.com/apache/beam/pull/15280#discussion_r683877320



##########
File path: runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
##########
@@ -112,8 +113,10 @@ public void translate(
             .collect(
                 Collectors.toMap(e -> e.getKey(), e -> ((PCollection<?>) e.getValue()).getCoder()));
 
-    boolean isStateful = DoFnSignatures.isStateful(transform.getFn());
-    final Coder<?> keyCoder = isStateful ? ((KvCoder<?, ?>) input.getCoder()).getKeyCoder() : null;
+    final Coder<?> keyCoder =
+        StateUtils.isStateful(transform.getFn())

Review comment:
       This logic to extract key coder from a class pipeline is only used here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org