You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/12 09:43:22 UTC
[GitHub] [superset] hughhhh opened a new pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
hughhhh opened a new pull request #14082:
URL: https://github.com/apache/superset/pull/14082
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fix flack test `tox -e py38-sqlite -vv -- tests/datasets/api_tests.py::TestDatasetApi::test_update_dataset_item_w_override_columns` to make sure the new column is in payload vs. being at a specific index
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.38% -0.14%
==========================================
Files 939 939
Lines 47571 47571
Branches 5949 5949
==========================================
- Hits 37831 37766 -65
- Misses 9618 9683 +65
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+0.02%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `80.74% <ø> (ø)` | |
| presto | `80.46% <ø> (+<0.01%)` | :arrow_up: |
| python | `81.04% <ø> (-0.27%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.69% <0.00%> (-0.25%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (+0.41%)` | :arrow_up: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.26% -0.27%
==========================================
Files 939 939
Lines 47571 47544 -27
Branches 5949 5949
==========================================
- Hits 37831 37685 -146
- Misses 9618 9737 +119
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+0.02%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `80.72% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.80% <ø> (-0.50%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `94.73% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.27% -0.26%
==========================================
Files 939 939
Lines 47571 47571
Branches 5949 5949
==========================================
- Hits 37831 37711 -120
- Misses 9618 9738 +120
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+0.02%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `80.74% <ø> (ø)` | |
| presto | `?` | |
| python | `80.82% <ø> (-0.49%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.24% <0.00%> (-1.70%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.83% <0.00%> (-0.13%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.31%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.21% -0.32%
==========================================
Files 939 939
Lines 47571 47544 -27
Branches 5949 5949
==========================================
- Hits 37831 37660 -171
- Misses 9618 9762 +144
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+0.02%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.70% <ø> (-0.60%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.32% <0.00%> (-6.46%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.98% <0.00%> (-1.96%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `1.24%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 78.28% -1.25%
==========================================
Files 939 939
Lines 47571 47571
Branches 5949 5949
==========================================
- Hits 37831 37240 -591
- Misses 9618 10181 +563
- Partials 122 150 +28
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.19% <ø> (-7.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-76.93%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 939 939
Lines 47571 47571
Branches 5949 5949
=======================================
+ Hits 37831 37833 +2
+ Misses 9618 9616 -2
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `100.00% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (59e42ae) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 59e42ae differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.22% -0.30%
==========================================
Files 939 939
Lines 47571 47544 -27
Branches 5949 5949
==========================================
- Hits 37831 37669 -162
- Misses 9618 9753 +135
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+0.02%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.74% <ø> (-0.56%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.32% <0.00%> (-6.46%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (b4fd594) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head b4fd594 differs from pull request most recent head fcc8166. Consider uploading reports for the commit fcc8166 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 939 939
Lines 47571 47571
Branches 5949 5949
=======================================
Hits 37831 37831
Misses 9618 9618
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (fcc8166) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.20% -0.33%
==========================================
Files 939 939
Lines 47571 47544 -27
Branches 5949 5949
==========================================
- Hits 37831 37657 -174
- Misses 9618 9765 +147
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| javascript | `69.34% <ø> (ø)` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.70% <ø> (-0.60%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.32% <0.00%> (-6.46%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.98% <0.00%> (-1.96%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #14082:
URL: https://github.com/apache/superset/pull/14082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (fcc8166) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.52% -0.01%
==========================================
Files 939 939
Lines 47571 47571
Branches 5949 5949
==========================================
- Hits 37831 37830 -1
- Misses 9618 9619 +1
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (-0.01%)` | :arrow_down: |
| javascript | `69.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <0.00%> (-1.06%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14082: fix: flacky test in test_update_dataset_item_w_override_columns
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14082:
URL: https://github.com/apache/superset/pull/14082#issuecomment-817674558
# [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=h1) Report
> Merging [#14082](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=desc) (fcc8166) into [master](https://codecov.io/gh/apache/superset/commit/d6bd1602507b05000c7112f241ded3bd9aea9244?el=desc) (d6bd160) will **decrease** coverage by `0.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14082 +/- ##
==========================================
- Coverage 79.52% 79.22% -0.31%
==========================================
Files 939 939
Lines 47571 47544 -27
Branches 5949 5949
==========================================
- Hits 37831 37666 -165
- Misses 9618 9756 +138
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.02% <ø> (-0.01%)` | :arrow_down: |
| hive | `?` | |
| javascript | `69.34% <ø> (ø)` | |
| mysql | `80.70% <ø> (ø)` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.74% <ø> (-0.56%)` | :arrow_down: |
| sqlite | `80.34% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.32% <0.00%> (-6.46%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.22% <0.00%> (-1.72%)` | :arrow_down: |
| [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <0.00%> (-1.06%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/14082/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=footer). Last update [d6bd160...fcc8166](https://codecov.io/gh/apache/superset/pull/14082?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org