[jira] Commented: (GERONIMO-1265) Preserve comments added by users in the config.xml file

["Don Hill (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507635 ] 

Don Hill commented on GERONIMO-1265:
------------------------------------

I submitted a patch with no comment, at least thats the way it looks, anyways the patch geronimo-1265 has a work around that will allow a user to add comments without losing them. I modified the schema 
 <xsd:complexType name="moduleType">
         <xsd:sequence>
+            <xsd:element name="comment" type="xsd:string" minOccurs="0" />
             <xsd:element name="gbean" type="atts:gbeanType" minOccurs="0"
                 maxOccurs="unbounded" />
         </xsd:sequence>

and added supporting code to org/apache/geronimo/system/configuration/ConfigurationOverride.java

> Preserve comments added by users in the config.xml file
> -------------------------------------------------------
>
>                 Key: GERONIMO-1265
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-1265
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown, usability
>    Affects Versions: 1.0-M5, 1.0, 1.1, 1.1.1, 1.1.2, 1.1.x, 1.2
>            Reporter: John Sisson
>             Fix For: 1.x, 2.0-M5
>
>         Attachments: geronimo-1265.patch
>
>
> Currently if a user adds comments to the config.xml file, they will be lost when Geronimo re-generates the file if a configuration change is made (e.g. through the web console).
> As a temporary measure, the code that re-generates the XML will place a warning at the top of the file warning users not to place comments in it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.