You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/20 12:03:34 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #17743: [fix][tests] Fix resource leak in tests. Call cleanup before setup

lhotari opened a new pull request, #17743:
URL: https://github.com/apache/pulsar/pull/17743

   Fixes #17714
   
   ### Motivation
   
   There are a few resource leaks in tests where setup (or internalSetup) is called explicitly without first calling cleanup.
   This causes a thread and memory leak in tests which slows down test execution.
   
   ### Modifications
   
   - when setup is called explicitly, cleanup should be issued before it
   - remove unnecessary "resetConfig" method calls
     - resetConfig gets called as part of internalCleanup
     - when resetConfig is in cleanup, it's possible to override config before calling setup
       - this allows using setup & cleanup methods instead of using error prone internalSetup and internalCleanup methods which might leave something behind
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE 
   
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #17743: [fix][tests] Fix resource leak in tests. Call cleanup before setup

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17743:
URL: https://github.com/apache/pulsar/pull/17743#issuecomment-1253218507

   @Technoboy- this is now ready for review. Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #17743: [fix][tests] Fix resource leak in tests. Call cleanup before setup

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #17743:
URL: https://github.com/apache/pulsar/pull/17743#issuecomment-1253271158

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #17743: [fix][tests] Fix resource leak in tests. Call cleanup before setup

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #17743:
URL: https://github.com/apache/pulsar/pull/17743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org