You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rory Winston <ro...@gmail.com> on 2008/03/02 22:40:10 UTC
[VOTE] Release Commons Net 1.5
Hi
This is a release vote for Commons Net 1.5. This release fixes a few
issues with TFTP errors, threading hangs, and a leap year date parsing bug.
The RC deployment is here:
http://people.apache.org/~rwinston/commons-net-1.5.0/site/
Binaries:
http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
Source:
http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
Javadocs:
http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
SVN tag:
http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
Here's my +1 in advance.
Cheers
Rory
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by sebb <se...@gmail.com>.
The *nix short date formatting fixes don't currently have any tests,
at least when I last checked.
I think these need to be added first.
I can add some later today if that's OK with you?
Or do you want them done as patches via Jira?
On 09/03/2008, Rory Winston <ro...@gmail.com> wrote:
> Hi James
>
> Yes, I'm going to cut new RCs for 1.5 and 2.0.
>
> Thanks
>
> Rory
>
>
>
> James Carman wrote:
> > On 3/8/08, Rory Winston <ro...@gmail.com> wrote:
> >
> >> I've taken into account the suggestions proposed by various people wrt
> >> the TFTP server classes and accordingly made some changes. Thanks for
> >> the feedback.
> >>
> >>
> >
> > So, does that mean you're cutting (or have already done so) a new
> > release candidate for us to vote on?
> >
> >
> >> Rory
> >>
> >>
> >> sebb wrote:
> >> > On 07/03/2008, Henri Yandell <fl...@gmail.com> wrote:
> >> >
> >> >> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
> >> >> > On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
> >> >> > > Hi
> >> >> > >
> >> >> > > This is a release vote for Commons Net 1.5. This release fixes a few
> >> >> > > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
> >> >> > >
> >> >> > > The RC deployment is here:
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
> >> >> > >
> >> >> > > Binaries:
> >> >> > >
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
> >> >> > >
> >> >> > > Source:
> >> >> > >
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
> >> >> > >
> >> >> > > Javadocs:
> >> >> > >
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
> >> >> > >
> >> >> > > SVN tag:
> >> >> > >
> >> >> > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
> >> >> > >
> >> >> > > Here's my +1 in advance.
> >> >> > > Cheers
> >> >> > > Rory
> >> >> > >
> >> >> >
> >> >> > I just wanted to post my official -1 vote. I feel that the
> >> >> > org.apache.commons.net.tftp.TFTPServer class is outside the scope of
> >> >> > Commons Net. I have no problem with it being in the test classes, as
> >> >> > suggested, though.
> >> >>
> >> >>
> >> >> Not a problem for me. +1 to including the server class.
> >> >>
> >> >> It's not big codewise, and is not that far from Net's scope or Commons scope.
> >> >>
> >> >
> >> > But it's not in scope (yet?)
> >> >
> >> >
> >> >> Two proviso's:
> >> >>
> >> >> 1) The main method in TFTPServer should be removed.
> >> >>
> >> >
> >> > +1
> >> >
> >> >
> >> >> 2) If we get lots of embedded server components, then we should
> >> >> rethink this, but I can see that the 'simple embedded server space' is
> >> >> pretty small. Might want to use a different package to allow it to
> >> >> more easily be split out. org.apache.commons.net.server.* or
> >> >> something. Then people can send in their dumb EchoServer
> >> >> implementations :)
> >> >>
> >> >
> >> > +1 to changing package name.
> >> >
> >> > I still think it should be in the test tree; AFAICS the purpose of the
> >> > code contribution was to enable the TFTP Client to be tested.
> >> >
> >> > If Commons starts getting other simple server implementations then
> >> > these ought to be part of a different project with a scope of
> >> > Testing/Mocking or some such. Maybe not even in Commons.
> >> >
> >> >
> >> >> Hen
> >> >>
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >>
> >> >>
> >> >>
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> > For additional commands, e-mail: dev-help@commons.apache.org
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Rory Winston <ro...@gmail.com>.
Sure, you can just add them directly yourself if you like.
Rory
The *nix short date formatting fixes don't currently have any tests,
at least when I last checked.
I think these need to be added first.
I can add some later today if that's OK with you?
Or do you want them done as patches via Jira?
On 09/03/2008, Rory Winston <ro...@gmail.com> wrote:
> Hi James
>
> Yes, I'm going to cut new RCs for 1.5 and 2.0.
>
> Thanks
>
> Rory
>
>
>
> James Carman wrote:
> > On 3/8/08, Rory Winston <ro...@gmail.com> wrote:
> >
> >> I've taken into account the suggestions proposed by various people wrt
> >> the TFTP server classes and accordingly made some changes. Thanks for
> >> the feedback.
> >>
> >>
> >
> > So, does that mean you're cutting (or have already done so) a new
> > release candidate for us to vote on?
> >
> >
> >> Rory
> >>
> >>
> >> sebb wrote:
> >> > On 07/03/2008, Henri Yandell <fl...@gmail.com> wrote:
> >> >
> >> >> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
> >> >> > On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
> >> >> > > Hi
> >> >> > >
> >> >> > > This is a release vote for Commons Net 1.5. This release fixes a few
> >> >> > > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
> >> >> > >
> >> >> > > The RC deployment is here:
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
> >> >> > >
> >> >> > > Binaries:
> >> >> > >
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
> >> >> > >
> >> >> > > Source:
> >> >> > >
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
> >> >> > >
> >> >> > > Javadocs:
> >> >> > >
> >> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
> >> >> > >
> >> >> > > SVN tag:
> >> >> > >
> >> >> > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
> >> >> > >
> >> >> > > Here's my +1 in advance.
> >> >> > > Cheers
> >> >> > > Rory
> >> >> > >
> >> >> >
> >> >> > I just wanted to post my official -1 vote. I feel that the
> >> >> > org.apache.commons.net.tftp.TFTPServer class is outside the scope of
> >> >> > Commons Net. I have no problem with it being in the test classes, as
> >> >> > suggested, though.
> >> >>
> >> >>
> >> >> Not a problem for me. +1 to including the server class.
> >> >>
> >> >> It's not big codewise, and is not that far from Net's scope or Commons scope.
> >> >>
> >> >
> >> > But it's not in scope (yet?)
> >> >
> >> >
> >> >> Two proviso's:
> >> >>
> >> >> 1) The main method in TFTPServer should be removed.
> >> >>
> >> >
> >> > +1
> >> >
> >> >
> >> >> 2) If we get lots of embedded server components, then we should
> >> >> rethink this, but I can see that the 'simple embedded server space' is
> >> >> pretty small. Might want to use a different package to allow it to
> >> >> more easily be split out. org.apache.commons.net.server.* or
> >> >> something. Then people can send in their dumb EchoServer
> >> >> implementations :)
> >> >>
> >> >
> >> > +1 to changing package name.
> >> >
> >> > I still think it should be in the test tree; AFAICS the purpose of the
> >> > code contribution was to enable the TFTP Client to be tested.
> >> >
> >> > If Commons starts getting other simple server implementations then
> >> > these ought to be part of a different project with a scope of
> >> > Testing/Mocking or some such. Maybe not even in Commons.
> >> >
> >> >
> >> >> Hen
> >> >>
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> For additional commands, e-mail: dev-help@commons.apache.org
> >> >>
> >> >>
> >> >>
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> > For additional commands, e-mail: dev-help@commons.apache.org
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Rory Winston <ro...@gmail.com>.
Hi James
Yes, I'm going to cut new RCs for 1.5 and 2.0.
Thanks
Rory
James Carman wrote:
> On 3/8/08, Rory Winston <ro...@gmail.com> wrote:
>
>> I've taken into account the suggestions proposed by various people wrt
>> the TFTP server classes and accordingly made some changes. Thanks for
>> the feedback.
>>
>>
>
> So, does that mean you're cutting (or have already done so) a new
> release candidate for us to vote on?
>
>
>> Rory
>>
>>
>> sebb wrote:
>> > On 07/03/2008, Henri Yandell <fl...@gmail.com> wrote:
>> >
>> >> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
>> >> > On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
>> >> > > Hi
>> >> > >
>> >> > > This is a release vote for Commons Net 1.5. This release fixes a few
>> >> > > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>> >> > >
>> >> > > The RC deployment is here:
>> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>> >> > >
>> >> > > Binaries:
>> >> > >
>> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>> >> > >
>> >> > > Source:
>> >> > >
>> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>> >> > >
>> >> > > Javadocs:
>> >> > >
>> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>> >> > >
>> >> > > SVN tag:
>> >> > >
>> >> > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>> >> > >
>> >> > > Here's my +1 in advance.
>> >> > > Cheers
>> >> > > Rory
>> >> > >
>> >> >
>> >> > I just wanted to post my official -1 vote. I feel that the
>> >> > org.apache.commons.net.tftp.TFTPServer class is outside the scope of
>> >> > Commons Net. I have no problem with it being in the test classes, as
>> >> > suggested, though.
>> >>
>> >>
>> >> Not a problem for me. +1 to including the server class.
>> >>
>> >> It's not big codewise, and is not that far from Net's scope or Commons scope.
>> >>
>> >
>> > But it's not in scope (yet?)
>> >
>> >
>> >> Two proviso's:
>> >>
>> >> 1) The main method in TFTPServer should be removed.
>> >>
>> >
>> > +1
>> >
>> >
>> >> 2) If we get lots of embedded server components, then we should
>> >> rethink this, but I can see that the 'simple embedded server space' is
>> >> pretty small. Might want to use a different package to allow it to
>> >> more easily be split out. org.apache.commons.net.server.* or
>> >> something. Then people can send in their dumb EchoServer
>> >> implementations :)
>> >>
>> >
>> > +1 to changing package name.
>> >
>> > I still think it should be in the test tree; AFAICS the purpose of the
>> > code contribution was to enable the TFTP Client to be tested.
>> >
>> > If Commons starts getting other simple server implementations then
>> > these ought to be part of a different project with a scope of
>> > Testing/Mocking or some such. Maybe not even in Commons.
>> >
>> >
>> >> Hen
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>> >
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by James Carman <ja...@carmanconsulting.com>.
On 3/8/08, Rory Winston <ro...@gmail.com> wrote:
> I've taken into account the suggestions proposed by various people wrt
> the TFTP server classes and accordingly made some changes. Thanks for
> the feedback.
>
So, does that mean you're cutting (or have already done so) a new
release candidate for us to vote on?
>
> Rory
>
>
> sebb wrote:
> > On 07/03/2008, Henri Yandell <fl...@gmail.com> wrote:
> >
> >> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
> >> > On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
> >> > > Hi
> >> > >
> >> > > This is a release vote for Commons Net 1.5. This release fixes a few
> >> > > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
> >> > >
> >> > > The RC deployment is here:
> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
> >> > >
> >> > > Binaries:
> >> > >
> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
> >> > >
> >> > > Source:
> >> > >
> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
> >> > >
> >> > > Javadocs:
> >> > >
> >> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
> >> > >
> >> > > SVN tag:
> >> > >
> >> > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
> >> > >
> >> > > Here's my +1 in advance.
> >> > > Cheers
> >> > > Rory
> >> > >
> >> >
> >> > I just wanted to post my official -1 vote. I feel that the
> >> > org.apache.commons.net.tftp.TFTPServer class is outside the scope of
> >> > Commons Net. I have no problem with it being in the test classes, as
> >> > suggested, though.
> >>
> >>
> >> Not a problem for me. +1 to including the server class.
> >>
> >> It's not big codewise, and is not that far from Net's scope or Commons scope.
> >>
> >
> > But it's not in scope (yet?)
> >
> >
> >> Two proviso's:
> >>
> >> 1) The main method in TFTPServer should be removed.
> >>
> >
> > +1
> >
> >
> >> 2) If we get lots of embedded server components, then we should
> >> rethink this, but I can see that the 'simple embedded server space' is
> >> pretty small. Might want to use a different package to allow it to
> >> more easily be split out. org.apache.commons.net.server.* or
> >> something. Then people can send in their dumb EchoServer
> >> implementations :)
> >>
> >
> > +1 to changing package name.
> >
> > I still think it should be in the test tree; AFAICS the purpose of the
> > code contribution was to enable the TFTP Client to be tested.
> >
> > If Commons starts getting other simple server implementations then
> > these ought to be part of a different project with a scope of
> > Testing/Mocking or some such. Maybe not even in Commons.
> >
> >
> >> Hen
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Rory Winston <ro...@gmail.com>.
I've taken into account the suggestions proposed by various people wrt
the TFTP server classes and accordingly made some changes. Thanks for
the feedback.
Rory
sebb wrote:
> On 07/03/2008, Henri Yandell <fl...@gmail.com> wrote:
>
>> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
>> > On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
>> > > Hi
>> > >
>> > > This is a release vote for Commons Net 1.5. This release fixes a few
>> > > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>> > >
>> > > The RC deployment is here:
>> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>> > >
>> > > Binaries:
>> > >
>> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>> > >
>> > > Source:
>> > >
>> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>> > >
>> > > Javadocs:
>> > >
>> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>> > >
>> > > SVN tag:
>> > >
>> > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>> > >
>> > > Here's my +1 in advance.
>> > > Cheers
>> > > Rory
>> > >
>> >
>> > I just wanted to post my official -1 vote. I feel that the
>> > org.apache.commons.net.tftp.TFTPServer class is outside the scope of
>> > Commons Net. I have no problem with it being in the test classes, as
>> > suggested, though.
>>
>>
>> Not a problem for me. +1 to including the server class.
>>
>> It's not big codewise, and is not that far from Net's scope or Commons scope.
>>
>
> But it's not in scope (yet?)
>
>
>> Two proviso's:
>>
>> 1) The main method in TFTPServer should be removed.
>>
>
> +1
>
>
>> 2) If we get lots of embedded server components, then we should
>> rethink this, but I can see that the 'simple embedded server space' is
>> pretty small. Might want to use a different package to allow it to
>> more easily be split out. org.apache.commons.net.server.* or
>> something. Then people can send in their dumb EchoServer
>> implementations :)
>>
>
> +1 to changing package name.
>
> I still think it should be in the test tree; AFAICS the purpose of the
> code contribution was to enable the TFTP Client to be tested.
>
> If Commons starts getting other simple server implementations then
> these ought to be part of a different project with a scope of
> Testing/Mocking or some such. Maybe not even in Commons.
>
>
>> Hen
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by sebb <se...@gmail.com>.
On 07/03/2008, Henri Yandell <fl...@gmail.com> wrote:
> On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
> > On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
> > > Hi
> > >
> > > This is a release vote for Commons Net 1.5. This release fixes a few
> > > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
> > >
> > > The RC deployment is here:
> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
> > >
> > > Binaries:
> > >
> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
> > >
> > > Source:
> > >
> > > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
> > >
> > > Javadocs:
> > >
> > > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
> > >
> > > SVN tag:
> > >
> > > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
> > >
> > > Here's my +1 in advance.
> > > Cheers
> > > Rory
> > >
> >
> > I just wanted to post my official -1 vote. I feel that the
> > org.apache.commons.net.tftp.TFTPServer class is outside the scope of
> > Commons Net. I have no problem with it being in the test classes, as
> > suggested, though.
>
>
> Not a problem for me. +1 to including the server class.
>
> It's not big codewise, and is not that far from Net's scope or Commons scope.
But it's not in scope (yet?)
> Two proviso's:
>
> 1) The main method in TFTPServer should be removed.
+1
> 2) If we get lots of embedded server components, then we should
> rethink this, but I can see that the 'simple embedded server space' is
> pretty small. Might want to use a different package to allow it to
> more easily be split out. org.apache.commons.net.server.* or
> something. Then people can send in their dumb EchoServer
> implementations :)
+1 to changing package name.
I still think it should be in the test tree; AFAICS the purpose of the
code contribution was to enable the TFTP Client to be tested.
If Commons starts getting other simple server implementations then
these ought to be part of a different project with a scope of
Testing/Mocking or some such. Maybe not even in Commons.
> Hen
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Henri Yandell <fl...@gmail.com>.
On Fri, Mar 7, 2008 at 8:04 AM, James Carman <ja...@carmanconsulting.com> wrote:
> On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
> > Hi
> >
> > This is a release vote for Commons Net 1.5. This release fixes a few
> > issues with TFTP errors, threading hangs, and a leap year date parsing bug.
> >
> > The RC deployment is here:
> > http://people.apache.org/~rwinston/commons-net-1.5.0/site/
> >
> > Binaries:
> >
> > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
> >
> > Source:
> >
> > http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
> >
> > Javadocs:
> >
> > http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
> >
> > SVN tag:
> >
> > http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
> >
> > Here's my +1 in advance.
> > Cheers
> > Rory
> >
>
> I just wanted to post my official -1 vote. I feel that the
> org.apache.commons.net.tftp.TFTPServer class is outside the scope of
> Commons Net. I have no problem with it being in the test classes, as
> suggested, though.
Not a problem for me. +1 to including the server class.
It's not big codewise, and is not that far from Net's scope or Commons scope.
Two proviso's:
1) The main method in TFTPServer should be removed.
2) If we get lots of embedded server components, then we should
rethink this, but I can see that the 'simple embedded server space' is
pretty small. Might want to use a different package to allow it to
more easily be split out. org.apache.commons.net.server.* or
something. Then people can send in their dumb EchoServer
implementations :)
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by James Carman <ja...@carmanconsulting.com>.
On 3/2/08, Rory Winston <ro...@gmail.com> wrote:
> Hi
>
> This is a release vote for Commons Net 1.5. This release fixes a few
> issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>
> The RC deployment is here:
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>
> Binaries:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>
> Source:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>
> Javadocs:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>
> SVN tag:
>
> http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>
> Here's my +1 in advance.
> Cheers
> Rory
>
I just wanted to post my official -1 vote. I feel that the
org.apache.commons.net.tftp.TFTPServer class is outside the scope of
Commons Net. I have no problem with it being in the test classes, as
suggested, though.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by sebb <se...@gmail.com>.
On 03/03/2008, Oberhuber, Martin <Ma...@windriver.com> wrote:
> If TFTPServer is for testing only, shouldn't it reside in
> the tests/ source root?
Duh!
That should have been ITIR (I thought I remembered ;-)
Sorry for the noise.
> Having a TFTPServer would be cool though, but I have no idea
> what level of quality it is.
>
>
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
>
>
> > -----Original Message-----
>
> > From: sebb [mailto:sebbaz@gmail.com]
> > Sent: Montag, 03. März 2008 14:29
> > To: Jakarta Commons Developers List
>
> > Subject: Re: [VOTE] Release Commons Net 1.5
> >
> > > > TFTPServer.java
> > > > SocketTimeoutException is unknown in J2SE-1.2 or 1.3
>
>
> > ISTR that the TFTPServer is for testing only, so perhaps one way round
> > this would be to exclude it from builds if the JVM does not support
> > it.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by James Carman <ja...@carmanconsulting.com>.
On 3/3/08, Oberhuber, Martin <Ma...@windriver.com> wrote:
> If TFTPServer is for testing only, shouldn't it reside in
> the tests/ source root?
>
> Having a TFTPServer would be cool though, but I have no idea
> what level of quality it is.
Wouldn't a server implementation like that be outside the scope of the
NET project? Perhaps it belongs in its own project and NET can use it
as a test dependency.
>
>
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
>
>
> > -----Original Message-----
>
> > From: sebb [mailto:sebbaz@gmail.com]
> > Sent: Montag, 03. März 2008 14:29
> > To: Jakarta Commons Developers List
>
> > Subject: Re: [VOTE] Release Commons Net 1.5
> >
> > > > TFTPServer.java
> > > > SocketTimeoutException is unknown in J2SE-1.2 or 1.3
>
>
> > ISTR that the TFTPServer is for testing only, so perhaps one way round
> > this would be to exclude it from builds if the JVM does not support
> > it.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release Commons Net 1.5
Posted by "Oberhuber, Martin" <Ma...@windriver.com>.
If TFTPServer is for testing only, shouldn't it reside in
the tests/ source root?
Having a TFTPServer would be cool though, but I have no idea
what level of quality it is.
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: sebb [mailto:sebbaz@gmail.com]
> Sent: Montag, 03. März 2008 14:29
> To: Jakarta Commons Developers List
> Subject: Re: [VOTE] Release Commons Net 1.5
>
> > > TFTPServer.java
> > > SocketTimeoutException is unknown in J2SE-1.2 or 1.3
> ISTR that the TFTPServer is for testing only, so perhaps one way round
> this would be to exclude it from builds if the JVM does not support
> it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by sebb <se...@gmail.com>.
On 03/03/2008, Niall Pemberton <ni...@gmail.com> wrote:
> On Mon, Mar 3, 2008 at 12:06 PM, Oberhuber, Martin
> <Ma...@windriver.com> wrote:
> > Also,
> >
> > I see that while commons.net 1.4.1 compiled properly against
> > J2SE-1.2, there are build errors in 1.5.0 with J2SE-1.2:
> >
> > TFTPServer.java
> > SocketTimeoutException is unknown in J2SE-1.2 or 1.3
> >
> > I think it's a severe regression to require J2SE-1.4 or
> > later just because of newly added TFTPServer. People have
> > been sticking with commons.net on Java Micro Editions
> > especially because of the old J2SE-1.2 compatibility.
> > This should NOT be broken with 1.5.0.
>
>
> The JDK source/target options are 1.3 (inherited from commons-parent)
> so it should run on JDK 1.3, except for bits that use 1.4 features and
> the source/target could be set to 1.2 (adding
> maven.compile.source/maven.compile.target properties to the net
> pom.xml) which would mean it should on the whole run on 1.2, if not
> compile with 1.2.
>
ISTR that the TFTPServer is for testing only, so perhaps one way round
this would be to exclude it from builds if the JVM does not support
it.
>
> Niall
>
>
> > Cheers,
> > --
> > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > Target Management Project Lead, DSDP PMC Member
> > http://www.eclipse.org/dsdp/tm
> >
> >
> >
> > > -----Original Message-----
> > > From: Oberhuber, Martin
> >
> >
> > > Sent: Montag, 03. März 2008 12:57
> > > To: 'Jakarta Commons Developers List'; 'Rory Winston'
> > > Subject: RE: [VOTE] Release Commons Net 1.5
> > >
> > > Also, I get unit test failures in
> > > FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
> > > as well as all FTP Windows tests (looks like ftp.wacom.com
> > > is down -- should a different Windows FTP Server be added?)
> > >
> > > Cheers,
> > > --
> > > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > > Target Management Project Lead, DSDP PMC Member
> > > http://www.eclipse.org/dsdp/tm
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Oberhuber, Martin
> > > > Sent: Montag, 03. März 2008 11:50
> > > > To: 'Jakarta Commons Developers List'
> > > > Subject: RE: [VOTE] Release Commons Net 1.5
> > > >
> > > > Hi Rory,
> > > >
> > > > it's great to hear some progress is being made towards a new
> > > > commons.net release!!!
> > > >
> > > > For the 1.5 release candidate, I notice that the binary
> > > > JAR now has the examples classes embedded whereas the 1.4
> > > > release did not. Also, some Maven POM stuff is in META-INF.
> > > > Is this intentional?
> > > >
> > > > jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
> > > > jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort >
> > > cn150.txt
> > > > diff cn150.txt cn141.txt
> > > >
> > > > 5,39d4
> > > > < META-INF/maven/
> > > > < META-INF/maven/commons-net/
> > > > < META-INF/maven/commons-net/commons-net/
> > > > < META-INF/maven/commons-net/commons-net/pom.properties
> > > > < META-INF/maven/commons-net/commons-net/pom.xml
> > > > < examples/
> > > > < examples/IOUtil.class
> > > > [...]
> > > > < examples/tftp.class
> > > > < examples/weatherTelnet.class
> > > > 97d61
> > > > < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
> > > > 179,180d142
> > > > < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
> > > > < org/apache/commons/net/tftp/TFTPServer.class
> > > >
> > > > Also, your Source Package includes some odd files which I
> > > > believe should not be part of a release: the "proposal" did
> > > > not make it into the binary release, and "src/assembly" has
> > > > not been part of 1.4.1:
> > > > /propsal/ftp2/
> > > > /src/assembly/
> > > > /src/java/org/apache/commons/net/tftp/
> > > > -! (DIR)
> > > > TFTPClient-1.4.1-fix.diff
> > > > TFTPClient.java.orig
> > > > TFTPClient.java.rej
> > > >
> > > >
> > > > The other thing I'd REALLY consider important especially for a
> > > > 1.5.x service release, is a list of changes that were made.
> > > > Is such a changelog available anywhere?
> > > >
> > > > I tried making a source diff, but it throws out ALL files as
> > > > different since the copyright headers changed. I think that
> > > > the change in copyright terms might also be worth mentioning
> > > > in the change log. More changes were indicated due to RCS
> > > > Version tags like * @version $Id: .*$
> > > > or * @version $Revision: .*$
> > > >
> > > > That being said, I noticed that the following file(s) do *NOT*
> > > > carry the new license header in 1.5:
> > > > TFTPClient.java
> > > > and others e.g. TimeTCPClientTest.java did even carry an
> > > > Apache 1.1 license in version 1.4, or no license at all
> > > > (AllTests.java).
> > > >
> > > > Also, is it legally OK to omit the Copyright Years? In 1.4.1,
> > > > some files were Copyright 2001-2005 while others (especially
> > > > Telnet) were Copyright 2003-2004 while others (FTPParser)
> > > > were Copyright 2004 or Copyright 2005.
> > > >
> > > > In UnixFTPEntryParserTest.java I see that one test case is
> > > > commented out, is this intentional?
> > > >
> > > > In build.xml you still have this, I think it should not be -dev:
> > > > <property name="final.name" value="commons-net-1.5.0-dev">
> > > >
> > > > I made some semi-automated editing on the source archives,
> > > > and came up with following list of files that were changed
> > > > for 1.5.0 -- perhaps it helps finding the bugs that were
> > > > resolved for 1.5.0, in order to compile a change list:
> > > >
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
> > > > diff -r -b
> > > >
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
> > > > tConfig.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
> > > > efaultFTPFileEntryParserFactory.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
> > > > TPTimestampParserImpl.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
> > > > TFTPEntryParser.java
> > > > Only in
> > > > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > > > /ftp/parser: NetwareFTPEntryParser.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
> > > > nixFTPEntryParser.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
> > > > tInputStream.java
> > > > diff -r -b
> > > > commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
> > > > ent.java
> > > > Only in
> > > > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > > > /tftp: TFTPServer.java
> > > >
> > > > Only in commons-net-1.4.1/target: test-classes
> > > > Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
> > > >
> > > > Cheers,
> > > > --
> > > > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > > > Target Management Project Lead, DSDP PMC Member
> > > > http://www.eclipse.org/dsdp/tm
> > >
> >
> > ---------------------------------------------------------------------
> >
> >
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, Mar 3, 2008 at 12:06 PM, Oberhuber, Martin
<Ma...@windriver.com> wrote:
> Also,
>
> I see that while commons.net 1.4.1 compiled properly against
> J2SE-1.2, there are build errors in 1.5.0 with J2SE-1.2:
>
> TFTPServer.java
> SocketTimeoutException is unknown in J2SE-1.2 or 1.3
>
> I think it's a severe regression to require J2SE-1.4 or
> later just because of newly added TFTPServer. People have
> been sticking with commons.net on Java Micro Editions
> especially because of the old J2SE-1.2 compatibility.
> This should NOT be broken with 1.5.0.
The JDK source/target options are 1.3 (inherited from commons-parent)
so it should run on JDK 1.3, except for bits that use 1.4 features and
the source/target could be set to 1.2 (adding
maven.compile.source/maven.compile.target properties to the net
pom.xml) which would mean it should on the whole run on 1.2, if not
compile with 1.2.
Niall
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
>
>
> > -----Original Message-----
> > From: Oberhuber, Martin
>
>
> > Sent: Montag, 03. März 2008 12:57
> > To: 'Jakarta Commons Developers List'; 'Rory Winston'
> > Subject: RE: [VOTE] Release Commons Net 1.5
> >
> > Also, I get unit test failures in
> > FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
> > as well as all FTP Windows tests (looks like ftp.wacom.com
> > is down -- should a different Windows FTP Server be added?)
> >
> > Cheers,
> > --
> > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > Target Management Project Lead, DSDP PMC Member
> > http://www.eclipse.org/dsdp/tm
> >
> >
> >
> > > -----Original Message-----
> > > From: Oberhuber, Martin
> > > Sent: Montag, 03. März 2008 11:50
> > > To: 'Jakarta Commons Developers List'
> > > Subject: RE: [VOTE] Release Commons Net 1.5
> > >
> > > Hi Rory,
> > >
> > > it's great to hear some progress is being made towards a new
> > > commons.net release!!!
> > >
> > > For the 1.5 release candidate, I notice that the binary
> > > JAR now has the examples classes embedded whereas the 1.4
> > > release did not. Also, some Maven POM stuff is in META-INF.
> > > Is this intentional?
> > >
> > > jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
> > > jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort >
> > cn150.txt
> > > diff cn150.txt cn141.txt
> > >
> > > 5,39d4
> > > < META-INF/maven/
> > > < META-INF/maven/commons-net/
> > > < META-INF/maven/commons-net/commons-net/
> > > < META-INF/maven/commons-net/commons-net/pom.properties
> > > < META-INF/maven/commons-net/commons-net/pom.xml
> > > < examples/
> > > < examples/IOUtil.class
> > > [...]
> > > < examples/tftp.class
> > > < examples/weatherTelnet.class
> > > 97d61
> > > < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
> > > 179,180d142
> > > < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
> > > < org/apache/commons/net/tftp/TFTPServer.class
> > >
> > > Also, your Source Package includes some odd files which I
> > > believe should not be part of a release: the "proposal" did
> > > not make it into the binary release, and "src/assembly" has
> > > not been part of 1.4.1:
> > > /propsal/ftp2/
> > > /src/assembly/
> > > /src/java/org/apache/commons/net/tftp/
> > > -! (DIR)
> > > TFTPClient-1.4.1-fix.diff
> > > TFTPClient.java.orig
> > > TFTPClient.java.rej
> > >
> > >
> > > The other thing I'd REALLY consider important especially for a
> > > 1.5.x service release, is a list of changes that were made.
> > > Is such a changelog available anywhere?
> > >
> > > I tried making a source diff, but it throws out ALL files as
> > > different since the copyright headers changed. I think that
> > > the change in copyright terms might also be worth mentioning
> > > in the change log. More changes were indicated due to RCS
> > > Version tags like * @version $Id: .*$
> > > or * @version $Revision: .*$
> > >
> > > That being said, I noticed that the following file(s) do *NOT*
> > > carry the new license header in 1.5:
> > > TFTPClient.java
> > > and others e.g. TimeTCPClientTest.java did even carry an
> > > Apache 1.1 license in version 1.4, or no license at all
> > > (AllTests.java).
> > >
> > > Also, is it legally OK to omit the Copyright Years? In 1.4.1,
> > > some files were Copyright 2001-2005 while others (especially
> > > Telnet) were Copyright 2003-2004 while others (FTPParser)
> > > were Copyright 2004 or Copyright 2005.
> > >
> > > In UnixFTPEntryParserTest.java I see that one test case is
> > > commented out, is this intentional?
> > >
> > > In build.xml you still have this, I think it should not be -dev:
> > > <property name="final.name" value="commons-net-1.5.0-dev">
> > >
> > > I made some semi-automated editing on the source archives,
> > > and came up with following list of files that were changed
> > > for 1.5.0 -- perhaps it helps finding the bugs that were
> > > resolved for 1.5.0, in order to compile a change list:
> > >
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
> > > diff -r -b
> > >
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
> > > tConfig.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
> > > efaultFTPFileEntryParserFactory.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
> > > TPTimestampParserImpl.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
> > > TFTPEntryParser.java
> > > Only in
> > > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > > /ftp/parser: NetwareFTPEntryParser.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
> > > nixFTPEntryParser.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
> > > tInputStream.java
> > > diff -r -b
> > > commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
> > > ent.java
> > > Only in
> > > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > > /tftp: TFTPServer.java
> > >
> > > Only in commons-net-1.4.1/target: test-classes
> > > Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
> > >
> > > Cheers,
> > > --
> > > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > > Target Management Project Lead, DSDP PMC Member
> > > http://www.eclipse.org/dsdp/tm
> >
>
> ---------------------------------------------------------------------
>
>
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release Commons Net 1.5
Posted by "Oberhuber, Martin" <Ma...@windriver.com>.
Also,
I see that while commons.net 1.4.1 compiled properly against
J2SE-1.2, there are build errors in 1.5.0 with J2SE-1.2:
TFTPServer.java
SocketTimeoutException is unknown in J2SE-1.2 or 1.3
I think it's a severe regression to require J2SE-1.4 or
later just because of newly added TFTPServer. People have
been sticking with commons.net on Java Micro Editions
especially because of the old J2SE-1.2 compatibility.
This should NOT be broken with 1.5.0.
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: Oberhuber, Martin
> Sent: Montag, 03. März 2008 12:57
> To: 'Jakarta Commons Developers List'; 'Rory Winston'
> Subject: RE: [VOTE] Release Commons Net 1.5
>
> Also, I get unit test failures in
> FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
> as well as all FTP Windows tests (looks like ftp.wacom.com
> is down -- should a different Windows FTP Server be added?)
>
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
>
>
> > -----Original Message-----
> > From: Oberhuber, Martin
> > Sent: Montag, 03. März 2008 11:50
> > To: 'Jakarta Commons Developers List'
> > Subject: RE: [VOTE] Release Commons Net 1.5
> >
> > Hi Rory,
> >
> > it's great to hear some progress is being made towards a new
> > commons.net release!!!
> >
> > For the 1.5 release candidate, I notice that the binary
> > JAR now has the examples classes embedded whereas the 1.4
> > release did not. Also, some Maven POM stuff is in META-INF.
> > Is this intentional?
> >
> > jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
> > jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort >
> cn150.txt
> > diff cn150.txt cn141.txt
> >
> > 5,39d4
> > < META-INF/maven/
> > < META-INF/maven/commons-net/
> > < META-INF/maven/commons-net/commons-net/
> > < META-INF/maven/commons-net/commons-net/pom.properties
> > < META-INF/maven/commons-net/commons-net/pom.xml
> > < examples/
> > < examples/IOUtil.class
> > [...]
> > < examples/tftp.class
> > < examples/weatherTelnet.class
> > 97d61
> > < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
> > 179,180d142
> > < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
> > < org/apache/commons/net/tftp/TFTPServer.class
> >
> > Also, your Source Package includes some odd files which I
> > believe should not be part of a release: the "proposal" did
> > not make it into the binary release, and "src/assembly" has
> > not been part of 1.4.1:
> > /propsal/ftp2/
> > /src/assembly/
> > /src/java/org/apache/commons/net/tftp/
> > -! (DIR)
> > TFTPClient-1.4.1-fix.diff
> > TFTPClient.java.orig
> > TFTPClient.java.rej
> >
> >
> > The other thing I'd REALLY consider important especially for a
> > 1.5.x service release, is a list of changes that were made.
> > Is such a changelog available anywhere?
> >
> > I tried making a source diff, but it throws out ALL files as
> > different since the copyright headers changed. I think that
> > the change in copyright terms might also be worth mentioning
> > in the change log. More changes were indicated due to RCS
> > Version tags like * @version $Id: .*$
> > or * @version $Revision: .*$
> >
> > That being said, I noticed that the following file(s) do *NOT*
> > carry the new license header in 1.5:
> > TFTPClient.java
> > and others e.g. TimeTCPClientTest.java did even carry an
> > Apache 1.1 license in version 1.4, or no license at all
> > (AllTests.java).
> >
> > Also, is it legally OK to omit the Copyright Years? In 1.4.1,
> > some files were Copyright 2001-2005 while others (especially
> > Telnet) were Copyright 2003-2004 while others (FTPParser)
> > were Copyright 2004 or Copyright 2005.
> >
> > In UnixFTPEntryParserTest.java I see that one test case is
> > commented out, is this intentional?
> >
> > In build.xml you still have this, I think it should not be -dev:
> > <property name="final.name" value="commons-net-1.5.0-dev">
> >
> > I made some semi-automated editing on the source archives,
> > and came up with following list of files that were changed
> > for 1.5.0 -- perhaps it helps finding the bugs that were
> > resolved for 1.5.0, in order to compile a change list:
> >
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
> > diff -r -b
> >
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
> > tConfig.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
> > efaultFTPFileEntryParserFactory.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
> > TPTimestampParserImpl.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
> > TFTPEntryParser.java
> > Only in
> > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > /ftp/parser: NetwareFTPEntryParser.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
> > nixFTPEntryParser.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
> > tInputStream.java
> > diff -r -b
> > commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
> > ent.java
> > Only in
> > commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > /tftp: TFTPServer.java
> >
> > Only in commons-net-1.4.1/target: test-classes
> > Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
> >
> > Cheers,
> > --
> > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > Target Management Project Lead, DSDP PMC Member
> > http://www.eclipse.org/dsdp/tm
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by sebb <se...@gmail.com>.
On 12/03/2008, Oberhuber, Martin <Ma...@windriver.com> wrote:
> What about using ftp.microsoft.com for the Windows Tests?
I think that should be run past the PMC - is it fair to use another
company's resources in this way? I know it's not likely to generate a
big load, but including another organisation's details in test code
does not seem entirely fair.
> They should be available quite reliably, eh? And it's very
> likely that they will keep using a Windows FTP server rather
> than switching to UNIX.
>
> Y:\>ftp ftp.microsoft.com
> Connected to ftp.microsoft.com.
> 220 Microsoft FTP Service
> User (ftp.microsoft.com:(none)): anonymous
> 331 Anonymous access allowed, send identity (e-mail name) as password.
> Password:
> 230 Anonymous user logged in.
> ftp> literal syst
> 215 Windows_NT
> ftp> literal feat
> 211-FEAT
> SIZE
> MDTM
> 211 END
>
>
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
>
>
> > -----Original Message-----
>
> > From: Rory Winston [mailto:rory.winston@gmail.com]
>
> > Sent: Samstag, 08. März 2008 21:39
> > To: Jakarta Commons Developers List
>
> > Subject: Re: [VOTE] Release Commons Net 1.5
> >
> > The functional tests seem to be broken right now, due to the remote
> > server being unavailable. These don't get run by default
> > anyways, so I
> > think we should just leave this for now, unless someone can suggest a
> > different server.
> >
> > Rory
> >
> > Oberhuber, Martin wrote:
> > > Also, I get unit test failures in
> > > FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
> > > as well as all FTP Windows tests (looks like ftp.wacom.com
> > > is down -- should a different Windows FTP Server be added?)
> > >
> > > Cheers,
> > > --
> > > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > > Target Management Project Lead, DSDP PMC Member
> > > http://www.eclipse.org/dsdp/tm
> > >
> > >
> > >
> > >
> > >> -----Original Message-----
> > >> From: Oberhuber, Martin
> > >> Sent: Montag, 03. März 2008 11:50
> > >> To: 'Jakarta Commons Developers List'
> > >> Subject: RE: [VOTE] Release Commons Net 1.5
> > >>
> > >> Hi Rory,
> > >>
> > >> it's great to hear some progress is being made towards a new
> > >> commons.net release!!!
> > >>
> > >> For the 1.5 release candidate, I notice that the binary
> > >> JAR now has the examples classes embedded whereas the 1.4
> > >> release did not. Also, some Maven POM stuff is in META-INF.
> > >> Is this intentional?
> > >>
> > >> jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort >
> > cn141.txt
> > >> jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort
> > > cn150.txt
> > >> diff cn150.txt cn141.txt
> > >>
> > >> 5,39d4
> > >> < META-INF/maven/
> > >> < META-INF/maven/commons-net/
> > >> < META-INF/maven/commons-net/commons-net/
> > >> < META-INF/maven/commons-net/commons-net/pom.properties
> > >> < META-INF/maven/commons-net/commons-net/pom.xml
> > >> < examples/
> > >> < examples/IOUtil.class
> > >> [...]
> > >> < examples/tftp.class
> > >> < examples/weatherTelnet.class
> > >> 97d61
> > >> < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
> > >> 179,180d142
> > >> < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
> > >> < org/apache/commons/net/tftp/TFTPServer.class
> > >>
> > >> Also, your Source Package includes some odd files which I
> > >> believe should not be part of a release: the "proposal" did
> > >> not make it into the binary release, and "src/assembly" has
> > >> not been part of 1.4.1:
> > >> /propsal/ftp2/
> > >> /src/assembly/
> > >> /src/java/org/apache/commons/net/tftp/
> > >> -! (DIR)
> > >> TFTPClient-1.4.1-fix.diff
> > >> TFTPClient.java.orig
> > >> TFTPClient.java.rej
> > >>
> > >>
> > >> The other thing I'd REALLY consider important especially for a
> > >> 1.5.x service release, is a list of changes that were made.
> > >> Is such a changelog available anywhere?
> > >>
> > >> I tried making a source diff, but it throws out ALL files as
> > >> different since the copyright headers changed. I think that
> > >> the change in copyright terms might also be worth mentioning
> > >> in the change log. More changes were indicated due to RCS
> > >> Version tags like * @version $Id: .*$
> > >> or * @version $Revision: .*$
> > >>
> > >> That being said, I noticed that the following file(s) do *NOT*
> > >> carry the new license header in 1.5:
> > >> TFTPClient.java
> > >> and others e.g. TimeTCPClientTest.java did even carry an
> > >> Apache 1.1 license in version 1.4, or no license at all
> > >> (AllTests.java).
> > >>
> > >> Also, is it legally OK to omit the Copyright Years? In 1.4.1,
> > >> some files were Copyright 2001-2005 while others (especially
> > >> Telnet) were Copyright 2003-2004 while others (FTPParser)
> > >> were Copyright 2004 or Copyright 2005.
> > >>
> > >> In UnixFTPEntryParserTest.java I see that one test case is
> > >> commented out, is this intentional?
> > >>
> > >> In build.xml you still have this, I think it should not be -dev:
> > >> <property name="final.name" value="commons-net-1.5.0-dev">
> > >>
> > >> I made some semi-automated editing on the source archives,
> > >> and came up with following list of files that were changed
> > >> for 1.5.0 -- perhaps it helps finding the bugs that were
> > >> resolved for 1.5.0, in order to compile a change list:
> > >>
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
> > >> diff -r -b
> > >>
> > commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
> > >> tConfig.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
> > >> efaultFTPFileEntryParserFactory.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
> > >> TPTimestampParserImpl.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
> > >> TFTPEntryParser.java
> > >> Only in
> > >> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > >> /ftp/parser: NetwareFTPEntryParser.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
> > >> nixFTPEntryParser.java
> > >> diff -r -b
> > >>
> > commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
> > >> tInputStream.java
> > >> diff -r -b
> > >> commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
> > >> ent.java
> > >> Only in
> > >> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> > >> /tftp: TFTPServer.java
> > >>
> > >> Only in commons-net-1.4.1/target: test-classes
> > >> Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
> > >>
> > >> Cheers,
> > >> --
> > >> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > >> Target Management Project Lead, DSDP PMC Member
> > >> http://www.eclipse.org/dsdp/tm
> > >>
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> > >
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release Commons Net 1.5
Posted by "Oberhuber, Martin" <Ma...@windriver.com>.
What about using ftp.microsoft.com for the Windows Tests?
They should be available quite reliably, eh? And it's very
likely that they will keep using a Windows FTP server rather
than switching to UNIX.
Y:\>ftp ftp.microsoft.com
Connected to ftp.microsoft.com.
220 Microsoft FTP Service
User (ftp.microsoft.com:(none)): anonymous
331 Anonymous access allowed, send identity (e-mail name) as password.
Password:
230 Anonymous user logged in.
ftp> literal syst
215 Windows_NT
ftp> literal feat
211-FEAT
SIZE
MDTM
211 END
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: Rory Winston [mailto:rory.winston@gmail.com]
> Sent: Samstag, 08. März 2008 21:39
> To: Jakarta Commons Developers List
> Subject: Re: [VOTE] Release Commons Net 1.5
>
> The functional tests seem to be broken right now, due to the remote
> server being unavailable. These don't get run by default
> anyways, so I
> think we should just leave this for now, unless someone can suggest a
> different server.
>
> Rory
>
> Oberhuber, Martin wrote:
> > Also, I get unit test failures in
> > FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
> > as well as all FTP Windows tests (looks like ftp.wacom.com
> > is down -- should a different Windows FTP Server be added?)
> >
> > Cheers,
> > --
> > Martin Oberhuber, Senior Member of Technical Staff, Wind River
> > Target Management Project Lead, DSDP PMC Member
> > http://www.eclipse.org/dsdp/tm
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: Oberhuber, Martin
> >> Sent: Montag, 03. März 2008 11:50
> >> To: 'Jakarta Commons Developers List'
> >> Subject: RE: [VOTE] Release Commons Net 1.5
> >>
> >> Hi Rory,
> >>
> >> it's great to hear some progress is being made towards a new
> >> commons.net release!!!
> >>
> >> For the 1.5 release candidate, I notice that the binary
> >> JAR now has the examples classes embedded whereas the 1.4
> >> release did not. Also, some Maven POM stuff is in META-INF.
> >> Is this intentional?
> >>
> >> jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort >
> cn141.txt
> >> jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort
> > cn150.txt
> >> diff cn150.txt cn141.txt
> >>
> >> 5,39d4
> >> < META-INF/maven/
> >> < META-INF/maven/commons-net/
> >> < META-INF/maven/commons-net/commons-net/
> >> < META-INF/maven/commons-net/commons-net/pom.properties
> >> < META-INF/maven/commons-net/commons-net/pom.xml
> >> < examples/
> >> < examples/IOUtil.class
> >> [...]
> >> < examples/tftp.class
> >> < examples/weatherTelnet.class
> >> 97d61
> >> < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
> >> 179,180d142
> >> < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
> >> < org/apache/commons/net/tftp/TFTPServer.class
> >>
> >> Also, your Source Package includes some odd files which I
> >> believe should not be part of a release: the "proposal" did
> >> not make it into the binary release, and "src/assembly" has
> >> not been part of 1.4.1:
> >> /propsal/ftp2/
> >> /src/assembly/
> >> /src/java/org/apache/commons/net/tftp/
> >> -! (DIR)
> >> TFTPClient-1.4.1-fix.diff
> >> TFTPClient.java.orig
> >> TFTPClient.java.rej
> >>
> >>
> >> The other thing I'd REALLY consider important especially for a
> >> 1.5.x service release, is a list of changes that were made.
> >> Is such a changelog available anywhere?
> >>
> >> I tried making a source diff, but it throws out ALL files as
> >> different since the copyright headers changed. I think that
> >> the change in copyright terms might also be worth mentioning
> >> in the change log. More changes were indicated due to RCS
> >> Version tags like * @version $Id: .*$
> >> or * @version $Revision: .*$
> >>
> >> That being said, I noticed that the following file(s) do *NOT*
> >> carry the new license header in 1.5:
> >> TFTPClient.java
> >> and others e.g. TimeTCPClientTest.java did even carry an
> >> Apache 1.1 license in version 1.4, or no license at all
> >> (AllTests.java).
> >>
> >> Also, is it legally OK to omit the Copyright Years? In 1.4.1,
> >> some files were Copyright 2001-2005 while others (especially
> >> Telnet) were Copyright 2003-2004 while others (FTPParser)
> >> were Copyright 2004 or Copyright 2005.
> >>
> >> In UnixFTPEntryParserTest.java I see that one test case is
> >> commented out, is this intentional?
> >>
> >> In build.xml you still have this, I think it should not be -dev:
> >> <property name="final.name" value="commons-net-1.5.0-dev">
> >>
> >> I made some semi-automated editing on the source archives,
> >> and came up with following list of files that were changed
> >> for 1.5.0 -- perhaps it helps finding the bugs that were
> >> resolved for 1.5.0, in order to compile a change list:
> >>
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
> >> diff -r -b
> >>
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
> >> tConfig.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
> >> efaultFTPFileEntryParserFactory.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
> >> TPTimestampParserImpl.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
> >> TFTPEntryParser.java
> >> Only in
> >> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> >> /ftp/parser: NetwareFTPEntryParser.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
> >> nixFTPEntryParser.java
> >> diff -r -b
> >>
> commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
> >> tInputStream.java
> >> diff -r -b
> >> commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
> >> ent.java
> >> Only in
> >> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> >> /tftp: TFTPServer.java
> >>
> >> Only in commons-net-1.4.1/target: test-classes
> >> Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
> >>
> >> Cheers,
> >> --
> >> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> >> Target Management Project Lead, DSDP PMC Member
> >> http://www.eclipse.org/dsdp/tm
> >>
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Rory Winston <ro...@gmail.com>.
The functional tests seem to be broken right now, due to the remote
server being unavailable. These don't get run by default anyways, so I
think we should just leave this for now, unless someone can suggest a
different server.
Rory
Oberhuber, Martin wrote:
> Also, I get unit test failures in
> FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
> as well as all FTP Windows tests (looks like ftp.wacom.com
> is down -- should a different Windows FTP Server be added?)
>
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
>
>
>
>
>> -----Original Message-----
>> From: Oberhuber, Martin
>> Sent: Montag, 03. März 2008 11:50
>> To: 'Jakarta Commons Developers List'
>> Subject: RE: [VOTE] Release Commons Net 1.5
>>
>> Hi Rory,
>>
>> it's great to hear some progress is being made towards a new
>> commons.net release!!!
>>
>> For the 1.5 release candidate, I notice that the binary
>> JAR now has the examples classes embedded whereas the 1.4
>> release did not. Also, some Maven POM stuff is in META-INF.
>> Is this intentional?
>>
>> jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
>> jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort > cn150.txt
>> diff cn150.txt cn141.txt
>>
>> 5,39d4
>> < META-INF/maven/
>> < META-INF/maven/commons-net/
>> < META-INF/maven/commons-net/commons-net/
>> < META-INF/maven/commons-net/commons-net/pom.properties
>> < META-INF/maven/commons-net/commons-net/pom.xml
>> < examples/
>> < examples/IOUtil.class
>> [...]
>> < examples/tftp.class
>> < examples/weatherTelnet.class
>> 97d61
>> < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
>> 179,180d142
>> < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
>> < org/apache/commons/net/tftp/TFTPServer.class
>>
>> Also, your Source Package includes some odd files which I
>> believe should not be part of a release: the "proposal" did
>> not make it into the binary release, and "src/assembly" has
>> not been part of 1.4.1:
>> /propsal/ftp2/
>> /src/assembly/
>> /src/java/org/apache/commons/net/tftp/
>> -! (DIR)
>> TFTPClient-1.4.1-fix.diff
>> TFTPClient.java.orig
>> TFTPClient.java.rej
>>
>>
>> The other thing I'd REALLY consider important especially for a
>> 1.5.x service release, is a list of changes that were made.
>> Is such a changelog available anywhere?
>>
>> I tried making a source diff, but it throws out ALL files as
>> different since the copyright headers changed. I think that
>> the change in copyright terms might also be worth mentioning
>> in the change log. More changes were indicated due to RCS
>> Version tags like * @version $Id: .*$
>> or * @version $Revision: .*$
>>
>> That being said, I noticed that the following file(s) do *NOT*
>> carry the new license header in 1.5:
>> TFTPClient.java
>> and others e.g. TimeTCPClientTest.java did even carry an
>> Apache 1.1 license in version 1.4, or no license at all
>> (AllTests.java).
>>
>> Also, is it legally OK to omit the Copyright Years? In 1.4.1,
>> some files were Copyright 2001-2005 while others (especially
>> Telnet) were Copyright 2003-2004 while others (FTPParser)
>> were Copyright 2004 or Copyright 2005.
>>
>> In UnixFTPEntryParserTest.java I see that one test case is
>> commented out, is this intentional?
>>
>> In build.xml you still have this, I think it should not be -dev:
>> <property name="final.name" value="commons-net-1.5.0-dev">
>>
>> I made some semi-automated editing on the source archives,
>> and came up with following list of files that were changed
>> for 1.5.0 -- perhaps it helps finding the bugs that were
>> resolved for 1.5.0, in order to compile a change list:
>>
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
>> tConfig.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
>> efaultFTPFileEntryParserFactory.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
>> TPTimestampParserImpl.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
>> TFTPEntryParser.java
>> Only in
>> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
>> /ftp/parser: NetwareFTPEntryParser.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
>> nixFTPEntryParser.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
>> tInputStream.java
>> diff -r -b
>> commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
>> ent.java
>> Only in
>> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
>> /tftp: TFTPServer.java
>>
>> Only in commons-net-1.4.1/target: test-classes
>> Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
>>
>> Cheers,
>> --
>> Martin Oberhuber, Senior Member of Technical Staff, Wind River
>> Target Management Project Lead, DSDP PMC Member
>> http://www.eclipse.org/dsdp/tm
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release Commons Net 1.5
Posted by "Oberhuber, Martin" <Ma...@windriver.com>.
Also, I get unit test failures in
FTPClientConfigFunctionalTest.testTimeZoneFunctionality()
as well as all FTP Windows tests (looks like ftp.wacom.com
is down -- should a different Windows FTP Server be added?)
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: Oberhuber, Martin
> Sent: Montag, 03. März 2008 11:50
> To: 'Jakarta Commons Developers List'
> Subject: RE: [VOTE] Release Commons Net 1.5
>
> Hi Rory,
>
> it's great to hear some progress is being made towards a new
> commons.net release!!!
>
> For the 1.5 release candidate, I notice that the binary
> JAR now has the examples classes embedded whereas the 1.4
> release did not. Also, some Maven POM stuff is in META-INF.
> Is this intentional?
>
> jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
> jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort > cn150.txt
> diff cn150.txt cn141.txt
>
> 5,39d4
> < META-INF/maven/
> < META-INF/maven/commons-net/
> < META-INF/maven/commons-net/commons-net/
> < META-INF/maven/commons-net/commons-net/pom.properties
> < META-INF/maven/commons-net/commons-net/pom.xml
> < examples/
> < examples/IOUtil.class
> [...]
> < examples/tftp.class
> < examples/weatherTelnet.class
> 97d61
> < org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
> 179,180d142
> < org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
> < org/apache/commons/net/tftp/TFTPServer.class
>
> Also, your Source Package includes some odd files which I
> believe should not be part of a release: the "proposal" did
> not make it into the binary release, and "src/assembly" has
> not been part of 1.4.1:
> /propsal/ftp2/
> /src/assembly/
> /src/java/org/apache/commons/net/tftp/
> -! (DIR)
> TFTPClient-1.4.1-fix.diff
> TFTPClient.java.orig
> TFTPClient.java.rej
>
>
> The other thing I'd REALLY consider important especially for a
> 1.5.x service release, is a list of changes that were made.
> Is such a changelog available anywhere?
>
> I tried making a source diff, but it throws out ALL files as
> different since the copyright headers changed. I think that
> the change in copyright terms might also be worth mentioning
> in the change log. More changes were indicated due to RCS
> Version tags like * @version $Id: .*$
> or * @version $Revision: .*$
>
> That being said, I noticed that the following file(s) do *NOT*
> carry the new license header in 1.5:
> TFTPClient.java
> and others e.g. TimeTCPClientTest.java did even carry an
> Apache 1.1 license in version 1.4, or no license at all
> (AllTests.java).
>
> Also, is it legally OK to omit the Copyright Years? In 1.4.1,
> some files were Copyright 2001-2005 while others (especially
> Telnet) were Copyright 2003-2004 while others (FTPParser)
> were Copyright 2004 or Copyright 2005.
>
> In UnixFTPEntryParserTest.java I see that one test case is
> commented out, is this intentional?
>
> In build.xml you still have this, I think it should not be -dev:
> <property name="final.name" value="commons-net-1.5.0-dev">
>
> I made some semi-automated editing on the source archives,
> and came up with following list of files that were changed
> for 1.5.0 -- perhaps it helps finding the bugs that were
> resolved for 1.5.0, in order to compile a change list:
>
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClien
> tConfig.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/D
> efaultFTPFileEntryParserFactory.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/F
> TPTimestampParserImpl.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/N
> TFTPEntryParser.java
> Only in
> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> /ftp/parser: NetwareFTPEntryParser.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/U
> nixFTPEntryParser.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/telnet/Telne
> tInputStream.java
> diff -r -b
> commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPCli
> ent.java
> Only in
> commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net
> /tftp: TFTPServer.java
>
> Only in commons-net-1.4.1/target: test-classes
> Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
>
> Cheers,
> --
> Martin Oberhuber, Senior Member of Technical Staff, Wind River
> Target Management Project Lead, DSDP PMC Member
> http://www.eclipse.org/dsdp/tm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
RE: [VOTE] Release Commons Net 1.5
Posted by "Oberhuber, Martin" <Ma...@windriver.com>.
Hi Rory,
it's great to hear some progress is being made towards a new
commons.net release!!!
For the 1.5 release candidate, I notice that the binary
JAR now has the examples classes embedded whereas the 1.4
release did not. Also, some Maven POM stuff is in META-INF.
Is this intentional?
jar tfv commons-net-1.4.1.jar | awk '{print $8;}' | sort > cn141.txt
jar tfv commons-net-1.5.0*.jar | awk '{print $8;}' | sort > cn150.txt
diff cn150.txt cn141.txt
5,39d4
< META-INF/maven/
< META-INF/maven/commons-net/
< META-INF/maven/commons-net/commons-net/
< META-INF/maven/commons-net/commons-net/pom.properties
< META-INF/maven/commons-net/commons-net/pom.xml
< examples/
< examples/IOUtil.class
[...]
< examples/tftp.class
< examples/weatherTelnet.class
97d61
< org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.class
179,180d142
< org/apache/commons/net/tftp/TFTPServer$TFTPTransfer.class
< org/apache/commons/net/tftp/TFTPServer.class
Also, your Source Package includes some odd files which I
believe should not be part of a release: the "proposal" did
not make it into the binary release, and "src/assembly" has
not been part of 1.4.1:
/propsal/ftp2/
/src/assembly/
/src/java/org/apache/commons/net/tftp/
-! (DIR)
TFTPClient-1.4.1-fix.diff
TFTPClient.java.orig
TFTPClient.java.rej
The other thing I'd REALLY consider important especially for a
1.5.x service release, is a list of changes that were made.
Is such a changelog available anywhere?
I tried making a source diff, but it throws out ALL files as
different since the copyright headers changed. I think that
the change in copyright terms might also be worth mentioning
in the change log. More changes were indicated due to RCS
Version tags like * @version $Id: .*$
or * @version $Revision: .*$
That being said, I noticed that the following file(s) do *NOT*
carry the new license header in 1.5:
TFTPClient.java
and others e.g. TimeTCPClientTest.java did even carry an
Apache 1.1 license in version 1.4, or no license at all
(AllTests.java).
Also, is it legally OK to omit the Copyright Years? In 1.4.1,
some files were Copyright 2001-2005 while others (especially
Telnet) were Copyright 2003-2004 while others (FTPParser)
were Copyright 2004 or Copyright 2005.
In UnixFTPEntryParserTest.java I see that one test case is
commented out, is this intentional?
In build.xml you still have this, I think it should not be -dev:
<property name="final.name" value="commons-net-1.5.0-dev">
I made some semi-automated editing on the source archives,
and came up with following list of files that were changed
for 1.5.0 -- perhaps it helps finding the bugs that were
resolved for 1.5.0, in order to compile a change list:
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTP.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClient.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/FTPClientConfig.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/DefaultFTPFileEntryParserFactory.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/FTPTimestampParserImpl.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
Only in commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net/ftp/parser: NetwareFTPEntryParser.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/nntp/Article.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/telnet/TelnetInputStream.java
diff -r -b commons-net-1.4.1/src/java/org/apache/commons/net/tftp/TFTPClient.java
Only in commons-net-1.5.0-SNAPSHOT-src/src/java/org/apache/commons/net/tftp: TFTPServer.java
Only in commons-net-1.4.1/target: test-classes
Only in commons-net-1.5.0-SNAPSHOT-src: xdocs
Cheers,
--
Martin Oberhuber, Senior Member of Technical Staff, Wind River
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
> -----Original Message-----
> From: Rory Winston [mailto:rory.winston@gmail.com]
> Sent: Sonntag, 02. März 2008 22:40
> To: Jakarta Commons Developers List
> Subject: [VOTE] Release Commons Net 1.5
>
> Hi
>
> This is a release vote for Commons Net 1.5. This release fixes a few
> issues with TFTP errors, threading hangs, and a leap year
> date parsing bug.
>
> The RC deployment is here:
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>
> Binaries:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-n
> et-1.5.0-SNAPSHOT-bin.zip
>
> Source:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-n
> et-1.5.0-SNAPSHOT-src.tar.gz
>
> Javadocs:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/apid
> ocs/index.html
>
> SVN tag:
>
> http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>
> Here's my +1 in advance.
> Cheers
> Rory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Net 1.5
Posted by Jeffrey Brekke <ek...@gmail.com>.
I have compiler errors:
/home/jbrekke/sandbox/other/net/src/test/org/apache/commons/net/tftp/TFTPTests.java:[33,8]
cannot find symbol
symbol : class TFTPServer
location: class org.apache.commons.net.tftp.TFTPTests
/home/jbrekke/sandbox/other/net/src/test/org/apache/commons/net/tftp/TFTPTests.java:[55,15]
cannot find symbol
symbol : class TFTPServer
location: class org.apache.commons.net.tftp.TFTPTests
/home/jbrekke/sandbox/other/net/src/test/org/apache/commons/net/tftp/TFTPTests.java:[55,66]
cannot find symbol
symbol : variable TFTPServer
location: class org.apache.commons.net.tftp.TFTPTests
This was removed, but there is still a test that needs it?
On Sun, Mar 2, 2008 at 3:40 PM, Rory Winston <ro...@gmail.com> wrote:
> Hi
>
> This is a release vote for Commons Net 1.5. This release fixes a few
> issues with TFTP errors, threading hangs, and a leap year date parsing bug.
>
> The RC deployment is here:
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/
>
> Binaries:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-bin.zip
>
> Source:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/commons-net-1.5.0-SNAPSHOT-src.tar.gz
>
> Javadocs:
>
> http://people.apache.org/~rwinston/commons-net-1.5.0/site/apidocs/index.html
>
> SVN tag:
>
> http://svn.apache.org/viewvc/commons/proper/net/tags/NET_1_5_0/
>
> Here's my +1 in advance.
> Cheers
> Rory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
--
Jeffrey D. Brekke
Wisconsin, USA
brekke at apache dot org
ekkerbj at gmail dot com
jbrekke at wi dot rr dot com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org